Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exclamation marks #107683

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Remove exclamation marks #107683

merged 1 commit into from
Jul 15, 2022

Conversation

LongCatIsLooong
Copy link
Contributor

Remove some unnecessary !s in input decorator.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 14, 2022
justinmc
justinmc approved these changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for cleaning this up!

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2022
@auto-submit auto-submit bot merged commit d728539 into flutter:master Jul 15, 2022
@LongCatIsLooong LongCatIsLooong deleted the remove-exclamation-marks branch July 15, 2022 18:55
This was referenced Jul 16, 2022
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
d728539 Remove exclamation marks (flutter/flutter#107683)
0a3ae6e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
6b3df34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
d7a49bc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
6bc6255
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
71067e7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
bfed48d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
c447329
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
12e9f66
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
47fba04
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
e16b264
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
87e5bd4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
66b768e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
3f51bc4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
4ff8386
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
a0b3746
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
08cb7a9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
d109438
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
7ef1e7b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
0152522
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
d879c25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
3f243d1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
d8766e9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
dd9524f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
48bce1a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
776f628
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
e5a5659
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
362e696
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
6663e67
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
dadd6f0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
594805f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
d47cd46
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
b87ffb8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
2cd950f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
38a8cf8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022
@engine-flutter-autoroll
d72853940 Remove exclamation marks (flutter/flutter#107683)
38882fc
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@LongCatIsLooong @camsim99
Remove exclamation marks (flutter#107683)
053b4ba
@wangjiejacques wangjiejacques mentioned this pull request Sep 28, 2022
Closed
@limenote135
Copy link

@LongCatIsLooong @justinmc Is there a plan to hotfix this into the stable branch? Many users are facing this issue.

@justinmc
Copy link
Contributor

@limenote135 What is the issue exactly? I want to make sure I understand which of the changes in this PR are unblocking you and in what way.

@limenote135
Copy link

@justinmc This fixes issues: #111095, #112046, #111939, #97634.
After upgrading flutter 3.3 from 3.0, this error is reported significantly.

@justinmc
Copy link
Contributor

Perfect, thank you!

@itsjustkevin Are we able to cherry-pick this fix?

@limenote135
Copy link

@justinmc @itsjustkevin hi, how is it going?

@DjordjeMancic97
Copy link

Hi I am experiencing issue which this PR is supposed to fix. When will this come to stable branch?

Null check operator used on a null value.
at .#0 State.widget (package:flutter/src/widgets/framework.dart:909:26)
at .#1 EditableTextState._value (package:flutter/src/widgets/editable_text.dart:2351:34)
at .#2 EditableTextState.updateEditingValue (package:flutter/src/widgets/editable_text.dart:2084:18)
at .#3 TextInput._handleTextInputInvocation (package:flutter/src/services/text_input.dart:1769:29)
at .#4 DefaultPlatformMenuDelegate._methodCallHandler (package:flutter/src/widgets/platform_menu_bar.dart:461:21)
at .#5 min (dart:math-patch/math_patch.dart:35:21)
at .#6 new Rect.fromPoints (dart:ui/geometry.dart:670:10)
at .#7 TypeTestingStub_MHi__Kua__X0_21928+0x2f
at .#8 DateTime._yearsFromSecondsSinceEpoch (dart:core-patch/date_patch.dart:377:3)
at .#9 SchedulerBinding.scheduleWarmUpFrame. (package:flutter/src/scheduler/binding.dart:899:16)
at .#10 PlatformDispatcher._unpackPointerDataPacket (dart:ui/platfor

@LongCatIsLooong
Copy link
Contributor Author

@DjordjeMancic97 from the stacktrace this is not the same issue. It may have to do with the platform menu system. Could you open a new issue if there isn't one?

For those on the stable branch, the diff is one line: https://github.com/flutter/flutter/pull/107683/files#diff-f5f93c879cef9a102adbf148583de9f3d9a05f9678fdcad7bde106f62200bb34 so it's an option to patch this locally for the time being.

@justinmc justinmc mentioned this pull request Oct 17, 2022
Closed
justinmc pushed a commit to justinmc/flutter that referenced this pull request Oct 17, 2022
@LongCatIsLooong @justinmc
Remove exclamation marks (flutter#107683)
4060e9f
@justinmc justinmc mentioned this pull request Oct 17, 2022
Merged
CaseyHillers pushed a commit that referenced this pull request Oct 31, 2022
@justinmc @LongCatIsLooong
[CP] Remove exclamation marks (#107683) (#113553)
8536931 
Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
Co-authored-by: Casey Hillers <chillers@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LongCatIsLooong @limenote135 @justinmc @DjordjeMancic97