Migrate TextField to Material 3 #108366
Merged
Migrate TextField to Material 3 #108366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
flutter-dashboard
bot
added
the
team
HansMuller
approved these changes
Jul 27, 2022
| editableText = tester.widget(find.byType(EditableText)); | ||
| expect(editableText.style.color, setColor); | ||
|
|
||
| // inherit: false causes nothing to be merged in from theme |
| String generate() => ''' | ||
| // Generated version ${tokens["version"]} | ||
|
|
||
| TextStyle _m3InputStyle(BuildContext context) => ${textStyle("md.comp.filled-text-field.label-text")}!; |
There was a problem hiding this comment.
Filled text fields and outlined text fields use the same text style? Same color?
There was a problem hiding this comment.
Yes they are the same
This was referenced Jul 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 28, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
* Update input style * generate M3 text style * Add test
|
@hangyujin I tried the Affected widgets: (not including TextField) |
|
How do I get the "filled" text field style in material 3? Example on the left (Image from #103537) Edit: Nevermind, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #103537
Migrate TextField to Material 3.
The inputDecorator is already migrated to M3 with fillColor, boderColor, iconColor, label text style, supporting text style.
So this PR is just to migrate input text style because it's in TextField, not the InputDecorator.
Pre-launch Checklist
///).