Add usage event when macOS app is archived #108651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
added
tool
jmagman
force-pushed
the
macos-usage-archive
branch
from
f2f3269
to
e575f8f
Compare
| @@ -58,7 +58,7 @@ BuildApp() { | |||
| # arguments. | |||
| local flutter_args=("${FLUTTER_ROOT}/bin/flutter") | |||
| if [[ -n "$VERBOSE_SCRIPT_LOGGING" ]]; then | |||
| flutter_args+=('--verbose') | |||
| flutter_args+=('--verbose') | |||
There was a problem hiding this comment.
was this de-dent intentional?
There was a problem hiding this comment.
Mistake, you beat me reverting it by a second.
There was a problem hiding this comment.
lol, yeah, I saw that
There was a problem hiding this comment.
It's Friday evening and we're on fire. 🔥
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jul 30, 2022
camsim99
pushed a commit
to camsim99/flutter
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add usage event within
flutter assemblewhen the app is being archived. There is no way to archive a macOS app from thefluttertool right now, so this will catch in-Xcode archiving.The event is category=
assemble, parameter=macos-archive, label=successorfail.There are barely any macOS integration tests, I validated manually by archiving in Xcode:
macOS version of #108643.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.