-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add usage event when macOS app is archived #108651
Conversation
f2f3269
to
e575f8f
Compare
@@ -58,7 +58,7 @@ BuildApp() { | |||
# arguments. | |||
local flutter_args=("${FLUTTER_ROOT}/bin/flutter") | |||
if [[ -n "$VERBOSE_SCRIPT_LOGGING" ]]; then | |||
flutter_args+=('--verbose') | |||
flutter_args+=('--verbose') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this de-dent intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mistake, you beat me reverting it by a second.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol, yeah, I saw that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's Friday evening and we're on fire. 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add usage event within
flutter assemble
when the app is being archived. There is no way to archive a macOS app from theflutter
tool right now, so this will catch in-Xcode archiving.The event is category=
assemble
, parameter=macos-archive
, label=success
orfail
.There are barely any macOS integration tests, I validated manually by archiving in Xcode:
macOS version of #108643.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.