Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradlew/gradlew.bat should not be gitignored according to official doc #109750

Closed
wants to merge 1 commit into from

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Aug 18, 2022

Close #109749

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@fzyzcjy fzyzcjy marked this pull request as ready for review August 18, 2022 01:45
@jonahwilliams
Copy link
Member

This is the repo's gitignore, not a template file gitignore.

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Aug 18, 2022

I know. The problem is, maybe flutter repo itself also need to follow gradle's official suggestion?

@jonahwilliams
Copy link
Member

We've done this historically because the tool can handle re-generating this and to avoid churn in the repo when the contents of this file changes.

@jonahwilliams
Copy link
Member

I'm going to close this PR, as we don't intend to accept this change. If something changes we can always reconsider

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Aug 18, 2022

I see. Thanks all the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gradlew/gradlew.bat should not be gitignored according to official doc
2 participants