[CP] Generated Plugin Registrant Null Safety Fix #109906
Conversation
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
flutter-dashboard
bot
changed the base branch from
flutter-3.2-candidate.5
to
master
flutter-dashboard
bot
added
engine
MatthewPatience
changed the base branch from
master
to
flutter-3.2-candidate.5
goderbauer
removed
the
framework
|
CP request at #109905 |
|
I believe candidate 5 was released, should this be targeted at a different branch now? |
No, all hotfix releases go on the same branch. candidate 5 means the 5th (actually 6th, since it's 0-indexed) candidate branch point from master that could become a release. |
|
@MatthewPatience can you rebase this PR with the upstream branch? It seems to be missing a CP that is causing the tests to fail. |
|
@CaseyHillers I checked and I don't see anything to be pulled in from the upstream branch. I actually did merge in the latest a couple days ago and that is what caused the tests to start failing. Checking some other PR's I see they have the same tests failing. |
You're missing the 3 newest commits from https://github.com/flutter/flutter/commits/flutter-3.2-candidate.5. Make sure you're fetching from the correct remote before merging. |
Oops, never mind, I think I read the git log wrong, this looks up to date to me. |
|
Ah ok, I don't need to pull my hair out then! Is someone able to merge this, it's quite important to us! |
|
FYI I filed #110531 as these failures aren't related to your PR. That issue should get fixed today, and I'll ensure this get submitted. |
…h and without null safety. (#109480) (flutter/flutter#109906)
…h and without null safety. (#109480) (flutter/flutter#109906)
|
Thank you for taking care of this cherry pick @MatthewPatience! |
|
No worries, it was quite important to us, thanks to you for continuing to develop Flutter! |
Cherry pick to add this severe issue fix to the current beta build that is causing all web builds without null safety to fail when targeting the beta branch.
#109160