-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Show output from pub get
in flutter pub get
"
#110478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3802eb6.
flutter-dashboard
bot
added
a: text input
Entering text in a text field or keyboard related problems
team
Infra upgrades, team productivity, code health, technical debt. See also team: labels.
tool
Affects the "flutter" command-line tool. See also t: labels.
labels
Aug 29, 2022
Timing out on the step:
|
zanderso
added
warning: land on red to fix tree breakage
Override tree-status signal (land even with closed tree), combine with the autosubmit label.
autosubmit
Merge PR when tree becomes green via auto submit App
labels
Aug 29, 2022
|
auto-submit
bot
removed
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Aug 29, 2022
Validations Fail. |
godofredoc
approved these changes
Aug 29, 2022
This was referenced Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 1, 2022
The problem appears to be in the Flutter test that is timing out. It is running "dart pub get" in a subprocess using Dart's Process.start, but not listening on or draining stdout, so it is hanging if the pipe gets full. https://github.com/flutter/flutter/blob/master/dev/devicelab/lib/tasks/web_dev_mode_tests.dart#L45 |
sigurdm
added a commit
to sigurdm/flutter
that referenced
this pull request
Sep 2, 2022
…ter#106300)" (flutter#110478)" This reverts commit 0e195e9.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: text input
Entering text in a text field or keyboard related problems
team
Infra upgrades, team productivity, code health, technical debt. See also team: labels.
tool
Affects the "flutter" command-line tool. See also t: labels.
warning: land on red to fix tree breakage
Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #106300
This PR appears to have caused persistent timing out on Windows for the test here: https://ci.chromium.org/p/flutter/builders/prod/Windows_android%20windows_chrome_dev_mode