Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Show output from pub get in flutter pub get" #110478

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

zanderso
Copy link
Member

Reverts #106300

This PR appears to have caused persistent timing out on Windows for the test here: https://ci.chromium.org/p/flutter/builders/prod/Windows_android%20windows_chrome_dev_mode

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 29, 2022
@zanderso
Copy link
Member Author

Timing out on the step:

[windows_chrome_dev_mode] [STDOUT] Executing "C:\opt\s\w\ir\x\w\recipe_cleanup\tmp1ippl8tu\flutter sdk\bin\flutter packages get" in "C:\opt\s\w\ir\x\t\edited_flutter_gallery" with environment {BOT: true, LANG: en_US.UTF-8}

@zanderso zanderso added warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label. autosubmit Merge PR when tree becomes green via auto submit App labels Aug 29, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 29, 2022

  • Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 29, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 29, 2022

Validations Fail.

@zanderso zanderso merged commit 0e195e9 into master Aug 29, 2022
@zanderso zanderso deleted the revert-106300-pub_get_output branch August 29, 2022 15:02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2022
@whesse
Copy link
Contributor

whesse commented Sep 2, 2022

The problem appears to be in the Flutter test that is timing out. It is running "dart pub get" in a subprocess using Dart's Process.start, but not listening on or draining stdout, so it is hanging if the pipe gets full.

https://github.com/flutter/flutter/blob/master/dev/devicelab/lib/tasks/web_dev_mode_tests.dart#L45

sigurdm added a commit to sigurdm/flutter that referenced this pull request Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: text input Entering text in a text field or keyboard related problems team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. warning: land on red to fix tree breakage Override tree-status signal (land even with closed tree), combine with the autosubmit label.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants