[flutter_tools] cache more directories #112651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
jonahwilliams
changed the title
jonahwilliams
commented
Sep 29, 2022
|
|
||
| // .basename is surprisingly slow as it hits the real file system to ask for the | ||
| // current directory. | ||
| String _approximateBasename(FileSystemEntity entity, FileSystem fileSystem) { |
There was a problem hiding this comment.
This was a large part of the performance fix. Even though we cache the Path context on our error handling filesystem, at this point entity.fileSystem returns localFileSystem instead of ErrorHandlingFIleSystem.
jonahwilliams
changed the title
|
With #112673, is the workaround for using the right filesystem object no longer necessary? |
|
Correct, I'll remove that part |
jonahwilliams
changed the title
andrewkolos
added
the
autosubmit
This was referenced Sep 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 30, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Sep 30, 2022
jonahwilliams
added a commit
that referenced
this pull request
Sep 30, 2022
This reverts commit 99fb2d3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112640