Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bitcode deprecation note for add-to-app iOS developers #112900

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Add bitcode deprecation note for add-to-app iOS developers #112900

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
517b686
Add bitcode deprecation note for add-to-app iOS developers
jmagman Oct 5, 2022
06554fa
stderr
jmagman Oct 5, 2022
38bb46b
unused local
jmagman Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
const String outputDirectoryName = 'flutter-frameworks';

await inDirectory(projectDir, () async {
await flutter(
final StringBuffer outputError = StringBuffer();
final String output = await evalFlutter(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

RUNNING: cd .; bin/flutter analyze --flutter-repo
Analyzing 3 items...                                            

   info • The value of the local variable 'output' isn't used • dev/devicelab/bin/tasks/build_ios_framework_module_test.dart:91:18 • unused_local_variable

1 issue found. (ran in 122.4s)

'build',
options: <String>[
'ios-framework',
Expand All @@ -96,7 +97,11 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
'--obfuscate',
'--split-debug-info=symbols',
],
stderr: outputError,
);
if (!outputError.toString().contains('Bitcode support has been deprecated.')) {
throw TaskResult.failure('Missing bitcode deprecation warning');
}
});

final String outputPath = path.join(projectDir.path, outputDirectoryName);
Expand Down
4 changes: 4 additions & 0 deletions packages/flutter_tools/lib/src/commands/build_ios_framework.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,10 @@ class BuildIOSFrameworkCommand extends BuildFrameworkCommand {
'See https://flutter.dev/docs/development/add-to-app/ios/add-flutter-screen#create-a-flutterengine for more information.');
}

globals.printWarning(
'Bitcode support has been deprecated. Turn off the "Enable Bitcode" build setting in your Xcode project or you may encounter compilation errors.\n'
'See https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes for details.');

return FlutterCommandResult.success();
}

Expand Down