Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Minor change type nullability" #113246

Merged
merged 1 commit into from Oct 11, 2022
Merged

Revert "Minor change type nullability" #113246

merged 1 commit into from Oct 11, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 11, 2022

Reverts #112778

This caused gallery to stop building: #113245

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Oct 11, 2022
@jmagman
Copy link
Member Author

jmagman commented Oct 11, 2022

cc @fzyzcjy

@jmagman jmagman added the revert Autorevert PR (with "Reason for revert:" comment) label Oct 11, 2022
jonahwilliams
jonahwilliams approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman removed the revert Autorevert PR (with "Reason for revert:" comment) label Oct 11, 2022
@jmagman jmagman merged commit 117407b into master Oct 11, 2022
@jmagman jmagman deleted the revert-112778-patch-21 branch October 11, 2022 00:57
@jmagman jmagman mentioned this pull request Oct 11, 2022
Closed
@fzyzcjy
Copy link
Contributor

fzyzcjy commented Oct 11, 2022 •
edited

So, shall I update that sample which breaks tree and PR again, or shall I just leave it there (the imperfect nullability)? 👀

Btw is there any methods I can know it will break the tree before merging - I do not intend to do so :(

@jmagman
Copy link
Member Author

jmagman commented Oct 11, 2022

Btw is there any methods I can know it will break the tree before merging - I do not intend to do so :(

You can check if https://github.com/flutter/gallery flutter runs on your change. I filed #113248 so we can build that project in presubmit to catch breakages.

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Oct 11, 2022

@jmagman Thanks!

@fzyzcjy fzyzcjy mentioned this pull request Oct 11, 2022
Open
@fzyzcjy
Copy link
Contributor

fzyzcjy commented Oct 11, 2022

FYI, upstream PR created: letsar/flutter_staggered_grid_view#274

This was referenced Oct 11, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2022
@engine-flutter-autoroll
117407b0f Revert "Minor change type nullability (#112778)" (flutter/f…
fc756a3 
…lutter#113246)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 11, 2022
@engine-flutter-autoroll
117407b Revert "Minor change type nullability (#112778)" (flutter/flu…
9b4bdd6 
…tter#113246)
@jmagman
Copy link
Member Author

jmagman commented Oct 11, 2022

FYI, upstream PR created: letsar/flutter_staggered_grid_view#274

@fzyzcjy I am not an expert in this, but I believe that this test failure makes this a breaking change? Can you make sure to coordinate in Discord with #hackers-framework about what to do instead of just changing flutter_staggered_grid_view?

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Oct 11, 2022

but I believe that this test failure makes this a breaking change

You are right, I forgot that and will do that soon.

CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request Oct 13, 2022
@jmagman
Revert "Minor change type nullability (flutter#112778)" (flutter#113246)
b8683f1 
This reverts commit 21fab6f.
CaseyHillers pushed a commit that referenced this pull request Oct 13, 2022
@jmagman
[releases] Revert "Minor change type nullability (#112778)" (#113246) (…
bc56530 
…#113399)

This reverts commit 21fab6f.

Co-authored-by: Jenn Magder <magder@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmagman @fzyzcjy @jonahwilliams