Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated instructions for adding new localized messages. #115390

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Updated instructions for adding new localized messages. #115390

merged 1 commit into from
Nov 16, 2022

Conversation

harperl-lgtm
Copy link
Contributor

This PR updated the instructions for adding new localized messages.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 15, 2022
@harperl-lgtm harperl-lgtm marked this pull request as ready for review November 15, 2022 21:45
@harperl-lgtm harperl-lgtm merged commit 490fe28 into flutter:master Nov 16, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
b6b90bf 
…ter/flutter#115390)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
15cc9bf 
…ter/flutter#115390)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll
Roll Flutter from dcae424 to 537f89c (26 revisions) (#2821)
059222f 
* d359af2 a062a2063 [macOS] Merge FlutterMetalCompositor, superclass (flutter/engine#37648) (flutter/flutter#115474)

* cacf1d2 Roll Flutter Engine from a062a20638d1 to 97974ebb5ff8 (3 revisions) (flutter/flutter#115478)

* 490fe28 Updated instructions for adding new localized messages. (flutter/flutter#115390)

* 84357cb re-enable firebase release smoke test since infra outage is over (flutter/flutter#115402)

* f205471 Use concrete factory constructor for DomXMLHttpRequest (flutter/flutter#115094)

* 55927d8 3c83b275a [Impeller] Reland: Refactor color source resolution to use explicit factory types (flutter/engine#37677) (flutter/flutter#115482)

* 829e44d Fixed label alignment (flutter/flutter#115409)

* b579109 Roll Flutter Engine from 3c83b275a511 to 35ecb2bf4139 (2 revisions) (flutter/flutter#115495)

* d01874d [framework] re-rasterize page transition when layout size changes (flutter/flutter#115371)

* 68740a2 fee463552 Roll Fuchsia Linux SDK from T7_W8eoMNuMdG-5R9... to haqxMhaSf7-4ZeVL8... (flutter/engine#37684) (flutter/flutter#115498)

* 26a990f Roll Flutter Engine from fee463552a93 to c5e6a38dd0bc (2 revisions) (flutter/flutter#115504)

* f255390 Remove redundant arguments passed to redirecting factory constructors (flutter/flutter#115497)

* 20139c6 4f3f45617 Move windows engine_v2 to prod. (flutter/engine#37680) (flutter/flutter#115508)

* 2ad4dc5 dcdb96e9d Roll Skia from 1dfecd7cd478 to 7f385b0ae434 (9 revisions) (flutter/engine#37693) (flutter/flutter#115512)

* 9c54635 Bump codecov/codecov-action from 3.1.0 to 3.1.1 (flutter/flutter#113126)

* fafa11d Roll Flutter Engine from dcdb96e9db6b to cb403c1feaee (2 revisions) (flutter/flutter#115516)

* 59f389d Remove unneeded comparison to `double.nan` (flutter/flutter#115470)

* c071950 d422023f3 Migrate const_finder tests to be null safe (flutter/engine#37683) (flutter/flutter#115524)

* bf6d0f3 5bbf070c3 Roll Skia from 7f385b0ae434 to 8589c8ac6ee6 (1 revision) (flutter/engine#37702) (flutter/flutter#115531)

* 83d205e 7156b87c7 Roll Skia from 8589c8ac6ee6 to 68784d303cd6 (4 revisions) (flutter/engine#37705) (flutter/flutter#115538)

* 7e8568b 83c2482d7 [Impeller] Add Impeller scene (flutter/engine#37694) (flutter/flutter#115541)

* 07de108 ad3038c25 Roll Skia from 68784d303cd6 to 95ac3b53be37 (1 revision) (flutter/engine#37706) (flutter/flutter#115548)

* 1b23ad6 Roll Flutter Engine from ad3038c25cfa to 832aae2f850a (2 revisions) (flutter/flutter#115552)

* e8cbd44 Added Badge.isLabelVisible flag (flutter/flutter#115292)

* e9622ce Added Badge.count constructor (flutter/flutter#115297)

* 537f89c Revert "Added Badge.count constructor (#115297)" (flutter/flutter#115564)
percula pushed a commit to percula/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll @percula
Roll Flutter from dcae424 to 537f89c (26 revisions) (flutter#2821)
a5d41d9 
* d359af2 a062a2063 [macOS] Merge FlutterMetalCompositor, superclass (flutter/engine#37648) (flutter/flutter#115474)

* cacf1d2 Roll Flutter Engine from a062a20638d1 to 97974ebb5ff8 (3 revisions) (flutter/flutter#115478)

* 490fe28 Updated instructions for adding new localized messages. (flutter/flutter#115390)

* 84357cb re-enable firebase release smoke test since infra outage is over (flutter/flutter#115402)

* f205471 Use concrete factory constructor for DomXMLHttpRequest (flutter/flutter#115094)

* 55927d8 3c83b275a [Impeller] Reland: Refactor color source resolution to use explicit factory types (flutter/engine#37677) (flutter/flutter#115482)

* 829e44d Fixed label alignment (flutter/flutter#115409)

* b579109 Roll Flutter Engine from 3c83b275a511 to 35ecb2bf4139 (2 revisions) (flutter/flutter#115495)

* d01874d [framework] re-rasterize page transition when layout size changes (flutter/flutter#115371)

* 68740a2 fee463552 Roll Fuchsia Linux SDK from T7_W8eoMNuMdG-5R9... to haqxMhaSf7-4ZeVL8... (flutter/engine#37684) (flutter/flutter#115498)

* 26a990f Roll Flutter Engine from fee463552a93 to c5e6a38dd0bc (2 revisions) (flutter/flutter#115504)

* f255390 Remove redundant arguments passed to redirecting factory constructors (flutter/flutter#115497)

* 20139c6 4f3f45617 Move windows engine_v2 to prod. (flutter/engine#37680) (flutter/flutter#115508)

* 2ad4dc5 dcdb96e9d Roll Skia from 1dfecd7cd478 to 7f385b0ae434 (9 revisions) (flutter/engine#37693) (flutter/flutter#115512)

* 9c54635 Bump codecov/codecov-action from 3.1.0 to 3.1.1 (flutter/flutter#113126)

* fafa11d Roll Flutter Engine from dcdb96e9db6b to cb403c1feaee (2 revisions) (flutter/flutter#115516)

* 59f389d Remove unneeded comparison to `double.nan` (flutter/flutter#115470)

* c071950 d422023f3 Migrate const_finder tests to be null safe (flutter/engine#37683) (flutter/flutter#115524)

* bf6d0f3 5bbf070c3 Roll Skia from 7f385b0ae434 to 8589c8ac6ee6 (1 revision) (flutter/engine#37702) (flutter/flutter#115531)

* 83d205e 7156b87c7 Roll Skia from 8589c8ac6ee6 to 68784d303cd6 (4 revisions) (flutter/engine#37705) (flutter/flutter#115538)

* 7e8568b 83c2482d7 [Impeller] Add Impeller scene (flutter/engine#37694) (flutter/flutter#115541)

* 07de108 ad3038c25 Roll Skia from 68784d303cd6 to 95ac3b53be37 (1 revision) (flutter/engine#37706) (flutter/flutter#115548)

* 1b23ad6 Roll Flutter Engine from ad3038c25cfa to 832aae2f850a (2 revisions) (flutter/flutter#115552)

* e8cbd44 Added Badge.isLabelVisible flag (flutter/flutter#115292)

* e9622ce Added Badge.count constructor (flutter/flutter#115297)

* 537f89c Revert "Added Badge.count constructor (#115297)" (flutter/flutter#115564)
johnpryan pushed a commit to Slowhand0309/packages that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll @johnpryan
Roll Flutter from dcae424 to 537f89c (26 revisions) (flutter#2821)
559ab71 
* d359af2 a062a2063 [macOS] Merge FlutterMetalCompositor, superclass (flutter/engine#37648) (flutter/flutter#115474)

* cacf1d2 Roll Flutter Engine from a062a20638d1 to 97974ebb5ff8 (3 revisions) (flutter/flutter#115478)

* 490fe28 Updated instructions for adding new localized messages. (flutter/flutter#115390)

* 84357cb re-enable firebase release smoke test since infra outage is over (flutter/flutter#115402)

* f205471 Use concrete factory constructor for DomXMLHttpRequest (flutter/flutter#115094)

* 55927d8 3c83b275a [Impeller] Reland: Refactor color source resolution to use explicit factory types (flutter/engine#37677) (flutter/flutter#115482)

* 829e44d Fixed label alignment (flutter/flutter#115409)

* b579109 Roll Flutter Engine from 3c83b275a511 to 35ecb2bf4139 (2 revisions) (flutter/flutter#115495)

* d01874d [framework] re-rasterize page transition when layout size changes (flutter/flutter#115371)

* 68740a2 fee463552 Roll Fuchsia Linux SDK from T7_W8eoMNuMdG-5R9... to haqxMhaSf7-4ZeVL8... (flutter/engine#37684) (flutter/flutter#115498)

* 26a990f Roll Flutter Engine from fee463552a93 to c5e6a38dd0bc (2 revisions) (flutter/flutter#115504)

* f255390 Remove redundant arguments passed to redirecting factory constructors (flutter/flutter#115497)

* 20139c6 4f3f45617 Move windows engine_v2 to prod. (flutter/engine#37680) (flutter/flutter#115508)

* 2ad4dc5 dcdb96e9d Roll Skia from 1dfecd7cd478 to 7f385b0ae434 (9 revisions) (flutter/engine#37693) (flutter/flutter#115512)

* 9c54635 Bump codecov/codecov-action from 3.1.0 to 3.1.1 (flutter/flutter#113126)

* fafa11d Roll Flutter Engine from dcdb96e9db6b to cb403c1feaee (2 revisions) (flutter/flutter#115516)

* 59f389d Remove unneeded comparison to `double.nan` (flutter/flutter#115470)

* c071950 d422023f3 Migrate const_finder tests to be null safe (flutter/engine#37683) (flutter/flutter#115524)

* bf6d0f3 5bbf070c3 Roll Skia from 7f385b0ae434 to 8589c8ac6ee6 (1 revision) (flutter/engine#37702) (flutter/flutter#115531)

* 83d205e 7156b87c7 Roll Skia from 8589c8ac6ee6 to 68784d303cd6 (4 revisions) (flutter/engine#37705) (flutter/flutter#115538)

* 7e8568b 83c2482d7 [Impeller] Add Impeller scene (flutter/engine#37694) (flutter/flutter#115541)

* 07de108 ad3038c25 Roll Skia from 68784d303cd6 to 95ac3b53be37 (1 revision) (flutter/engine#37706) (flutter/flutter#115548)

* 1b23ad6 Roll Flutter Engine from ad3038c25cfa to 832aae2f850a (2 revisions) (flutter/flutter#115552)

* e8cbd44 Added Badge.isLabelVisible flag (flutter/flutter#115292)

* e9622ce Added Badge.count constructor (flutter/flutter#115297)

* 537f89c Revert "Added Badge.count constructor (#115297)" (flutter/flutter#115564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 17, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
35bcb1d 
…ter/flutter#115390)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
2dc435d 
…ter/flutter#115390)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
fdcb936 
…ter/flutter#115390)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
3231eb4 
…ter/flutter#115390)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
b99dad8 
…ter/flutter#115390)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
c97a59e 
…ter/flutter#115390)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
86d3b7d 
…ter/flutter#115390)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
490fe28 Updated instructions for adding new localized messages. (flut…
3af0316 
…ter/flutter#115390)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@harperl-lgtm @shogohida
Updated instructions for adding new localized messages. (flutter#115390)
a2af58e
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@harperl-lgtm @gspencergoog
Updated instructions for adding new localized messages. (flutter#115390)
14812c9
This was referenced Feb 15, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harperl-lgtm @guidezpl