Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded comparison to double.nan #115547

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Remove unneeded comparison to double.nan #115547

merged 1 commit into from
Nov 18, 2022

Conversation

asashour
Copy link
Contributor

@asashour asashour commented Nov 17, 2022 •
edited
Loading

Fixes #115546

double.nan doesn't equal to anything, even itself. There is a new hint in Dart SDK for that, which needs Flutter code clearance first.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Nov 17, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Nov 17, 2022

test-exempt: fixing invariant check

goderbauer
goderbauer approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonahwilliams
jonahwilliams approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

justinmc
justinmc approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2022
@auto-submit auto-submit bot merged commit 24865ad into flutter:master Nov 18, 2022
@asashour asashour deleted the 115546_nan branch November 18, 2022 21:22
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 18, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Nov 18, 2022
@engine-flutter-autoroll
24865ad Remove unneeded comparison to double.nan (flutter/flutter#1…
a36ff7e 
…15547)
@christopherfujino
Copy link
Member

I'm guessing someone else applied this same diff? When this was merged it was an empty commit: 24865ad

@asashour
Copy link
Contributor Author

Yes, it was de4c0b1

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 19, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 19, 2022
@engine-flutter-autoroll
24865ad83 Remove unneeded comparison to double.nan (flutter/flutter…
59e53d9 
…#115547)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 19, 2022
@engine-flutter-autoroll
Roll Flutter from 18c87274cdc9 to 633d7ef046c8 (23 revisions) (#2827)
b1b48f3 
* 87cb150c2 InkResponse highlights can be updated (flutter/flutter#115635)

* 10c039b2f ca5b2f31c Roll Skia from d693b4b9fe5e to ab054a88d7c7 (1 revision) (flutter/engine#37743) (flutter/flutter#115654)

* 7fd3bb2ae Roll Plugins from a2fa4e9 to b2fe01b (6 revisions) (flutter/flutter#115656)

* 3a3a0db13 Disallow dispose during listener callback (flutter/flutter#114530)

* ca7832740 Fix `NavigationBar` ripple (flutter/flutter#115499)

* 459391708 [flutter_tools] Pin package:archive and manual roll (flutter/flutter#115662)

* 98077617b Tiny improvement of RouteSettings display (flutter/flutter#114481)

* 2cb2e84a3 Add more InkWell tests (flutter/flutter#115634)

* 24865ad83 Remove unneeded comparison to `double.nan` (flutter/flutter#115547)

* d2e6dfefa Fix formatting in BottomAppBar test (flutter/flutter#115520)

* 22e1ac762 b32c3a307 Roll Skia from ab054a88d7c7 to 345bceacd298 (3 revisions) (flutter/engine#37745) (flutter/flutter#115658)

* 01c1e8e58 Allows pushing page based route as pageless route (flutter/flutter#114362)

* 0e57147db nav drawer (flutter/flutter#115668)

* cf2c9f6ed Remove package:image dependency (flutter/flutter#115674)

* 46d868c52 Roll Flutter Engine from b32c3a307bb5 to 7a390f97c798 (14 revisions) (flutter/flutter#115672)

* 0fc4a3efa Revert "Remove package:image dependency (#115674)" (flutter/flutter#115680)

* c69fbf150 a77dfaff3 Remove `Linux Web Engine` from recipes CQ (flutter/engine#37758) (flutter/flutter#115675)

* c95b69354 f81ac3b19 Fix glyph sampling overlap (flutter/engine#37764) (flutter/flutter#115683)

* be0c3a799 cef11cb9a Roll Skia from 12f01bc5b57e to c53d8cf5b823 (4 revisions) (flutter/engine#37767) (flutter/flutter#115684)

* ae18d7b07 6da59402e Roll Skia from c53d8cf5b823 to 0c1fcbe97b1f (1 revision) (flutter/engine#37771) (flutter/flutter#115685)

* a17b4c369 91bc694eb Roll Fuchsia Mac SDK from tklUfTsSOVKk49tYq... to UcfQiA4PBOCs_7GEK... (flutter/engine#37773) (flutter/flutter#115686)

* 1bee3574b 2d5e0667e Roll Fuchsia Linux SDK from WdtwlLEce90PjFJ9z... to qc20R_3e8PoqMQWgw... (flutter/engine#37775) (flutter/flutter#115687)

* 633d7ef04 916fd798d Roll Skia from 0c1fcbe97b1f to ad354e712b96 (2 revisions) (flutter/engine#37776) (flutter/flutter#115689)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@asashour @shogohida
Remove unneeded comparison to double.nan (flutter#115547)
94164c6 
Fixes flutter#115546
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@asashour @gspencergoog
Remove unneeded comparison to double.nan (flutter#115547)
3043132 
Fixes flutter#115546
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

@justinmc justinmc justinmc approved these changes

@goderbauer goderbauer goderbauer approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary comparison with double.nan (2)
7 participants
@asashour @Hixie @christopherfujino @cbracken @justinmc @goderbauer @jonahwilliams