Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Packaging Builders to .ci.yaml #115569

Merged
merged 15 commits into from
Dec 5, 2022
Merged

Migrate Packaging Builders to .ci.yaml #115569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
af45ead
packaging builder initial config
sealesj Nov 17, 2022
8dde4c2
add release scheduler parameter
sealesj Nov 30, 2022
46247c2
Merge branch 'master' of https://github.com/sealesj/flutter into ci-y…
sealesj Nov 30, 2022
587d601
remove stables
sealesj Nov 30, 2022
fb4f356
add taskname + test owner
sealesj Nov 30, 2022
bf61b42
testowner test
sealesj Dec 1, 2022
6f383f3
comment structure
sealesj Dec 1, 2022
4309d34
test naming convention
sealesj Dec 1, 2022
7048a28
test adding tags
sealesj Dec 1, 2022
7a6b74f
add timeout
sealesj Dec 1, 2022
6b756ec
prune names
sealesj Dec 1, 2022
77dc9ce
Update testowners.
godofredoc Dec 2, 2022
e575d6d
Move packaging to shards section.
godofredoc Dec 2, 2022
dd5d8e1
Set packaging as shard.
godofredoc Dec 2, 2022
54a1c27
Use packaging V2
godofredoc Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 52 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4620,6 +4620,58 @@ targets:
["devicelab", "hostonly", "mac"]
task_name: flutter_tool_startup__macos

- name: Linux flutter_packaging_beta
recipe: packaging_v2/packaging_v2
timeout: 60
scheduler: release
bringup: true
enabled_branches:
- beta
properties:
task_name: flutter_packaging_beta
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these names be postfixed with OS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we do something with postfixes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, but the other names in the file are setup in that convention, e.g. line 4612

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaah, no, many of the values we are providing here are not needed but not sure if removing them will make TESTONWERS unhappy.

tags: >
["framework", "hostonly", "shard", "linux"]


- name: Mac flutter_packaging_beta
recipe: packaging_v2/packaging_v2
timeout: 60
scheduler: release
bringup: true
enabled_branches:
- beta
properties:
task_name: flutter_packaging_beta
tags: >
["framework", "hostonly", "shard", "mac"]


- name: Mac_arm64 flutter_packaging_beta
recipe: packaging_v2/packaging_v2
timeout: 60
scheduler: release
bringup: true
enabled_branches:
- beta
properties:
task_name: flutter_packaging_beta
tags: >
["framework", "hostonly", "shard", "mac"]


- name: Windows flutter_packaging_beta
recipe: packaging_v2/packaging_v2
timeout: 60
scheduler: release
bringup: true
enabled_branches:
- beta
properties:
task_name: flutter_packaging_beta
tags: >
["framework", "hostonly", "shard", "windows"]


# TODO(drewroengoogle): Remove this target when the release scheduler is
# confirmed to be working correctly and as intended.
# (https://github.com/flutter/flutter/issues/100806)
Expand Down
1 change: 1 addition & 0 deletions TESTOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,3 +301,4 @@
# skp_generator @Hixie
# test_ownership @keyonghan
# verify_binaries_codesigned @christopherfujino @flutter/releases
# flutter_packaging_beta @godofredoc @flutter/infra