Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Packaging Builders to .ci.yaml #115569

Merged
merged 15 commits into from
Dec 5, 2022
Merged

Migrate Packaging Builders to .ci.yaml #115569

merged 15 commits into from
Dec 5, 2022

Conversation

sealesj
Copy link
Contributor

@sealesj sealesj commented Nov 17, 2022

In order to avoid duplicated infra configurations in flutter and dart-internal due to BCID work on release artifacts, packaging builder configurations from here are getting moved to this .ci.yaml file.

Issue addressed: #100806

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@sealesj sealesj marked this pull request as draft November 17, 2022 16:48
@sealesj sealesj removed the request for review from keyonghan November 17, 2022 16:48
@goderbauer goderbauer added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team labels Nov 18, 2022
@sealesj sealesj marked this pull request as ready for review November 30, 2022 23:17
godofredoc
godofredoc reviewed Dec 1, 2022
View reviewed changes
.ci.yaml Outdated Show resolved Hide resolved
@sealesj sealesj added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 1, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 1, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 1, 2022

auto label is removed for flutter/flutter, pr: 115569, due to - The status or check suite Linux test_ownership has failed. Please fix the issues identified (or deflake) before re-applying this label.

@godofredoc
Copy link
Contributor

auto label is removed for flutter/flutter, pr: 115569, due to - The status or check suite Linux test_ownership has failed. Please fix the issues identified (or deflake) before re-applying this label.

Seems like we also need to update TESTOWNERS

@sealesj
Copy link
Contributor Author

sealesj commented Dec 1, 2022

auto label is removed for flutter/flutter, pr: 115569, due to - The status or check suite Linux test_ownership has failed. Please fix the issues identified (or deflake) before re-applying this label.

Seems like we also need to update TESTOWNERS

Yes I'm working to figure out what the problem is. I added task_name and tags for each target but am still seeing that the tests are parsed as none for the owner. I'm looking into the script that is used to parse the yaml now to see what is missing

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 5, 2022
@engine-flutter-autoroll
30fc993 Migrate Packaging Builders to .ci.yaml (flutter/flutter#115569)
e1176ce
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2022
@engine-flutter-autoroll
30fc993ca Migrate Packaging Builders to .ci.yaml (flutter/flutter#115569
f73d16e 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2022
@engine-flutter-autoroll
30fc993ca Migrate Packaging Builders to .ci.yaml (flutter/flutter#115569
c361532 
)
mit-mit pushed a commit to mit-mit/flutter that referenced this pull request Dec 6, 2022
@sealesj @godofredoc @mit-mit
Migrate Packaging Builders to .ci.yaml (flutter#115569)
143468d 
* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@sealesj @godofredoc @shogohida
Migrate Packaging Builders to .ci.yaml (flutter#115569)
862dc08 
* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>
godofredoc added a commit to godofredoc/flutter that referenced this pull request Dec 14, 2022
@sealesj @godofredoc
Migrate Packaging Builders to .ci.yaml (flutter#115569)
2105f68 
* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>
XilaiZhang pushed a commit that referenced this pull request Dec 14, 2022
@godofredoc @sealesj
CP: ci.yaml changes for packaging (#117038)
199c4bf 
* Migrate Packaging Builders to .ci.yaml (#115569)

* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>

* use deploy suffix (#116533)

* Update docs_deploy builder with the real name. (#116631)

This is removing the temporary comments and simplifying the name.

Bug: #115489

* Add Remaining Packaging Builders (#116683)

* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation

* Several fixes to packaging builders. (#116800)

It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43

* Pass drone_dimensions as part of the main target. (#116812)

* Pass drone_dimensions as part of the main target.

Drone dimensions were passed as properties when the sharding utility is
expecting them in the target.

Bug: #116794

* Use dimensions instead of drone_dimensions.

* Use a map format.

Co-authored-by: sealesj <103135467+sealesj@users.noreply.github.com>
godofredoc added a commit to godofredoc/flutter that referenced this pull request Dec 15, 2022
@sealesj @godofredoc
Migrate Packaging Builders to .ci.yaml (flutter#115569)
9143082 
* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>
godofredoc added a commit that referenced this pull request Dec 15, 2022
@godofredoc @sealesj
CP: ci.yaml changes for packaging (#117133)
135454a 
* Migrate Packaging Builders to .ci.yaml (#115569)

* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>

* Revert deleted line.

* use deploy suffix (#116533)

* Update docs_deploy builder with the real name. (#116631)

This is removing the temporary comments and simplifying the name.

Bug: #115489

* Add Remaining Packaging Builders (#116683)

* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation

* Several fixes to packaging builders. (#116800)

It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43

* Pass drone_dimensions as part of the main target. (#116812)

* Pass drone_dimensions as part of the main target.

Drone dimensions were passed as properties when the sharding utility is
expecting them in the target.

Bug: #116794

* Use dimensions instead of drone_dimensions.

* Use a map format.

Co-authored-by: sealesj <103135467+sealesj@users.noreply.github.com>
godofredoc added a commit to godofredoc/flutter that referenced this pull request Dec 16, 2022
@sealesj @godofredoc
Migrate Packaging Builders to .ci.yaml (flutter#115569)
79d428b 
* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>
godofredoc added a commit that referenced this pull request Dec 16, 2022
@godofredoc @sealesj
CPs: ci.yaml changes for packaging (#117196)
9623d32 
* Migrate Packaging Builders to .ci.yaml (#115569)

* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>

* use deploy suffix (#116533)

* Update docs_deploy builder with the real name. (#116631)

This is removing the temporary comments and simplifying the name.

Bug: #115489

* Add Remaining Packaging Builders (#116683)

* add stable packaging builders

* update testowners

* consolidate and use enabled_branches

* update to reflect the consolidation

* Several fixes to packaging builders. (#116800)

It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43

* Pass drone_dimensions as part of the main target. (#116812)

* Pass drone_dimensions as part of the main target.

Drone dimensions were passed as properties when the sharding utility is
expecting them in the target.

Bug: #116794

* Use dimensions instead of drone_dimensions.

* Use a map format.

* Several fixes to packaging builders. (#116800)

It includes the following changes:

* Adds main as the enabled branches.
* Adds docs_beta and docs_stable to pass the expected gcp project.
* Adds dimensions to packaging arm64 to ensure that it runs on arm64
  bot.

Bug: https://github.com/orgs/flutter/projects/43

* Pass dimension explicitly to mac x64 packaging. (#117172)

Without passing this dimension there is a chance that the build will
run on a arm64 machine.

Co-authored-by: sealesj <103135467+sealesj@users.noreply.github.com>
@ScreamingSyntax ScreamingSyntax mentioned this pull request Dec 16, 2022
Closed
8 tasks
@mHelenaR mHelenaR mentioned this pull request Dec 20, 2022
Closed
8 tasks
@crimdev5 crimdev5 mentioned this pull request Dec 23, 2022
Closed
8 tasks
@malikabdullahnaazar malikabdullahnaazar mentioned this pull request Dec 25, 2022
Closed
8 tasks
This was referenced Dec 30, 2022
Closed
Closed
@Ramzi-dr Ramzi-dr mentioned this pull request Jan 8, 2023
Closed
8 tasks
@emresezer-blog emresezer-blog mentioned this pull request Jan 11, 2023
Closed
8 tasks
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@sealesj @godofredoc @gspencergoog
Migrate Packaging Builders to .ci.yaml (flutter#115569)
744ad31 
* packaging builder initial config

* add release scheduler parameter

* remove stables

* add taskname + test owner

* testowner test

* comment structure

* test naming convention

* test adding tags

* add timeout

* prune names

* Update testowners.

* Move packaging to shards section.

* Set packaging as shard.

* Use packaging V2

Co-authored-by: godofredoc <godofredoc@google.com>
This was referenced Jan 21, 2023
Closed
Closed
@IsaTunahan IsaTunahan mentioned this pull request Jan 24, 2023
Closed
8 tasks
@ridwanyinusa ridwanyinusa mentioned this pull request Jan 29, 2023
Closed
8 tasks
@talebmohammedsaid talebmohammedsaid mentioned this pull request Jan 30, 2023
Closed
8 tasks
@memodlike memodlike mentioned this pull request Feb 5, 2023
Closed
8 tasks
@Dragan1992 Dragan1992 mentioned this pull request Feb 11, 2023
Closed
8 tasks
@Vinubrice Vinubrice mentioned this pull request Mar 2, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godofredoc godofredoc godofredoc approved these changes

@yusuf-goog yusuf-goog yusuf-goog left review comments

@drewroengoogle drewroengoogle Awaiting requested review from drewroengoogle

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sealesj @godofredoc @yusuf-goog @goderbauer