Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter roll] Revert both #117338 and #117547 #117557

Merged
merged 2 commits into from
Dec 23, 2022
Merged

[flutter roll] Revert both #117338 and #117547 #117557

merged 2 commits into from
Dec 23, 2022

Conversation

XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Dec 22, 2022 •
edited
Loading

Reverts #117338.

tooltip related tests are failing in https://b.corp.google.com/issues/263351045
revert two PRs based on #117558 (comment)

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Dec 22, 2022
@chunhtai
Copy link
Contributor

while most tests are expected, this seems to need a g3 fix https://fusion2.corp.google.com/invocations/2756fe61-3b93-4898-a5d4-7badfde614cb/targets/%2F%2Fassistant%2Fgallium%2Fdragonglass%2Fsystem%2Fquick_settings:quick_settings_gallium_tests_test_quick_settings_gallium_tests_test_quick_settings_integration_test_test_entry.host/tests

Can you also revert this as part of this revert? bd482eb
otherwise the test will start failing

@XilaiZhang
Copy link
Contributor Author

Ahh right Jenn also mentioned bd482eb . Just to confirm our approach, would the plan be to revert both PRs, or keep them and submit a g3fix for the assistant failures? (we would probably need help to create such a g3fix)

@chunhtai
Copy link
Contributor

If this is urgent, feel free to revert it. If not I can create a g3fix to fix the issue

@XilaiZhang
Copy link
Contributor Author

sounds good, thank you! it's likely that we will hit it in the next roll, i will put up reverts then.

@XilaiZhang XilaiZhang mentioned this pull request Dec 22, 2022
Closed
chunhtai
chunhtai approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang XilaiZhang changed the title [flutter roll] Revert "Exposed tooltip longPress action when available" [flutter roll] Revert both #117338 and #117547 Dec 23, 2022
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Dec 23, 2022
@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 23, 2022
@auto-submit auto-submit bot merged commit 4b4783d into master Dec 23, 2022
@auto-submit auto-submit bot deleted the revert-117338-masterCopy branch December 23, 2022 22:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 24, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 24, 2022
@engine-flutter-autoroll
4b4783d [flutter roll] Revert both #117338 and #117547 (flutter/flutt…
e5f2d8d 
…er#117557)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Dec 26, 2022
@engine-flutter-autoroll
Roll Flutter from a45a2f3 to e766ad0 (7 revisions) (#6880)
3eba2bf 
* dec6b27 94a54bf Roll Flutter from dbc9306 to 9fb1ae8 (106 revisions) (#6876) (flutter/flutter#117598)

* b3c321f 5bae18365 Reland "[web] Render in custom target (#37738)" (flutter/engine#38477) (flutter/flutter#117600)

* 4b4783d [flutter roll] Revert both #117338 and #117547 (flutter/flutter#117557)

* 102d039 77db88672 Roll Fuchsia Mac SDK from 9w7QDlttR9f7Gu7U6... to 9qjOKSNAN2EiCgQxC... (flutter/engine#38487) (flutter/flutter#117603)

* 393e156 e3edfadbd Roll Dart SDK from 442614a6c1bb to 6340d946feac (1 revision) (flutter/engine#38489) (flutter/flutter#117604)

* bc7d275 1d5c44966 Roll Skia from a8b7ce3b6391 to 38d9c68d35c6 (2 revisions) (flutter/engine#38492) (flutter/flutter#117617)

* e766ad0 6bee6d768 Roll Fuchsia Mac SDK from 9qjOKSNAN2EiCgQxC... to hGNNd-oOWFLY86Tnl... (flutter/engine#38493) (flutter/flutter#117618)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 27, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 27, 2022
@engine-flutter-autoroll
4b4783d1f [flutter roll] Revert both #117338 and #117547 (flutter/flu…
d7da60b 
…tter#117557)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 27, 2022
@engine-flutter-autoroll
Roll Flutter from a45a2f311990 to 894ea20f11ad (28 revisions) (#3006)
0761453 
* dec6b2773 94a54bf Roll Flutter from dbc9306380d8 to 9fb1ae839e0a (106 revisions) (flutter/plugins#6876) (flutter/flutter#117598)

* b3c321f1d 5bae18365 Reland "[web] Render in custom target (#37738)" (flutter/engine#38477) (flutter/flutter#117600)

* 4b4783d1f [flutter roll] Revert both #117338 and #117547 (flutter/flutter#117557)

* 102d03936 77db88672 Roll Fuchsia Mac SDK from 9w7QDlttR9f7Gu7U6... to 9qjOKSNAN2EiCgQxC... (flutter/engine#38487) (flutter/flutter#117603)

* 393e156c2 e3edfadbd Roll Dart SDK from 442614a6c1bb to 6340d946feac (1 revision) (flutter/engine#38489) (flutter/flutter#117604)

* bc7d2755c 1d5c44966 Roll Skia from a8b7ce3b6391 to 38d9c68d35c6 (2 revisions) (flutter/engine#38492) (flutter/flutter#117617)

* e766ad07e 6bee6d768 Roll Fuchsia Mac SDK from 9qjOKSNAN2EiCgQxC... to hGNNd-oOWFLY86Tnl... (flutter/engine#38493) (flutter/flutter#117618)

* 484858b79 00ce1fd6d add virtual destructor to new virtual Culler class (flutter/engine#38494) (flutter/flutter#117624)

* d674a4642 b2968296a Roll Fuchsia Mac SDK from hGNNd-oOWFLY86Tnl... to kV1stXDqE4asMxgjK... (flutter/engine#38495) (flutter/flutter#117626)

* 239f80ed6 3ae55014f Roll Fuchsia Mac SDK from kV1stXDqE4asMxgjK... to 90MsGucOMFZ_grNUC... (flutter/engine#38498) (flutter/flutter#117633)

* def09b4e9 b61200484 Roll Fuchsia Mac SDK from 90MsGucOMFZ_grNUC... to QOdpfMkM_LcPon_zm... (flutter/engine#38499) (flutter/flutter#117646)

* a09faa11b Roll Flutter Engine from b61200484d28 to da181dfbfb27 (4 revisions) (flutter/flutter#117651)

* ae292cc4e Roll Plugins from 94a54bf to 3eba2bf (4 revisions) (flutter/flutter#117653)

* fe3e93e19 eb8e52c59 Roll Fuchsia Mac SDK from QOdpfMkM_LcPon_zm... to ozbhYRHpQKfnPwJdh... (flutter/engine#38505) (flutter/flutter#117658)

* 41d191187 becee173e Roll Skia from 7442335dce20 to eeec7a127312 (1 revision) (flutter/engine#38506) (flutter/flutter#117662)

* d15db1518 84043c672 Roll Skia from eeec7a127312 to 7fe57dac0702 (1 revision) (flutter/engine#38508) (flutter/flutter#117665)

* 4cce45f60 06b2eff9d Roll Dart SDK from 6340d946feac to 494e4d4bf58d (1 revision) (flutter/engine#38509) (flutter/flutter#117667)

* d94768749 893e48763 Roll Skia from 7fe57dac0702 to 8099f53e7a43 (1 revision) (flutter/engine#38510) (flutter/flutter#117668)

* a7cc010a9 dbb5a5739 Roll Fuchsia Mac SDK from ozbhYRHpQKfnPwJdh... to HHADjSDGmZSkODScd... (flutter/engine#38511) (flutter/flutter#117669)

* c3f0c1308 dcde1faa8 Roll Skia from 8099f53e7a43 to 789552988917 (1 revision) (flutter/engine#38512) (flutter/flutter#117672)

* 91c3f80c8 790604a09 Roll Skia from 789552988917 to 6abfcf819da1 (2 revisions) (flutter/engine#38513) (flutter/flutter#117674)

* bf2701d2a 9d69a91bb Roll Dart SDK from 494e4d4bf58d to 742e1dc3e17f (1 revision) (flutter/engine#38514) (flutter/flutter#117681)

* 00e9cf1d6 e11cb24 Roll Flutter from e766ad07e600 to ae292cc4e5e4 (6 revisions) (flutter/plugins#6885) (flutter/flutter#117682)

* 5538fa136 c54228b5c Roll Skia from 6abfcf819da1 to 4f64211cd741 (1 revision) (flutter/engine#38515) (flutter/flutter#117684)

* 1c273fbe8 27ebaec7d Roll Skia from 4f64211cd741 to 3939e68c4b4d (2 revisions) (flutter/engine#38517) (flutter/flutter#117686)

* f11fbbafc [macOS] Fix the `run_debug_test_macos` on arm64 (flutter/flutter#117250)

* d7abc0bbd a53f1e983 Roll Skia from 3939e68c4b4d to 2b6d44eb650b (2 revisions) (flutter/engine#38519) (flutter/flutter#117689)

* 894ea20f1 e049bbf41 Roll Fuchsia Mac SDK from HHADjSDGmZSkODScd... to c1-ICa-ToxzhYLG7F... (flutter/engine#38520) (flutter/flutter#117690)
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@XilaiZhang @loic-sharma
[flutter roll] Revert both flutter#117338 and flutter#117547 (flutter…
41331ee 
…#117557)

* Revert "Exposed tooltip longPress action when available (flutter#117338)"

This reverts commit 38e3930.

* Revert "fixes android_semantics_integration_test to expect long press for tootip"
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@XilaiZhang @gspencergoog
[flutter roll] Revert both flutter#117338 and flutter#117547 (flutter…
765284f 
…#117557)

* Revert "Exposed tooltip longPress action when available (flutter#117338)"

This reverts commit 38e3930.

* Revert "fixes android_semantics_integration_test to expect long press for tootip"
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from a45a2f3 to e766ad0 (7 revisions) (flutter#6880)
a719494 
* dec6b27 94a54bf Roll Flutter from dbc9306 to 9fb1ae8 (106 revisions) (flutter#6876) (flutter/flutter#117598)

* b3c321f 5bae18365 Reland "[web] Render in custom target (#37738)" (flutter/engine#38477) (flutter/flutter#117600)

* 4b4783d [flutter roll] Revert both #117338 and #117547 (flutter/flutter#117557)

* 102d039 77db88672 Roll Fuchsia Mac SDK from 9w7QDlttR9f7Gu7U6... to 9qjOKSNAN2EiCgQxC... (flutter/engine#38487) (flutter/flutter#117603)

* 393e156 e3edfadbd Roll Dart SDK from 442614a6c1bb to 6340d946feac (1 revision) (flutter/engine#38489) (flutter/flutter#117604)

* bc7d275 1d5c44966 Roll Skia from a8b7ce3b6391 to 38d9c68d35c6 (2 revisions) (flutter/engine#38492) (flutter/flutter#117617)

* e766ad0 6bee6d768 Roll Fuchsia Mac SDK from 9qjOKSNAN2EiCgQxC... to hGNNd-oOWFLY86Tnl... (flutter/engine#38493) (flutter/flutter#117618)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

@godofredoc godofredoc Awaiting requested review from godofredoc

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XilaiZhang @chunhtai