-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Fix the run_debug_test_macos
on arm64
#117250
Conversation
This reverts commit c83dc28.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally forgot about #92065 and #91830. Removing the sandbox in these tests makes me sad, we could miss subtle issues like trying to access files outside the sandbox. As I said in #92065 (review) though
Not sure what else to try, I'd rather have this test run than worry about the sandbox.
* dec6b2773 94a54bf Roll Flutter from dbc9306380d8 to 9fb1ae839e0a (106 revisions) (flutter/plugins#6876) (flutter/flutter#117598) * b3c321f1d 5bae18365 Reland "[web] Render in custom target (#37738)" (flutter/engine#38477) (flutter/flutter#117600) * 4b4783d1f [flutter roll] Revert both #117338 and #117547 (flutter/flutter#117557) * 102d03936 77db88672 Roll Fuchsia Mac SDK from 9w7QDlttR9f7Gu7U6... to 9qjOKSNAN2EiCgQxC... (flutter/engine#38487) (flutter/flutter#117603) * 393e156c2 e3edfadbd Roll Dart SDK from 442614a6c1bb to 6340d946feac (1 revision) (flutter/engine#38489) (flutter/flutter#117604) * bc7d2755c 1d5c44966 Roll Skia from a8b7ce3b6391 to 38d9c68d35c6 (2 revisions) (flutter/engine#38492) (flutter/flutter#117617) * e766ad07e 6bee6d768 Roll Fuchsia Mac SDK from 9qjOKSNAN2EiCgQxC... to hGNNd-oOWFLY86Tnl... (flutter/engine#38493) (flutter/flutter#117618) * 484858b79 00ce1fd6d add virtual destructor to new virtual Culler class (flutter/engine#38494) (flutter/flutter#117624) * d674a4642 b2968296a Roll Fuchsia Mac SDK from hGNNd-oOWFLY86Tnl... to kV1stXDqE4asMxgjK... (flutter/engine#38495) (flutter/flutter#117626) * 239f80ed6 3ae55014f Roll Fuchsia Mac SDK from kV1stXDqE4asMxgjK... to 90MsGucOMFZ_grNUC... (flutter/engine#38498) (flutter/flutter#117633) * def09b4e9 b61200484 Roll Fuchsia Mac SDK from 90MsGucOMFZ_grNUC... to QOdpfMkM_LcPon_zm... (flutter/engine#38499) (flutter/flutter#117646) * a09faa11b Roll Flutter Engine from b61200484d28 to da181dfbfb27 (4 revisions) (flutter/flutter#117651) * ae292cc4e Roll Plugins from 94a54bf to 3eba2bf (4 revisions) (flutter/flutter#117653) * fe3e93e19 eb8e52c59 Roll Fuchsia Mac SDK from QOdpfMkM_LcPon_zm... to ozbhYRHpQKfnPwJdh... (flutter/engine#38505) (flutter/flutter#117658) * 41d191187 becee173e Roll Skia from 7442335dce20 to eeec7a127312 (1 revision) (flutter/engine#38506) (flutter/flutter#117662) * d15db1518 84043c672 Roll Skia from eeec7a127312 to 7fe57dac0702 (1 revision) (flutter/engine#38508) (flutter/flutter#117665) * 4cce45f60 06b2eff9d Roll Dart SDK from 6340d946feac to 494e4d4bf58d (1 revision) (flutter/engine#38509) (flutter/flutter#117667) * d94768749 893e48763 Roll Skia from 7fe57dac0702 to 8099f53e7a43 (1 revision) (flutter/engine#38510) (flutter/flutter#117668) * a7cc010a9 dbb5a5739 Roll Fuchsia Mac SDK from ozbhYRHpQKfnPwJdh... to HHADjSDGmZSkODScd... (flutter/engine#38511) (flutter/flutter#117669) * c3f0c1308 dcde1faa8 Roll Skia from 8099f53e7a43 to 789552988917 (1 revision) (flutter/engine#38512) (flutter/flutter#117672) * 91c3f80c8 790604a09 Roll Skia from 789552988917 to 6abfcf819da1 (2 revisions) (flutter/engine#38513) (flutter/flutter#117674) * bf2701d2a 9d69a91bb Roll Dart SDK from 494e4d4bf58d to 742e1dc3e17f (1 revision) (flutter/engine#38514) (flutter/flutter#117681) * 00e9cf1d6 e11cb24 Roll Flutter from e766ad07e600 to ae292cc4e5e4 (6 revisions) (flutter/plugins#6885) (flutter/flutter#117682) * 5538fa136 c54228b5c Roll Skia from 6abfcf819da1 to 4f64211cd741 (1 revision) (flutter/engine#38515) (flutter/flutter#117684) * 1c273fbe8 27ebaec7d Roll Skia from 4f64211cd741 to 3939e68c4b4d (2 revisions) (flutter/engine#38517) (flutter/flutter#117686) * f11fbbafc [macOS] Fix the `run_debug_test_macos` on arm64 (flutter/flutter#117250) * d7abc0bbd a53f1e983 Roll Skia from 3939e68c4b4d to 2b6d44eb650b (2 revisions) (flutter/engine#38519) (flutter/flutter#117689) * 894ea20f1 e049bbf41 Roll Fuchsia Mac SDK from HHADjSDGmZSkODScd... to c1-ICa-ToxzhYLG7F... (flutter/engine#38520) (flutter/flutter#117690)
* fe3e93e eb8e52c59 Roll Fuchsia Mac SDK from QOdpfMkM_LcPon_zm... to ozbhYRHpQKfnPwJdh... (flutter/engine#38505) (flutter/flutter#117658) * 41d1911 becee173e Roll Skia from 7442335dce20 to eeec7a127312 (1 revision) (flutter/engine#38506) (flutter/flutter#117662) * d15db15 84043c672 Roll Skia from eeec7a127312 to 7fe57dac0702 (1 revision) (flutter/engine#38508) (flutter/flutter#117665) * 4cce45f 06b2eff9d Roll Dart SDK from 6340d946feac to 494e4d4bf58d (1 revision) (flutter/engine#38509) (flutter/flutter#117667) * d947687 893e48763 Roll Skia from 7fe57dac0702 to 8099f53e7a43 (1 revision) (flutter/engine#38510) (flutter/flutter#117668) * a7cc010 dbb5a5739 Roll Fuchsia Mac SDK from ozbhYRHpQKfnPwJdh... to HHADjSDGmZSkODScd... (flutter/engine#38511) (flutter/flutter#117669) * c3f0c13 dcde1faa8 Roll Skia from 8099f53e7a43 to 789552988917 (1 revision) (flutter/engine#38512) (flutter/flutter#117672) * 91c3f80 790604a09 Roll Skia from 789552988917 to 6abfcf819da1 (2 revisions) (flutter/engine#38513) (flutter/flutter#117674) * bf2701d 9d69a91bb Roll Dart SDK from 494e4d4bf58d to 742e1dc3e17f (1 revision) (flutter/engine#38514) (flutter/flutter#117681) * 00e9cf1 e11cb24 Roll Flutter from e766ad0 to ae292cc (6 revisions) (#6885) (flutter/flutter#117682) * 5538fa1 c54228b5c Roll Skia from 6abfcf819da1 to 4f64211cd741 (1 revision) (flutter/engine#38515) (flutter/flutter#117684) * 1c273fb 27ebaec7d Roll Skia from 4f64211cd741 to 3939e68c4b4d (2 revisions) (flutter/engine#38517) (flutter/flutter#117686) * f11fbba [macOS] Fix the `run_debug_test_macos` on arm64 (flutter/flutter#117250) * d7abc0b a53f1e983 Roll Skia from 3939e68c4b4d to 2b6d44eb650b (2 revisions) (flutter/engine#38519) (flutter/flutter#117689) * 894ea20 e049bbf41 Roll Fuchsia Mac SDK from HHADjSDGmZSkODScd... to c1-ICa-ToxzhYLG7F... (flutter/engine#38520) (flutter/flutter#117690) * c956121 Revert "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117647) * 0dc9739 6e6a6538f Roll Skia from 2b6d44eb650b to 34708fefacd0 (1 revision) (flutter/engine#38521) (flutter/flutter#117694) * 95a184d 10ce8cd38 [fuchsia] Debugging code for crash. (flutter/engine#38518) (flutter/flutter#117697) * a89d135 afe49825e Roll Skia from 34708fefacd0 to 1a93cfdae2fd (1 revision) (flutter/engine#38522) (flutter/flutter#117699) * 0ddfa72 6128780f1 Roll Dart SDK from 742e1dc3e17f to 68d8b0f58be7 (1 revision) (flutter/engine#38523) (flutter/flutter#117701) * 4e08ebb 8294e2693 Roll Skia from 1a93cfdae2fd to c5c0387b3399 (2 revisions) (flutter/engine#38524) (flutter/flutter#117702) * d108c91 bfecc4b18 Roll Dart SDK from 68d8b0f58be7 to 5a173adb22ed (1 revision) (flutter/engine#38525) (flutter/flutter#117707) * 2864acc 2d431852d Roll Skia from c5c0387b3399 to 656bb22387ac (1 revision) (flutter/engine#38526) (flutter/flutter#117711) * 6f8d176 74ef2cbc8 Roll Fuchsia Linux SDK from iQT5jpUhipvetxSiH... to yX7ot9Un0bpYQ-XX7... (flutter/engine#38527) (flutter/flutter#117713) * eda7aab dc6670f7b Roll Dart SDK from 5a173adb22ed to 2541cf36607f (1 revision) (flutter/engine#38528) (flutter/flutter#117715) * 2223235 8d4546d5b Roll Skia from 656bb22387ac to 913271ba5cbb (2 revisions) (flutter/engine#38529) (flutter/flutter#117719) * f24df97 3bb936567 Roll Skia from 913271ba5cbb to f78bb848bbe1 (2 revisions) (flutter/engine#38531) (flutter/flutter#117721) * 17482fd 9e63c1ae1 Roll Fuchsia Mac SDK from c1-ICa-ToxzhYLG7F... to jV7nfgH1Tb3Lw0w_S... (flutter/engine#38532) (flutter/flutter#117731)
* [macOS] Fix the run_debug_test_macos on arm64 * DO NOT MERGE - Test in presubmit * Revert "DO NOT MERGE - Test in presubmit" This reverts commit c83dc28.
* [macOS] Fix the run_debug_test_macos on arm64 * DO NOT MERGE - Test in presubmit * Revert "DO NOT MERGE - Test in presubmit" This reverts commit c83dc28.
* fe3e93e eb8e52c59 Roll Fuchsia Mac SDK from QOdpfMkM_LcPon_zm... to ozbhYRHpQKfnPwJdh... (flutter/engine#38505) (flutter/flutter#117658) * 41d1911 becee173e Roll Skia from 7442335dce20 to eeec7a127312 (1 revision) (flutter/engine#38506) (flutter/flutter#117662) * d15db15 84043c672 Roll Skia from eeec7a127312 to 7fe57dac0702 (1 revision) (flutter/engine#38508) (flutter/flutter#117665) * 4cce45f 06b2eff9d Roll Dart SDK from 6340d946feac to 494e4d4bf58d (1 revision) (flutter/engine#38509) (flutter/flutter#117667) * d947687 893e48763 Roll Skia from 7fe57dac0702 to 8099f53e7a43 (1 revision) (flutter/engine#38510) (flutter/flutter#117668) * a7cc010 dbb5a5739 Roll Fuchsia Mac SDK from ozbhYRHpQKfnPwJdh... to HHADjSDGmZSkODScd... (flutter/engine#38511) (flutter/flutter#117669) * c3f0c13 dcde1faa8 Roll Skia from 8099f53e7a43 to 789552988917 (1 revision) (flutter/engine#38512) (flutter/flutter#117672) * 91c3f80 790604a09 Roll Skia from 789552988917 to 6abfcf819da1 (2 revisions) (flutter/engine#38513) (flutter/flutter#117674) * bf2701d 9d69a91bb Roll Dart SDK from 494e4d4bf58d to 742e1dc3e17f (1 revision) (flutter/engine#38514) (flutter/flutter#117681) * 00e9cf1 e11cb24 Roll Flutter from e766ad0 to ae292cc (6 revisions) (flutter#6885) (flutter/flutter#117682) * 5538fa1 c54228b5c Roll Skia from 6abfcf819da1 to 4f64211cd741 (1 revision) (flutter/engine#38515) (flutter/flutter#117684) * 1c273fb 27ebaec7d Roll Skia from 4f64211cd741 to 3939e68c4b4d (2 revisions) (flutter/engine#38517) (flutter/flutter#117686) * f11fbba [macOS] Fix the `run_debug_test_macos` on arm64 (flutter/flutter#117250) * d7abc0b a53f1e983 Roll Skia from 3939e68c4b4d to 2b6d44eb650b (2 revisions) (flutter/engine#38519) (flutter/flutter#117689) * 894ea20 e049bbf41 Roll Fuchsia Mac SDK from HHADjSDGmZSkODScd... to c1-ICa-ToxzhYLG7F... (flutter/engine#38520) (flutter/flutter#117690) * c956121 Revert "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117647) * 0dc9739 6e6a6538f Roll Skia from 2b6d44eb650b to 34708fefacd0 (1 revision) (flutter/engine#38521) (flutter/flutter#117694) * 95a184d 10ce8cd38 [fuchsia] Debugging code for crash. (flutter/engine#38518) (flutter/flutter#117697) * a89d135 afe49825e Roll Skia from 34708fefacd0 to 1a93cfdae2fd (1 revision) (flutter/engine#38522) (flutter/flutter#117699) * 0ddfa72 6128780f1 Roll Dart SDK from 742e1dc3e17f to 68d8b0f58be7 (1 revision) (flutter/engine#38523) (flutter/flutter#117701) * 4e08ebb 8294e2693 Roll Skia from 1a93cfdae2fd to c5c0387b3399 (2 revisions) (flutter/engine#38524) (flutter/flutter#117702) * d108c91 bfecc4b18 Roll Dart SDK from 68d8b0f58be7 to 5a173adb22ed (1 revision) (flutter/engine#38525) (flutter/flutter#117707) * 2864acc 2d431852d Roll Skia from c5c0387b3399 to 656bb22387ac (1 revision) (flutter/engine#38526) (flutter/flutter#117711) * 6f8d176 74ef2cbc8 Roll Fuchsia Linux SDK from iQT5jpUhipvetxSiH... to yX7ot9Un0bpYQ-XX7... (flutter/engine#38527) (flutter/flutter#117713) * eda7aab dc6670f7b Roll Dart SDK from 5a173adb22ed to 2541cf36607f (1 revision) (flutter/engine#38528) (flutter/flutter#117715) * 2223235 8d4546d5b Roll Skia from 656bb22387ac to 913271ba5cbb (2 revisions) (flutter/engine#38529) (flutter/flutter#117719) * f24df97 3bb936567 Roll Skia from 913271ba5cbb to f78bb848bbe1 (2 revisions) (flutter/engine#38531) (flutter/flutter#117721) * 17482fd 9e63c1ae1 Roll Fuchsia Mac SDK from c1-ICa-ToxzhYLG7F... to jV7nfgH1Tb3Lw0w_S... (flutter/engine#38532) (flutter/flutter#117731)
The
run_debug_test_macos
fails on arm64 on the device lab. This is due to the sandbox entitlement which prevents the mac application from running over SSH. As a result, the runner app crashes immediately at start up with signalSIGTRAP
.The same issue previously affected the
hot_mode_dev_cycle_macos_target__benchmark
test. See #85654 and #92065Presubmit test run: https://github.com/flutter/flutter/pull/117250/checks?check_run_id=10152518763, https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64_ios%20run_debug_test_macos/23/overview
Fixes #117000
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.