Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter roll] Revert "Remove single-view assumption from ScrollPhysics" #117647

Merged
merged 1 commit into from Dec 27, 2022
Merged

[flutter roll] Revert "Remove single-view assumption from ScrollPhysics" #117647

merged 1 commit into from Dec 27, 2022

Conversation

XilaiZhang
Copy link
Contributor

Reverts #117503, context: https://b.corp.google.com/issues/263555070.

umm I was looking at a g3 fix for the breakages but I am not sure what would be the default value to use for devicePixelRatio. Looks like Michael will come back in January. Putting up a revert for now.

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Dec 26, 2022
@whesse
Copy link
Contributor

whesse commented Dec 27, 2022

This reverted CL also breaks the analysis of Flutter gallery, since it uses the deprecated ScrollPhysics.tolerance method, and the test fails if gallery has any lint failures.

The failures can be seen at https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-analyze/18257/overview

Could the new method be added, so that gallery and others could migrate to it, and then the old method be marked deprecated in a later commit?

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 27, 2022
@auto-submit auto-submit bot merged commit c956121 into master Dec 27, 2022
@auto-submit auto-submit bot deleted the revert-117503-scrollphysicsNoWindow branch December 27, 2022 21:22
This was referenced Dec 28, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 28, 2022
@engine-flutter-autoroll
c956121 Revert "Remove single-view assumption from ScrollPhysics (#11…
ad4be11 
…7503)" (flutter/flutter#117647)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 28, 2022
@engine-flutter-autoroll
c956121ac Revert "Remove single-view assumption from ScrollPhysics (#…
486aa88 
…117503)" (flutter/flutter#117647)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 28, 2022
@engine-flutter-autoroll
Roll Flutter from 894ea20f11ad to 17482fd425ee (13 revisions) (#3008)
b3c7e14 
* c956121ac Revert "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117647)

* 0dc973955 6e6a6538f Roll Skia from 2b6d44eb650b to 34708fefacd0 (1 revision) (flutter/engine#38521) (flutter/flutter#117694)

* 95a184dcf 10ce8cd38 [fuchsia] Debugging code for crash. (flutter/engine#38518) (flutter/flutter#117697)

* a89d135f4 afe49825e Roll Skia from 34708fefacd0 to 1a93cfdae2fd (1 revision) (flutter/engine#38522) (flutter/flutter#117699)

* 0ddfa72f0 6128780f1 Roll Dart SDK from 742e1dc3e17f to 68d8b0f58be7 (1 revision) (flutter/engine#38523) (flutter/flutter#117701)

* 4e08ebb2b 8294e2693 Roll Skia from 1a93cfdae2fd to c5c0387b3399 (2 revisions) (flutter/engine#38524) (flutter/flutter#117702)

* d108c912c bfecc4b18 Roll Dart SDK from 68d8b0f58be7 to 5a173adb22ed (1 revision) (flutter/engine#38525) (flutter/flutter#117707)

* 2864acc82 2d431852d Roll Skia from c5c0387b3399 to 656bb22387ac (1 revision) (flutter/engine#38526) (flutter/flutter#117711)

* 6f8d17609 74ef2cbc8 Roll Fuchsia Linux SDK from iQT5jpUhipvetxSiH... to yX7ot9Un0bpYQ-XX7... (flutter/engine#38527) (flutter/flutter#117713)

* eda7aab33 dc6670f7b Roll Dart SDK from 5a173adb22ed to 2541cf36607f (1 revision) (flutter/engine#38528) (flutter/flutter#117715)

* 222323589 8d4546d5b Roll Skia from 656bb22387ac to 913271ba5cbb (2 revisions) (flutter/engine#38529) (flutter/flutter#117719)

* f24df972b 3bb936567 Roll Skia from 913271ba5cbb to f78bb848bbe1 (2 revisions) (flutter/engine#38531) (flutter/flutter#117721)

* 17482fd42 9e63c1ae1 Roll Fuchsia Mac SDK from c1-ICa-ToxzhYLG7F... to jV7nfgH1Tb3Lw0w_S... (flutter/engine#38532) (flutter/flutter#117731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 28, 2022
@engine-flutter-autoroll
c956121 Revert "Remove single-view assumption from ScrollPhysics (#11…
0af7c9a 
…7503)" (flutter/flutter#117647)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Dec 28, 2022
@engine-flutter-autoroll
Roll Flutter from ae292cc to 17482fd (28 revisions) (#6889)
417b370 
* fe3e93e eb8e52c59 Roll Fuchsia Mac SDK from QOdpfMkM_LcPon_zm... to ozbhYRHpQKfnPwJdh... (flutter/engine#38505) (flutter/flutter#117658)

* 41d1911 becee173e Roll Skia from 7442335dce20 to eeec7a127312 (1 revision) (flutter/engine#38506) (flutter/flutter#117662)

* d15db15 84043c672 Roll Skia from eeec7a127312 to 7fe57dac0702 (1 revision) (flutter/engine#38508) (flutter/flutter#117665)

* 4cce45f 06b2eff9d Roll Dart SDK from 6340d946feac to 494e4d4bf58d (1 revision) (flutter/engine#38509) (flutter/flutter#117667)

* d947687 893e48763 Roll Skia from 7fe57dac0702 to 8099f53e7a43 (1 revision) (flutter/engine#38510) (flutter/flutter#117668)

* a7cc010 dbb5a5739 Roll Fuchsia Mac SDK from ozbhYRHpQKfnPwJdh... to HHADjSDGmZSkODScd... (flutter/engine#38511) (flutter/flutter#117669)

* c3f0c13 dcde1faa8 Roll Skia from 8099f53e7a43 to 789552988917 (1 revision) (flutter/engine#38512) (flutter/flutter#117672)

* 91c3f80 790604a09 Roll Skia from 789552988917 to 6abfcf819da1 (2 revisions) (flutter/engine#38513) (flutter/flutter#117674)

* bf2701d 9d69a91bb Roll Dart SDK from 494e4d4bf58d to 742e1dc3e17f (1 revision) (flutter/engine#38514) (flutter/flutter#117681)

* 00e9cf1 e11cb24 Roll Flutter from e766ad0 to ae292cc (6 revisions) (#6885) (flutter/flutter#117682)

* 5538fa1 c54228b5c Roll Skia from 6abfcf819da1 to 4f64211cd741 (1 revision) (flutter/engine#38515) (flutter/flutter#117684)

* 1c273fb 27ebaec7d Roll Skia from 4f64211cd741 to 3939e68c4b4d (2 revisions) (flutter/engine#38517) (flutter/flutter#117686)

* f11fbba [macOS] Fix the `run_debug_test_macos` on arm64 (flutter/flutter#117250)

* d7abc0b a53f1e983 Roll Skia from 3939e68c4b4d to 2b6d44eb650b (2 revisions) (flutter/engine#38519) (flutter/flutter#117689)

* 894ea20 e049bbf41 Roll Fuchsia Mac SDK from HHADjSDGmZSkODScd... to c1-ICa-ToxzhYLG7F... (flutter/engine#38520) (flutter/flutter#117690)

* c956121 Revert "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117647)

* 0dc9739 6e6a6538f Roll Skia from 2b6d44eb650b to 34708fefacd0 (1 revision) (flutter/engine#38521) (flutter/flutter#117694)

* 95a184d 10ce8cd38 [fuchsia] Debugging code for crash. (flutter/engine#38518) (flutter/flutter#117697)

* a89d135 afe49825e Roll Skia from 34708fefacd0 to 1a93cfdae2fd (1 revision) (flutter/engine#38522) (flutter/flutter#117699)

* 0ddfa72 6128780f1 Roll Dart SDK from 742e1dc3e17f to 68d8b0f58be7 (1 revision) (flutter/engine#38523) (flutter/flutter#117701)

* 4e08ebb 8294e2693 Roll Skia from 1a93cfdae2fd to c5c0387b3399 (2 revisions) (flutter/engine#38524) (flutter/flutter#117702)

* d108c91 bfecc4b18 Roll Dart SDK from 68d8b0f58be7 to 5a173adb22ed (1 revision) (flutter/engine#38525) (flutter/flutter#117707)

* 2864acc 2d431852d Roll Skia from c5c0387b3399 to 656bb22387ac (1 revision) (flutter/engine#38526) (flutter/flutter#117711)

* 6f8d176 74ef2cbc8 Roll Fuchsia Linux SDK from iQT5jpUhipvetxSiH... to yX7ot9Un0bpYQ-XX7... (flutter/engine#38527) (flutter/flutter#117713)

* eda7aab dc6670f7b Roll Dart SDK from 5a173adb22ed to 2541cf36607f (1 revision) (flutter/engine#38528) (flutter/flutter#117715)

* 2223235 8d4546d5b Roll Skia from 656bb22387ac to 913271ba5cbb (2 revisions) (flutter/engine#38529) (flutter/flutter#117719)

* f24df97 3bb936567 Roll Skia from 913271ba5cbb to f78bb848bbe1 (2 revisions) (flutter/engine#38531) (flutter/flutter#117721)

* 17482fd 9e63c1ae1 Roll Fuchsia Mac SDK from c1-ICa-ToxzhYLG7F... to jV7nfgH1Tb3Lw0w_S... (flutter/engine#38532) (flutter/flutter#117731)
@XilaiZhang XilaiZhang mentioned this pull request Jan 3, 2023
Merged
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@XilaiZhang @loic-sharma
Revert "Remove single-view assumption from ScrollPhysics (flutter#117503
3a49bb4 
)" (flutter#117647)

This reverts commit 999356b.
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@XilaiZhang @gspencergoog
Revert "Remove single-view assumption from ScrollPhysics (flutter#117503
378f757 
)" (flutter#117647)

This reverts commit 999356b.
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from ae292cc to 17482fd (28 revisions) (flutter#6889)
430d8f8 
* fe3e93e eb8e52c59 Roll Fuchsia Mac SDK from QOdpfMkM_LcPon_zm... to ozbhYRHpQKfnPwJdh... (flutter/engine#38505) (flutter/flutter#117658)

* 41d1911 becee173e Roll Skia from 7442335dce20 to eeec7a127312 (1 revision) (flutter/engine#38506) (flutter/flutter#117662)

* d15db15 84043c672 Roll Skia from eeec7a127312 to 7fe57dac0702 (1 revision) (flutter/engine#38508) (flutter/flutter#117665)

* 4cce45f 06b2eff9d Roll Dart SDK from 6340d946feac to 494e4d4bf58d (1 revision) (flutter/engine#38509) (flutter/flutter#117667)

* d947687 893e48763 Roll Skia from 7fe57dac0702 to 8099f53e7a43 (1 revision) (flutter/engine#38510) (flutter/flutter#117668)

* a7cc010 dbb5a5739 Roll Fuchsia Mac SDK from ozbhYRHpQKfnPwJdh... to HHADjSDGmZSkODScd... (flutter/engine#38511) (flutter/flutter#117669)

* c3f0c13 dcde1faa8 Roll Skia from 8099f53e7a43 to 789552988917 (1 revision) (flutter/engine#38512) (flutter/flutter#117672)

* 91c3f80 790604a09 Roll Skia from 789552988917 to 6abfcf819da1 (2 revisions) (flutter/engine#38513) (flutter/flutter#117674)

* bf2701d 9d69a91bb Roll Dart SDK from 494e4d4bf58d to 742e1dc3e17f (1 revision) (flutter/engine#38514) (flutter/flutter#117681)

* 00e9cf1 e11cb24 Roll Flutter from e766ad0 to ae292cc (6 revisions) (flutter#6885) (flutter/flutter#117682)

* 5538fa1 c54228b5c Roll Skia from 6abfcf819da1 to 4f64211cd741 (1 revision) (flutter/engine#38515) (flutter/flutter#117684)

* 1c273fb 27ebaec7d Roll Skia from 4f64211cd741 to 3939e68c4b4d (2 revisions) (flutter/engine#38517) (flutter/flutter#117686)

* f11fbba [macOS] Fix the `run_debug_test_macos` on arm64 (flutter/flutter#117250)

* d7abc0b a53f1e983 Roll Skia from 3939e68c4b4d to 2b6d44eb650b (2 revisions) (flutter/engine#38519) (flutter/flutter#117689)

* 894ea20 e049bbf41 Roll Fuchsia Mac SDK from HHADjSDGmZSkODScd... to c1-ICa-ToxzhYLG7F... (flutter/engine#38520) (flutter/flutter#117690)

* c956121 Revert "Remove single-view assumption from ScrollPhysics (#117503)" (flutter/flutter#117647)

* 0dc9739 6e6a6538f Roll Skia from 2b6d44eb650b to 34708fefacd0 (1 revision) (flutter/engine#38521) (flutter/flutter#117694)

* 95a184d 10ce8cd38 [fuchsia] Debugging code for crash. (flutter/engine#38518) (flutter/flutter#117697)

* a89d135 afe49825e Roll Skia from 34708fefacd0 to 1a93cfdae2fd (1 revision) (flutter/engine#38522) (flutter/flutter#117699)

* 0ddfa72 6128780f1 Roll Dart SDK from 742e1dc3e17f to 68d8b0f58be7 (1 revision) (flutter/engine#38523) (flutter/flutter#117701)

* 4e08ebb 8294e2693 Roll Skia from 1a93cfdae2fd to c5c0387b3399 (2 revisions) (flutter/engine#38524) (flutter/flutter#117702)

* d108c91 bfecc4b18 Roll Dart SDK from 68d8b0f58be7 to 5a173adb22ed (1 revision) (flutter/engine#38525) (flutter/flutter#117707)

* 2864acc 2d431852d Roll Skia from c5c0387b3399 to 656bb22387ac (1 revision) (flutter/engine#38526) (flutter/flutter#117711)

* 6f8d176 74ef2cbc8 Roll Fuchsia Linux SDK from iQT5jpUhipvetxSiH... to yX7ot9Un0bpYQ-XX7... (flutter/engine#38527) (flutter/flutter#117713)

* eda7aab dc6670f7b Roll Dart SDK from 5a173adb22ed to 2541cf36607f (1 revision) (flutter/engine#38528) (flutter/flutter#117715)

* 2223235 8d4546d5b Roll Skia from 656bb22387ac to 913271ba5cbb (2 revisions) (flutter/engine#38529) (flutter/flutter#117719)

* f24df97 3bb936567 Roll Skia from 913271ba5cbb to f78bb848bbe1 (2 revisions) (flutter/engine#38531) (flutter/flutter#117721)

* 17482fd 9e63c1ae1 Roll Fuchsia Mac SDK from c1-ICa-ToxzhYLG7F... to jV7nfgH1Tb3Lw0w_S... (flutter/engine#38532) (flutter/flutter#117731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

@goderbauer goderbauer Awaiting requested review from goderbauer

Assignees
No one assigned
Labels
a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XilaiZhang @whesse @LongCatIsLooong