Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland "Update ExpansionTile to support Material 3 & add an example" #121212

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Reland "Update ExpansionTile to support Material 3 & add an example" #121212

merged 1 commit into from
Feb 24, 2023

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 22, 2023 •
edited
Loading

reland #119712 with feedback

fixes #119627

@HansMuller
I updated collapsedIconColorwith onSurfaceVariantinstead of onSurface, to be consistent with the ListTilewidget which I updated in a recent PR #120444

flutter/packages/flutter/lib/src/material/list_tile.dart

Line 1596 in 4c25587

Color? get iconColor => _colors.onSurfaceVariant;

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Feb 22, 2023
@HansMuller
Copy link
Contributor

Looks like there are some failures to fix...

@TahaTesser
Copy link
Member Author

Looks like there are some failures to fix...

Apologies, fixed an unintended example comment. However, the current failures are related to #121242 (I also see them on my other PRs)

@HansMuller
Copy link
Contributor

Aha, I see. #121242 is a P0, so I trust it will be resolved soon.

Using onSurfaceVariant for the iconColor instead of onSurface is OK with me. Doing that, for consistency with ListTile, has been suggested by other developers too.

@HansMuller
Copy link
Contributor

@TahaTesser - unfortunately one more internal change must land before this PR can. Fingers crossed, we may be good to go tomorrow.

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 24, 2023

auto label is removed for flutter/flutter, pr: 121212, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 24, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 24, 2023

auto label is removed for flutter/flutter, pr: 121212, due to Validations Fail.

HansMuller
HansMuller approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller merged commit 219ff64 into flutter:master Feb 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
124eeff 
…xample" (flutter/flutter#121212)
@TahaTesser TahaTesser deleted the reland_expansion_tile_m3 branch February 24, 2023 15:07
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
c9a164c 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
6171ae8 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
1757759 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
a41a852 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
891d9ec 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
7bb4b42 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
13a6b34 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
fefce3f 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
751153e 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
11047d0 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
47c79c7 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
c876785 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
a8ee8bc 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
9ca46b2 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
2bacee5 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
065b0c1 
…xample" (flutter/flutter#121212)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
2edec87 
…xample" (flutter/flutter#121212)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
19b66cf 
…xample" (flutter/flutter#121212)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
219ff64 Reland "Update ExpansionTile to support Material 3 & add an e…
5e95bd3 
…xample" (flutter/flutter#121212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ExpansionTile to support Material 3
2 participants
@TahaTesser @HansMuller