[flutter roll] Revert "Use AnimatedSwitcher's _childNumber as Key in layoutBuilder's Stack" #121835
Conversation
flutter-dashboard
bot
added
the
framework
XilaiZhang
requested review from
goderbauer,
jonahwilliams,
cbracken and
christopherfujino
XilaiZhang
added
the
autosubmit
auto-submit
bot
deleted the
revert-121408-fix-animated-switcher-duplicate-keys
branch
… Stack (flutter#121408)" (flutter#121835) [flutter roll] Revert "Use AnimatedSwitcher's _childNumber as Key in layoutBuilder's Stack"
|
Hi, I was wondering why #121408 got reverted? I‘m not sure I understand the problem. |
…tBuilder's Stack (#121408)" (flutter/flutter#121835)
|
@jimgerth This is gonna be a little frustrating and I apologize in advance for that: The change was breaking a number of google-internal apps. Unfortunately, I can't give you access to the failing tests. I still believe that your change is the correct one to make. However, until someone with access to google-internal systems can take a look and figure out why these tests are failing we can't make the change. I'll see if I can find someone who can take a look at this. |
|
@goderbauer Alright, thanks for the response. If I can't do anything about it, I can remove it from the back of my mind at least :D |
…tBuilder's Stack (#121408)" (flutter/flutter#121835)
|
@goderbauer Are there updates on this by any chance? |
|
@goderbauer Has anyone looked at this in the past month? |
|
@jimgerth Another place you might try is in Discord: You can ask there if someone can help you land a bugfix that needs help resolving some Google internal tests. |
…tBuilder's Stack (#121408)" (flutter/flutter#121835)
…tBuilder's Stack (#121408)" (flutter/flutter#121835)
Reverts #121408
I created a tracking bug with scuba links in b/271479418