Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland: Removes single window assumptions from flutter_test #122060

Merged
merged 4 commits into from
Mar 7, 2023

Commits on Mar 6, 2023

  1. Reland: Removes single window assumptions from flutter_test

    * Adds `TestFlutterView` to wrap `FlutterView` and allow modification of properties for testing
    * Updates `TestPlatformDispatcher` to wrap its views in `TestFlutterView`s when they are changed
    * Adds `viewOf` to `WidgetController` for finding a `TestFlutterView` related to the results of a `Finder`
    * Exposes `platformDispatcher` and `implicitView` from `WidgetController` (and `WidgetTester`)
      * This is so the related `viewOf` method, which uses the `Finder` API, will be in a consistent place with these methods and other `Finder` APIs
    pdblasi-google committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    fe61a87 View commit details
    Browse the repository at this point in the history
  2. Update TestFlutterView.physicalSize to be able to default to `_view…

    ….physicalSize` to allow for the web implementation where `physicalGeometry` and `physicalSize` can be decoupled.
    pdblasi-google committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    0d3c9cf View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Configuration menu
    Copy the full SHA
    019cc18 View commit details
    Browse the repository at this point in the history
  2. Updates from PR.

    pdblasi-google committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    537f5f3 View commit details
    Browse the repository at this point in the history