Reland: Removes single window assumptions from flutter_test
#122060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds `TestFlutterView` to wrap `FlutterView` and allow modification of properties for testing * Updates `TestPlatformDispatcher` to wrap its views in `TestFlutterView`s when they are changed * Adds `viewOf` to `WidgetController` for finding a `TestFlutterView` related to the results of a `Finder` * Exposes `platformDispatcher` and `implicitView` from `WidgetController` (and `WidgetTester`) * This is so the related `viewOf` method, which uses the `Finder` API, will be in a consistent place with these methods and other `Finder` APIs
flutter-dashboard
bot
added
a: tests
….physicalSize` to allow for the web implementation where `physicalGeometry` and `physicalSize` can be decoupled.
pdblasi-google
force-pushed
the
issues/117481
branch
from
bf2219f
to
0d3c9cf
Compare
|
Looks like this is failing some checks. |
pdblasi-google
force-pushed
the
issues/117481
branch
from
5a1102a
to
537f5f3
Compare
pdblasi-google
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 8, 2023
8 tasks
hangyujin
pushed a commit
to hangyujin/flutter
that referenced
this pull request
Mar 11, 2023
…r#122060) Reland: Removes single window assumptions from `flutter_test`
hangyujin
pushed a commit
to hangyujin/flutter
that referenced
this pull request
Mar 11, 2023
…flutter#122060)" (flutter#122193) Revert "Reland: Removes single window assumptions from `flutter_test`"
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestFlutterViewto wrapFlutterViewand allow modification of properties for testingTestPlatformDispatcherto wrap its views inTestFlutterViews when they are changedviewOftoWidgetControllerfor finding aTestFlutterViewrelated to the results of aFinderplatformDispatcherandimplicitViewfromWidgetController(andWidgetTester)viewOfmethod, which uses theFinderAPI, will be in a consistent place with these methods and otherFinderAPIsResolves #117481
The difference between this and the original PR can be reviewed with this commit.
Pre-launch Checklist
///).