Update sdk version in temp testing package #122423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
| @@ -60,7 +60,7 @@ void main() { | |||
| pubspecFile.writeAsStringSync(''' | |||
| name: foo_project | |||
| environment: | |||
| sdk: '>=2.10.0 <4.0.0' | |||
| sdk: '>=2.12.0 <4.0.0' | |||
There was a problem hiding this comment.
This LGTM, just verifying there are no other hard-coded constraints we need to bump
There was a problem hiding this comment.
Feel free to approve and tag for autosubmit if you find that this is a sufficiently complete fix.
christopherfujino
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 122423, due to - The status or check suite Mac module_host_with_custom_build_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
a-siva
approved these changes
Mar 10, 2023
christopherfujino
added
the
autosubmit
hangyujin
pushed a commit
to hangyujin/flutter
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test seems to suddenly be timing out when we try to roll an Engine that has a new Dart SDK with a minimum sdk version of 2.12.