New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #122505
Merged
auto-submit
merged 11 commits into
flutter:master
from
andrewkolos:reland-use-binary-asset-manifest-in-image-resolution-2
Mar 15, 2023
Merged
Reland "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #122505
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dca9728
use binary asset manifest for image resolution
andrewkolos 726004b
fix: missing cache write in loadStructuredBinaryData
andrewkolos 14758a4
remove now-redundant cache write
andrewkolos deccbac
add test for synchronous loading behavior
andrewkolos f758d92
refactor: group CachingAssetBunlde behavior tests together
andrewkolos 6cf04f7
modify new group
andrewkolos d72857a
actually test the cached value in new test
andrewkolos 514fd64
super nit
andrewkolos 33f4a2a
add loadStructuredData counterpart for new test
andrewkolos b8b7f61
fix tests
andrewkolos 643f2c3
Merge remote-tracking branch 'upstream/master' into reland-use-binary…
andrewkolos File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a unit test that directly invokes loadStructuredBinaryData and asserts that the cache is populated sychonously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. I added some new tests (and moved others around).