New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused replacement from Visibility.maintain #123039
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
LGTM, but dartdocs for |
Ah, right. Updated by removing that line altogether. Since we don't support non-nullsafe mode anymore, the note about child not being null is also redundant. |
test-exempt: removing code |
While reviewing #122585 I noticed that the
replacement
parameter onVisibility.maintain
doesn't make any sense. It is always ignored because the constructor forcesmaintainState
to true:flutter/packages/flutter/lib/src/widgets/visibility.dart
Lines 139 to 140 in e0ea39f
Therefore, this PR removed the
replacement
parameter fromVisibility.maintain
.