New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SemanticsFlag
/SemanticsAction
cleanup (part 2)
#123817
Conversation
SemanticsFlag
/SemanticsAction
enum migration (part 2)
Do we need to make the analyzer pass? It fails because the property is deprecated, which is what we want. cc @goderbauer |
Yes! You'll have to add |
38ac2e6
to
34a7409
Compare
Here it goes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How Google testing failed? I didn't think this was possible.. There are zero changes here. |
It probably failed because the engine change this needs hasn’t rolled into Google yet. I’ll verify that tomorrow and let you know. |
34a7409
to
9293202
Compare
@chunhtai can you give this a secondary review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SemanticsFlag
/SemanticsAction
enum migration (part 2)SemanticsFlag
/SemanticsAction
cleanup (part 2)
…3817) `SemanticsFlag`/`SemanticsAction` enum migration (part 2)
Part 2 of #123346
Migrate their usages into temporary properties.