Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[integration_test] upgrade androidx test to 1.4.0" #124644

Merged
merged 1 commit into from Apr 12, 2023

Conversation

zanderso
Copy link
Member

Reverts #122437

This is causing several Android devicelab tests to fail on the first attempt, causing them to be marked flaky. The cause appears to be unexpected output on stderr. See: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/5390/overview

@flutter-dashboard flutter-dashboard bot added d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Apr 12, 2023
@zanderso
Copy link
Member Author

cc @micaelcid

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@zanderso zanderso merged commit cc2a045 into master Apr 12, 2023
133 of 139 checks passed
@zanderso zanderso deleted the revert-122437-master branch April 12, 2023 01:55
@micaelcid
Copy link
Contributor

micaelcid commented Apr 12, 2023

In this case scenario, should we escalate this problem to an infrastructure team or someone else? I'm uncertain if I'm doing something wrong or if the tests' infrastructure should be upgraded along with Android test dependencies. 🤔

I mean, this was my second consecutive attempt to get these integration_test changes merged into master that got reverted, even though the PR pipeline didn't catch anything. I'm new to open-sourcing and I confess I feel a little bit lost in moments like these 😅

cc @zanderso

@zanderso
Copy link
Member Author

@micaelcid The error message in the logs that broke the tests is the following:

[2023-04-11 20:02:04.216019] [STDOUT] run:stderr: Note: /opt/s/w/ir/x/w/recipe_cleanup/tmpcgyxdgaw/flutter sdk/packages/integration_test/android/src/main/java/dev/flutter/plugins/integration_test/FlutterTestRunner.java uses or overrides a deprecated API.
[2023-04-11 20:02:04.218200] [STDOUT] run:stderr: Note: Recompile with -Xlint:deprecation for details.

Unfortunately, I'm not familiar with the change that you're trying to land, but I can tell you that the file it is complaining about is here: https://github.com/flutter/flutter/blob/master/packages/integration_test/android/src/main/java/dev/flutter/plugins/integration_test/FlutterTestRunner.java.

I suspect that the dependency that you are updating requires a change in that file to fix the error. @reidbaker may have more specific advice about how to proceed.

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
…24644)

Reverts flutter#122437

This is causing several Android devicelab tests to fail on the first
attempt, causing them to be marked flaky. The cause appears to be
unexpected output on stderr. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/5390/overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants