New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the BottomNavigationBar API doc to link to NavigationBar #125240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:)
/// [NavigationBar] widget's visuals are a little bit different, see | ||
/// The Material 3 spec at | ||
/// <https://m3.material.io/components/navigation-bar/overview> for | ||
/// more details. The API is is similar, destinations are defined with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double is here:)
/// that's preferred for new applications and applications that are | ||
/// configured for Material 3 (see [ThemeData.useMaterial3]). The | ||
/// [NavigationBar] widget's visuals are a little bit different, see | ||
/// The Material 3 spec at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe "T" of The should be lower case:)
03ea820
to
71bcf64
Compare
The BottomNavigationBar API doc now makes it clear that NavigationBar is preferred in new M3 applications.
Fixes #124687