Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the Drawer API doc to link to NavigationDrawer #126915

Merged
merged 1 commit into from May 16, 2023
Merged

Updated the Drawer API doc to link to NavigationDrawer #126915

merged 1 commit into from May 16, 2023

Conversation

TahaTesser
Copy link
Member

fixes #124887

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 16, 2023
@TahaTesser TahaTesser added the d: api docs Issues with https://api.flutter.dev/ label May 16, 2023
HansMuller
HansMuller approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, thanks!

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit auto-submit bot merged commit 2f5ed33 into flutter:master May 16, 2023
70 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
d18a36a 
…lutter/flutter#126915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
5fcf562 
…lutter/flutter#126915)
@TahaTesser TahaTesser deleted the update_drawer_doc_for_m3 branch May 16, 2023 16:04
@TahaTesser
Copy link
Member Author

Nice update, thanks!

It was easier thanks to your original PR #125240

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
e4266a4 
…lutter/flutter#126915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
5c7f9db 
…lutter/flutter#126915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
18876a8 
…lutter/flutter#126915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
b803336 
…lutter/flutter#126915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
4474199 
…lutter/flutter#126915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
11cebe0 
…lutter/flutter#126915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
daffa3a 
…lutter/flutter#126915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
e5b90db 
…lutter/flutter#126915)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
50ae7ed 
…lutter/flutter#126915)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@TahaTesser
Updated the Drawer API doc to link to NavigationDrawer (flutter#1…
0054670 
…26915)

fixes flutter#124887
This was referenced May 25, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
f26102a 
…lutter/flutter#126915)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
4dbf008 
…lutter/flutter#126915)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
85ed502 
…lutter/flutter#126915)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
2f5ed3391 Updated the Drawer API doc to link to NavigationDrawer (f…
d280ec1 
…lutter/flutter#126915)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drawer -> NavigationDrawer needs migration guide and docs
2 participants
@TahaTesser @HansMuller