Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tool,web] Include more info URI on Wasm init failure #125312

Merged
merged 5 commits into from Apr 24, 2023
Merged

[tool,web] Include more info URI on Wasm init failure #125312

merged 5 commits into from Apr 24, 2023

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 21, 2023

No description provided.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 21, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@kevmoo kevmoo requested a review from yjbanov April 21, 2023 23:01
@kevmoo kevmoo added platform-web Web applications specifically e: wasm Issues related to the wasm build of Flutter Web. labels Apr 24, 2023
@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 24, 2023

@Hixie – could I get an exemption? 😄

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2023
@auto-submit auto-submit bot merged commit 034adb6 into master Apr 24, 2023
122 checks passed
@auto-submit auto-submit bot deleted the better_wasm_warning branch April 24, 2023 18:33
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
034adb66c [tool,web] Include more info URI on Wasm init failure (flut…
498a19a 
…ter/flutter#125312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
034adb66c [tool,web] Include more info URI on Wasm init failure (flut…
d754cee 
…ter/flutter#125312)
@Hixie
Copy link
Contributor

Hixie commented Apr 24, 2023

It looks like this was landed without tests and without a test exemption.

@kevmoo
Copy link
Contributor Author

kevmoo commented Apr 24, 2023

It looks like this was landed without tests and without a test exemption.

Gah! I saw your comments...like "you looked it it", but you're right. Uh. How would you like me to proceed?

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
034adb66c [tool,web] Include more info URI on Wasm init failure (flut…
705fcd9 
…ter/flutter#125312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
034adb66c [tool,web] Include more info URI on Wasm init failure (flut…
e4f1948 
…ter/flutter#125312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
034adb66c [tool,web] Include more info URI on Wasm init failure (flut…
f18ce0d 
…ter/flutter#125312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
034adb66c [tool,web] Include more info URI on Wasm init failure (flut…
afd71dd 
…ter/flutter#125312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
034adb66c [tool,web] Include more info URI on Wasm init failure (flut…
c6ae358 
…ter/flutter#125312)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 26, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
034adb66c [tool,web] Include more info URI on Wasm init failure (flut…
4bcc307 
…ter/flutter#125312)
@Hixie
Copy link
Contributor

Hixie commented Apr 26, 2023

It looks like this was landed without tests and without a test exemption.

Gah! I saw your comments...like "you looked it it", but you're right. Uh. How would you like me to proceed?

Well ideally we'd have a test that would catch the error that was in the original version of the PR -- I'm not sure if there's a JS linter or something we could apply to the output we generate? But that would be ideal...

stuartmorgan pushed a commit to flutter/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions) (#3830)
66703bc 
Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions)

flutter/flutter@c9004ff...66fa4c5

2023-04-26 zanderso@users.noreply.github.com Remove web compile
benchmarks that specify an attached device (flutter/flutter#125559)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549)
2023-04-26 goderbauer@google.com Update prefer_final_parameters comment
(flutter/flutter#125465)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531)
2023-04-26 zanderso@users.noreply.github.com Add hostonly web compile
size benchmarks (flutter/flutter#125518)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529)
2023-04-25 thkim1011@users.noreply.github.com Handle dollar signs
properly when generating localizations (flutter/flutter#125514)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513)
2023-04-25 47866232+chunhtai@users.noreply.github.com Adds selected
semantics flag to radio button for Apple devices
(flutter/flutter#125499)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510)
2023-04-25 58529443+srujzs@users.noreply.github.com Relabel JSFunction
as JSExportedDartFunction (flutter/flutter#125453)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504)
2023-04-25 jmccandless@google.com iOS TextField spell check style
(flutter/flutter#125432)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463)
2023-04-25 tessertaha@gmail.com Fix `SliverAppBar.medium` &
`SliverAppBar.large` text scale (flutter/flutter#125038)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452)
2023-04-24 tessertaha@gmail.com Add Sliders to `macrobenchmarks`
(flutter/flutter#125296)
2023-04-24 pateltirth454@gmail.com [date_picker] [date_range_picker] add
properties to change switch-to icons (flutter/flutter#124881)
2023-04-24 thkim1011@users.noreply.github.com Sliver Constrained Cross
Axis (flutter/flutter#125239)
2023-04-24 kevmoo@users.noreply.github.com tool: Move cdKey to
CustomDimensionsEnum (flutter/flutter#125335)
2023-04-24 bernaferrari2@gmail.com Add `borderRadius` to
LinearProgressIndicator (flutter/flutter#123517)
2023-04-24 58529443+srujzs@users.noreply.github.com Fix JS types in
_test_http_request.dart (flutter/flutter#125220)
2023-04-24 tessertaha@gmail.com Fix `OutlinedButton`, `TextButton`, and
`IconButton` throw exception when passing only one cursor to `styleFrom`
(flutter/flutter#125204)
2023-04-24 magder@google.com Swap some iOS TESTOWNERS
(flutter/flutter#125340)
2023-04-24 rmolivares@renzo-olivares.dev Fix iOS touch drag behavior
(flutter/flutter#125169)
2023-04-24 54558023+keyonghan@users.noreply.github.com Mark
module_test_ios flaky (flutter/flutter#125426)
2023-04-24 47866232+chunhtai@users.noreply.github.com Implement url
support for RouteInformation and didPushRouteInformation
(flutter/flutter#119968)
2023-04-24 kevmoo@users.noreply.github.com [tool,web] Include more info
URI on Wasm init failure (flutter/flutter#125312)
2023-04-24 magder@google.com Do not run
`windows_home_scroll_perf__timeline_summary` benchmark in presubmit
(flutter/flutter#125343)
2023-04-24 5236035+fzyzcjy@users.noreply.github.com Tiny fix doc
pointing to incorrect widget confusing the readers
(flutter/flutter#125394)
...
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions) (flutte…
8844fd8 
…r#3830)

Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions)

flutter/flutter@c9004ff...66fa4c5

2023-04-26 zanderso@users.noreply.github.com Remove web compile
benchmarks that specify an attached device (flutter/flutter#125559)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549)
2023-04-26 goderbauer@google.com Update prefer_final_parameters comment
(flutter/flutter#125465)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531)
2023-04-26 zanderso@users.noreply.github.com Add hostonly web compile
size benchmarks (flutter/flutter#125518)
2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from
34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529)
2023-04-25 thkim1011@users.noreply.github.com Handle dollar signs
properly when generating localizations (flutter/flutter#125514)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513)
2023-04-25 47866232+chunhtai@users.noreply.github.com Adds selected
semantics flag to radio button for Apple devices
(flutter/flutter#125499)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510)
2023-04-25 58529443+srujzs@users.noreply.github.com Relabel JSFunction
as JSExportedDartFunction (flutter/flutter#125453)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504)
2023-04-25 jmccandless@google.com iOS TextField spell check style
(flutter/flutter#125432)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463)
2023-04-25 tessertaha@gmail.com Fix `SliverAppBar.medium` &
`SliverAppBar.large` text scale (flutter/flutter#125038)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454)
2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from
5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452)
2023-04-24 tessertaha@gmail.com Add Sliders to `macrobenchmarks`
(flutter/flutter#125296)
2023-04-24 pateltirth454@gmail.com [date_picker] [date_range_picker] add
properties to change switch-to icons (flutter/flutter#124881)
2023-04-24 thkim1011@users.noreply.github.com Sliver Constrained Cross
Axis (flutter/flutter#125239)
2023-04-24 kevmoo@users.noreply.github.com tool: Move cdKey to
CustomDimensionsEnum (flutter/flutter#125335)
2023-04-24 bernaferrari2@gmail.com Add `borderRadius` to
LinearProgressIndicator (flutter/flutter#123517)
2023-04-24 58529443+srujzs@users.noreply.github.com Fix JS types in
_test_http_request.dart (flutter/flutter#125220)
2023-04-24 tessertaha@gmail.com Fix `OutlinedButton`, `TextButton`, and
`IconButton` throw exception when passing only one cursor to `styleFrom`
(flutter/flutter#125204)
2023-04-24 magder@google.com Swap some iOS TESTOWNERS
(flutter/flutter#125340)
2023-04-24 rmolivares@renzo-olivares.dev Fix iOS touch drag behavior
(flutter/flutter#125169)
2023-04-24 54558023+keyonghan@users.noreply.github.com Mark
module_test_ios flaky (flutter/flutter#125426)
2023-04-24 47866232+chunhtai@users.noreply.github.com Implement url
support for RouteInformation and didPushRouteInformation
(flutter/flutter#119968)
2023-04-24 kevmoo@users.noreply.github.com [tool,web] Include more info
URI on Wasm init failure (flutter/flutter#125312)
2023-04-24 magder@google.com Do not run
`windows_home_scroll_perf__timeline_summary` benchmark in presubmit
(flutter/flutter#125343)
2023-04-24 5236035+fzyzcjy@users.noreply.github.com Tiny fix doc
pointing to incorrect widget confusing the readers
(flutter/flutter#125394)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie left review comments

@mdebbar mdebbar mdebbar approved these changes

@eyebrowsoffire eyebrowsoffire Awaiting requested review from eyebrowsoffire

@yjbanov yjbanov Awaiting requested review from yjbanov

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: wasm Issues related to the wasm build of Flutter Web. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevmoo @Hixie @mdebbar