Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: moreOrLessEquals does not allow actual to be integers #125599

Merged
merged 2 commits into from Apr 27, 2023
Merged

fix: moreOrLessEquals does not allow actual to be integers #125599

merged 2 commits into from Apr 27, 2023

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Apr 27, 2023 •
edited by ricardoamador

Close #125600

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Apr 27, 2023
@fzyzcjy fzyzcjy marked this pull request as ready for review April 27, 2023 02:37
jonahwilliams
jonahwilliams approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

werainkhatri
werainkhatri approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow. thanks for fixing this. LGTM.

@werainkhatri werainkhatri added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 27, 2023
@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Apr 27, 2023

You are welcome!

@fzyzcjy
Copy link
Contributor Author

fzyzcjy commented Apr 27, 2023 •
edited

Btw, tree tip is green + 2 approvals + autosubmit label + google testing passed, but the bot does not merge the PR after half an hour. Shall I file an infra bug?

EDIT: Already posted in https://discord.com/channels/608014603317936148/608021351567065092/1101090518387138560

image
image
image

@ricardoamador ricardoamador added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Apr 27, 2023
@auto-submit auto-submit bot merged commit 37c95a2 into flutter:master Apr 27, 2023
69 checks passed
@TahaTesser TahaTesser mentioned this pull request Apr 28, 2023
Merged
8 tasks
@Piinks Piinks mentioned this pull request Apr 28, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
2fc597d 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
a5e2e45 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
a489c2d 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
145e7bd 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
23f366a 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
0e9045e 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
1ad8ab4 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
a4178b4 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
1511d75 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
deee1bb 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
51a80c4 
…ers (flutter/flutter#125599)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
d94f0de 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
77bcd0b 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
e1779e1 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
66bc5a5 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
3edccd0 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
9c657cf 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
45bb269 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
f71c80d 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
c78b3b7 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
129e807 
…ers (flutter/flutter#125599)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023
@engine-flutter-autoroll
37c95a285 fix: moreOrLessEquals does not allow actual to be integ…
8970928 
…ers (flutter/flutter#125599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@werainkhatri werainkhatri werainkhatri approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

moreOrLessEquals does not allow actual to be integers
4 participants
@fzyzcjy @jonahwilliams @werainkhatri @ricardoamador