Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding printOnFailure for result of process #125910

Merged
merged 3 commits into from May 3, 2023
Merged

Adding printOnFailure for result of process #125910

merged 3 commits into from May 3, 2023

Conversation

eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented May 2, 2023 •
edited

Adding a printOnFailure call into the flakey test to help debug the cause for future failures.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 2, 2023
@eliasyishak eliasyishak marked this pull request as ready for review May 2, 2023 20:40
christopherfujino
christopherfujino approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eliasyishak eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label May 3, 2023
@auto-submit auto-submit bot merged commit 9160c6e into flutter:master May 3, 2023
122 checks passed
@eliasyishak eliasyishak mentioned this pull request May 3, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
e01909e 
…r#125910)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
5fcc22e 
…r#125910)
@eliasyishak eliasyishak deleted the 125512-error-handling-for-flake branch May 3, 2023 17:08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
97db643 
…r#125910)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
9ea0a7d 
…r#125910)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
ed53d15 
…r#125910)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
f350719 
…r#125910)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
f2b82c4 
…r#125910)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
fb3207b 
…r#125910)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
e767a11 
…r#125910)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 4, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
1931c60 
…r#125910)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
64f5208 
…r#125910)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
44af308 
…r#125910)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
852e857 
…r#125910)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
9160c6e7f Adding printOnFailure for result of process (flutter/flutte…
858ac1c 
…r#125910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliasyishak @christopherfujino