Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding printOnFailure for result of process #125910

Merged
merged 3 commits into from May 3, 2023
Merged

Adding printOnFailure for result of process #125910

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b28ed90
Adding printOnFailure for result of process
eliasyishak May 2, 2023
69a32fb
Update analyze_size_test.dart
eliasyishak May 2, 2023
feeaf49
printOnFailure to include command ran + workingDir
eliasyishak May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 16 additions & 2 deletions packages/flutter_tools/test/integration.shard/analyze_size_test.dart
View file
Open in desktop
Expand Up @@ -177,15 +177,29 @@ void main() {
final String flutterBin = fileSystem.path.join(getFlutterRoot(), 'bin', 'flutter');
final Directory tempDir = fileSystem.systemTempDirectory.createTempSync('flutter_size_test.');

final ProcessResult result = await processManager.run(<String>[
final List<String> command = <String>[
flutterBin,
'build',
'apk',
'--analyze-size',
'--code-size-directory=${tempDir.path}',
'--target-platform=android-arm64',
'--release',
], workingDirectory: fileSystem.path.join(getFlutterRoot(), 'examples', 'hello_world'));
];
final String workingDirectory = fileSystem.path.join(
getFlutterRoot(),
'examples',
'hello_world',
);
final ProcessResult result = await processManager.run(
command,
workingDirectory: workingDirectory,
);

printOnFailure('workingDirectory: $workingDirectory');
printOnFailure('command:\n${command.join(" ")}');
printOnFailure('stdout:\n${result.stdout}');
eliasyishak marked this conversation as resolved.
Show resolved Hide resolved
printOnFailure('stderr:\n${result.stderr}');

expect(result.exitCode, 0);
expect(tempDir.existsSync(), true);
Expand Down