Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tool] Overhaul Java-finding logic #126029

Closed
wants to merge 14 commits into from
Closed

[tool] Overhaul Java-finding logic #126029

wants to merge 14 commits into from

Conversation

andrewkolos
Copy link
Contributor

@andrewkolos andrewkolos commented May 3, 2023 •
edited

WIP

Probably will close this in favor of a sequence of smaller PRs.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. labels May 3, 2023
@andrewkolos andrewkolos added platform-android Android applications specifically c: tech-debt Technical debt, code quality, testing, etc. and removed a: text input Entering text in a text field or keyboard related problems labels May 3, 2023
@andrewkolos andrewkolos changed the title [tool] Move Java-specific APIs to their own file [tool] Overhaul Java-finding logic May 4, 2023
@flutter-dashboard flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label May 4, 2023
@andrewkolos andrewkolos mentioned this pull request May 4, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request May 11, 2023
@andrewkolos
[tool] Move Java functions to their own file (#126086)
0a63cd7 
This is the first step in unifying Java-finding logic across the tool. If curious, see #126029 for an example of what all the changes will probably entail.

Moves java-related functionality like `AndroidSdk.findJavaHome` to a new class, `Java`.

See tracking issue #126126 for more.
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@andrewkolos
[tool] Move Java functions to their own file (flutter#126086)
a5fd7ca 
This is the first step in unifying Java-finding logic across the tool. If curious, see flutter#126029 for an example of what all the changes will probably entail.

Moves java-related functionality like `AndroidSdk.findJavaHome` to a new class, `Java`.

See tracking issue flutter#126126 for more.
@andrewkolos
Copy link
Contributor Author

Closing as superseded by #127354.

@andrewkolos andrewkolos deleted the move-java-functions branch June 15, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems c: tech-debt Technical debt, code quality, testing, etc. platform-android Android applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andrewkolos