[tool] Move Java functions to their own file #126086

andrewkolos · 2023-05-04T18:46:09Z

This is the first step in unifying Java-finding logic across the tool. If curious, see #126029 for an example of what all the changes will probably entail.

Moves java-related functionality like AndroidSdk.findJavaHome to a new class, Java.

See tracking issue #126126 for more.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter_tools/lib/src/android/android_sdk.dart

packages/flutter_tools/lib/src/android/java.dart

packages/flutter_tools/test/src/fakes.dart

packages/flutter_tools/lib/src/globals.dart

…er#126086)

Relands #126086, which was reverted by #126569.

…icenses` (#127344) #126086 inadvertently fixed #124776 This follow-up PR gets the fix under test.

This is the first step in unifying Java-finding logic across the tool. If curious, see flutter#126029 for an example of what all the changes will probably entail. Moves java-related functionality like `AndroidSdk.findJavaHome` to a new class, `Java`. See tracking issue flutter#126126 for more.

Reverts flutter#126086. This PR changed the interfaces of some classes, namely `AndroidSdk`, and deleted a global. These classes had custom overrides in g3 that were not updated with a g3fix, so this PR has broken tests. See https://b.corp.google.com/issues/281945232 (non-public link)

Relands flutter#126086, which was reverted by flutter#126569.

…icenses` (flutter#127344) flutter#126086 inadvertently fixed flutter#124776 This follow-up PR gets the fix under test.

…er#126086)

introduce Java class and have AndroidSdk use it for java related things

ea4bc2a

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 4, 2023

andrewkolos mentioned this pull request May 5, 2023

[tool] ☂️ Improve correctness, consistency, and maintainability of Java-finding logic across the tool #126126

Closed

3 tasks

fix tests

6654a91

andrewkolos force-pushed the move-java-functions-simple branch from 2e3dcb3 to 6654a91 Compare May 5, 2023 04:16

andrewkolos added 2 commits May 4, 2023 21:57

fix test

b592b88

make java global

fc34192

andrewkolos force-pushed the move-java-functions-simple branch from 7eeffa5 to fc34192 Compare May 5, 2023 06:05

andrewkolos added 2 commits May 4, 2023 23:13

oops

42c5992

lint

f6320c9

flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label May 5, 2023

andrewkolos added 2 commits May 5, 2023 00:19

add todo docs

0d75603

analyzer lint

6576e71

andrewkolos requested a review from christopherfujino May 5, 2023 17:53

andrewkolos marked this pull request as ready for review May 5, 2023 17:53