Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix platformLocation path and search dropping #126232

Merged
merged 1 commit into from May 9, 2023
Merged

Fix platformLocation path and search dropping #126232

merged 1 commit into from May 9, 2023

Conversation

Bungeefan
Copy link
Contributor

This PR fixes the dropping of both the path and search fields from the platform location in the URL when using Flutter Web and brings it in par with similar technologies (e.g. React Router).
It allows developers to keep the original path and/or search parameters in the URL, which are perfectly valid even while fragment routing is present.

Example use case:
Call a Flutter Web app with initial config parameters in the URL:
http://my-flutter.app/?skipIntro=true

Example:
Before initial routing:
http://localhost:45389/?foo=bar
After routing:
http://localhost:45389/#/menu
After routing (with fix):
http://localhost:45389/?foo=bar#menu

Fixes #116415

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@goderbauer goderbauer added the platform-web Web applications specifically label May 8, 2023
@goderbauer goderbauer requested a review from mdebbar May 8, 2023 08:22
mdebbar
mdebbar approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

kevmoo
kevmoo approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for helping here!

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label May 9, 2023
@auto-submit auto-submit bot merged commit cab29b2 into flutter:master May 9, 2023
54 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
cab29b203 Fix platformLocation path and search dropping (flutter/flut…
5f85ed0 
…ter#126232)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 10, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
cab29b203 Fix platformLocation path and search dropping (flutter/flut…
72aa9fc 
…ter#126232)
camsim99 pushed a commit to flutter/packages that referenced this pull request May 12, 2023
@engine-flutter-autoroll
Roll Flutter from 8c5a1ea7281a to a76dbe44b99e (12 revisions) (#3958)
cabd7ea 
flutter/flutter@8c5a1ea...a76dbe4

2023-05-10 engine-flutter-autoroll@skia.org Manual roll Flutter Engine
from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392)
2023-05-10 stuartmorgan@google.com Roll flutter/packages to 0167d83
(flutter/flutter#126427)
2023-05-10 54558023+keyonghan@users.noreply.github.com Migrate gallery
ios tests to build+test (flutter/flutter#111164)
2023-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from
824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360)
2023-05-09 kevinjchisholm@google.com Revert "Provide default constraints
for M3 dialogs" (flutter/flutter#126355)
2023-05-09 engine-flutter-autoroll@skia.org Roll Packages from
4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352)
2023-05-09 chillers@google.com [github] Add labeler action
(flutter/flutter#126012)
2023-05-09 severin.hamader@yahoo.de Fix platformLocation path and search
dropping (flutter/flutter#126232)
2023-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from
8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309)
2023-05-09 leroux_bruno@yahoo.fr Update FocusNode documentation
(flutter/flutter#126331)
2023-05-09 goderbauer@google.com Remove dead code
(flutter/flutter#126266)
2023-05-09 44755140+werainkhatri@users.noreply.github.com fix AppBar's
docs for backgroundColor (flutter/flutter#126194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll @nploi
Roll Flutter from 8c5a1ea7281a to a76dbe44b99e (12 revisions) (flutte…
a1ec68f 
…r#3958)

flutter/flutter@8c5a1ea...a76dbe4

2023-05-10 engine-flutter-autoroll@skia.org Manual roll Flutter Engine
from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392)
2023-05-10 stuartmorgan@google.com Roll flutter/packages to 0167d83
(flutter/flutter#126427)
2023-05-10 54558023+keyonghan@users.noreply.github.com Migrate gallery
ios tests to build+test (flutter/flutter#111164)
2023-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from
824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360)
2023-05-09 kevinjchisholm@google.com Revert "Provide default constraints
for M3 dialogs" (flutter/flutter#126355)
2023-05-09 engine-flutter-autoroll@skia.org Roll Packages from
4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352)
2023-05-09 chillers@google.com [github] Add labeler action
(flutter/flutter#126012)
2023-05-09 severin.hamader@yahoo.de Fix platformLocation path and search
dropping (flutter/flutter#126232)
2023-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from
8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309)
2023-05-09 leroux_bruno@yahoo.fr Update FocusNode documentation
(flutter/flutter#126331)
2023-05-09 goderbauer@google.com Remove dead code
(flutter/flutter#126266)
2023-05-09 44755140+werainkhatri@users.noreply.github.com fix AppBar's
docs for backgroundColor (flutter/flutter#126194)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
cab29b203 Fix platformLocation path and search dropping (flutter/flut…
0ec2d11 
…ter#126232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
cab29b203 Fix platformLocation path and search dropping (flutter/flut…
8dbbe46 
…ter#126232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
cab29b203 Fix platformLocation path and search dropping (flutter/flut…
7cab4e6 
…ter#126232)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
cab29b203 Fix platformLocation path and search dropping (flutter/flut…
f8281f8 
…ter#126232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevmoo kevmoo kevmoo approved these changes

@mdebbar mdebbar mdebbar approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Web applications specifically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flutter_web_plugins] HashUrlStrategy drops/overwrites query parameters
4 participants
@Bungeefan @kevmoo @mdebbar @goderbauer