New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code #126266
Merged
Merged
Remove dead code #126266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: internationalization
Supporting other languages or locales. (aka i18n)
a: text input
Entering text in a text field or keyboard related problems
d: api docs
Issues with https://api.flutter.dev/
d: examples
Sample code and demos
documentation
f: gestures
flutter/packages/flutter/gestures repository.
f: material design
flutter/packages/flutter/material repository.
f: scrolling
Viewports, list views, slivers, etc.
framework
flutter/packages/flutter repository. See also f: labels.
team
Infra upgrades, team productivity, code health, technical debt. See also team: labels.
labels
May 8, 2023
@srawlins |
I know I love it 😁 I think it needs one more check before I call it stable. |
gspencergoog
approved these changes
May 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goderbauer
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
May 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
camsim99
pushed a commit
to flutter/packages
that referenced
this pull request
May 12, 2023
flutter/flutter@8c5a1ea...a76dbe4 2023-05-10 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392) 2023-05-10 stuartmorgan@google.com Roll flutter/packages to 0167d83 (flutter/flutter#126427) 2023-05-10 54558023+keyonghan@users.noreply.github.com Migrate gallery ios tests to build+test (flutter/flutter#111164) 2023-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360) 2023-05-09 kevinjchisholm@google.com Revert "Provide default constraints for M3 dialogs" (flutter/flutter#126355) 2023-05-09 engine-flutter-autoroll@skia.org Roll Packages from 4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352) 2023-05-09 chillers@google.com [github] Add labeler action (flutter/flutter#126012) 2023-05-09 severin.hamader@yahoo.de Fix platformLocation path and search dropping (flutter/flutter#126232) 2023-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309) 2023-05-09 leroux_bruno@yahoo.fr Update FocusNode documentation (flutter/flutter#126331) 2023-05-09 goderbauer@google.com Remove dead code (flutter/flutter#126266) 2023-05-09 44755140+werainkhatri@users.noreply.github.com fix AppBar's docs for backgroundColor (flutter/flutter#126194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…r#3958) flutter/flutter@8c5a1ea...a76dbe4 2023-05-10 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (flutter/flutter#126392) 2023-05-10 stuartmorgan@google.com Roll flutter/packages to 0167d83 (flutter/flutter#126427) 2023-05-10 54558023+keyonghan@users.noreply.github.com Migrate gallery ios tests to build+test (flutter/flutter#111164) 2023-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 824cd09b8c62 to 8ca16cba8c38 (5 revisions) (flutter/flutter#126360) 2023-05-09 kevinjchisholm@google.com Revert "Provide default constraints for M3 dialogs" (flutter/flutter#126355) 2023-05-09 engine-flutter-autoroll@skia.org Roll Packages from 4800d65 to 1f91710 (8 revisions) (flutter/flutter#126352) 2023-05-09 chillers@google.com [github] Add labeler action (flutter/flutter#126012) 2023-05-09 severin.hamader@yahoo.de Fix platformLocation path and search dropping (flutter/flutter#126232) 2023-05-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8d3a8162b3ab to 824cd09b8c62 (10 revisions) (flutter/flutter#126309) 2023-05-09 leroux_bruno@yahoo.fr Update FocusNode documentation (flutter/flutter#126331) 2023-05-09 goderbauer@google.com Remove dead code (flutter/flutter#126266) 2023-05-09 44755140+werainkhatri@users.noreply.github.com fix AppBar's docs for backgroundColor (flutter/flutter#126194) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a: internationalization
Supporting other languages or locales. (aka i18n)
a: text input
Entering text in a text field or keyboard related problems
autosubmit
Merge PR when tree becomes green via auto submit App
d: api docs
Issues with https://api.flutter.dev/
d: examples
Sample code and demos
f: gestures
flutter/packages/flutter/gestures repository.
f: material design
flutter/packages/flutter/material repository.
f: scrolling
Viewports, list views, slivers, etc.
framework
flutter/packages/flutter repository. See also f: labels.
team
Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dead code was flagged by
unreachable_from_main
lint, which is still experimental and not ready to be enabled yet.