Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Replace rsync when unzipping artifacts on a Mac (#126703)" #127430

Merged
merged 1 commit into from May 24, 2023
Merged

Revert "Replace rsync when unzipping artifacts on a Mac (#126703)" #127430

merged 1 commit into from May 24, 2023

Conversation

vashworth
Copy link
Contributor

This reverts commit 2b3cd7f.

Fixes #127281.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 23, 2023
christopherfujino
christopherfujino approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth mentioned this pull request May 23, 2023
Closed
8 tasks
@dnfield
Copy link
Contributor

dnfield commented May 23, 2023

Does this need a cherry pick into stable?

@christopherfujino
Copy link
Member

Does this need a cherry pick into stable?

Nope, this never landed in a release

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2023
@christopherfujino christopherfujino mentioned this pull request May 24, 2023
Closed
2 tasks
@auto-submit auto-submit bot merged commit 555326b into flutter:master May 24, 2023
124 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
8a6e983 
…26703)" (flutter/flutter#127430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
fc0b2bd 
…26703)" (flutter/flutter#127430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
8234b69 
…26703)" (flutter/flutter#127430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
40a63e5 
…26703)" (flutter/flutter#127430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
0804a8c 
…26703)" (flutter/flutter#127430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
f650093 
…26703)" (flutter/flutter#127430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
a546683 
…26703)" (flutter/flutter#127430)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
0e04dd9 
…26703)" (flutter/flutter#127430)
@reidbaker reidbaker mentioned this pull request May 25, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
86856ad 
…26703)" (flutter/flutter#127430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
aaa9892 
…26703)" (flutter/flutter#127430)
@reidbaker reidbaker mentioned this pull request May 26, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
08c45c1 
…26703)" (flutter/flutter#127430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
d4a73dd 
…26703)" (flutter/flutter#127430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
dbbf02f 
…26703)" (flutter/flutter#127430)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
555326b22 Revert "Replace rsync when unzipping artifacts on a Mac (#1…
c9a32c9 
…26703)" (flutter/flutter#127430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not find package sky_engine in the Flutter SDK (MacOS)
3 participants
@vashworth @dnfield @christopherfujino