Fix dart pub cache clean command on pub.dart #128171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
tool
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This will need a test; looks like this is similar to #128037 if you would like to pool resources with other contributors! |
|
hi @Hixie , I've added the test for that. Feel free to merge and we could mention this PR as part of the other PRs which contribute to fix similar issue |
christopherfujino
approved these changes
Jun 15, 2023
andrewkolos
added
the
autosubmit
8 tasks
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 16, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 16, 2023
flutter/flutter@b0188cd...fc8856e 2023-06-16 mdebbar@google.com [web] Don't crash on `const HtmlElementView()` (flutter/flutter#128965) 2023-06-16 engine-flutter-autoroll@skia.org Roll Packages from 0507297 to f9314a3 (3 revisions) (flutter/flutter#128878) 2023-06-16 polinach@google.com Update getProperties to handle Diagnosticable as input. (flutter/flutter#128897) 2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48e0b4e66422 to fb5fed432e59 (1 revision) (flutter/flutter#128967) 2023-06-15 dery.ra@gmail.com Fix dart pub cache clean command on pub.dart (flutter/flutter#128171) 2023-06-15 christopherfujino@gmail.com [flutter_tools] Migrate more integration tests to process result matcher (flutter/flutter#128737) 2023-06-15 christopherfujino@gmail.com [flutter_tools] refactor license collector (flutter/flutter#128748) 2023-06-15 36861262+QuncCccccc@users.noreply.github.com Set Semantics.button to true for date widget (flutter/flutter#128824) 2023-06-15 36861262+QuncCccccc@users.noreply.github.com Update golden tests (flutter/flutter#128914) 2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) (flutter/flutter#128959) 2023-06-15 ian@hixie.ch flutter update-packages --cherry-pick-package (flutter/flutter#128917) 2023-06-15 christopherfujino@gmail.com add .pub-cache back to .gitignore (flutter/flutter#128894) 2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d8d5ecfe4a8 to 9934c0de738c (2 revisions) (flutter/flutter#128849) 2023-06-15 mdebbar@google.com flutter update-packages --force-upgrade (flutter/flutter#128908) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command instruction for clearing dart pub cache is somewhat wrong. Instead of
clear,cleanis the correct one. Ref: https://dart.dev/tools/pub/cmd/pub-cacheFixes #128663
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
(Edited by @andrewkolos. Changed "related to" issue to "fixes" to link this PR to the issue).