Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] Migrate more integration tests to process result matcher #128737

Conversation

christopherfujino
Copy link
Member

@christopherfujino christopherfujino commented Jun 12, 2023

Part of #127135

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 12, 2023
@christopherfujino christopherfujino changed the title [flutter_tools] Migrate remaining integration tests to process result matcher [flutter_tools] Migrate more integration tests to process result matcher Jun 12, 2023
@christopherfujino christopherfujino marked this pull request as ready for review June 12, 2023 22:33
Copy link
Contributor

@eliasyishak eliasyishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 13, 2023
@christopherfujino
Copy link
Member Author

Merging manually this as everything is green and autosubmit has not merged in 2 days

@christopherfujino christopherfujino merged commit cc83f03 into flutter:master Jun 15, 2023
124 checks passed
@christopherfujino christopherfujino deleted the migrate-integration-tests-to-process-result-matcher branch June 15, 2023 20:26
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 16, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 16, 2023
flutter/flutter@b0188cd...fc8856e

2023-06-16 mdebbar@google.com [web] Don't crash on `const HtmlElementView()` (flutter/flutter#128965)
2023-06-16 engine-flutter-autoroll@skia.org Roll Packages from 0507297 to f9314a3 (3 revisions) (flutter/flutter#128878)
2023-06-16 polinach@google.com Update getProperties to handle Diagnosticable as input. (flutter/flutter#128897)
2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48e0b4e66422 to fb5fed432e59 (1 revision) (flutter/flutter#128967)
2023-06-15 dery.ra@gmail.com Fix dart pub cache clean command on pub.dart (flutter/flutter#128171)
2023-06-15 christopherfujino@gmail.com [flutter_tools] Migrate more integration tests to process result matcher (flutter/flutter#128737)
2023-06-15 christopherfujino@gmail.com [flutter_tools] refactor license collector (flutter/flutter#128748)
2023-06-15 36861262+QuncCccccc@users.noreply.github.com Set Semantics.button to true for date widget (flutter/flutter#128824)
2023-06-15 36861262+QuncCccccc@users.noreply.github.com Update golden tests (flutter/flutter#128914)
2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) (flutter/flutter#128959)
2023-06-15 ian@hixie.ch flutter update-packages --cherry-pick-package (flutter/flutter#128917)
2023-06-15 christopherfujino@gmail.com add .pub-cache back to .gitignore (flutter/flutter#128894)
2023-06-15 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2d8d5ecfe4a8 to 9934c0de738c (2 revisions) (flutter/flutter#128849)
2023-06-15 mdebbar@google.com flutter update-packages --force-upgrade (flutter/flutter#128908)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants