Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal #128335

Merged
merged 4 commits into from Jun 9, 2023
Merged

[testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal #128335

merged 4 commits into from Jun 9, 2023

Conversation

whesse
Copy link
Contributor

@whesse whesse commented Jun 6, 2023 •
edited

Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location.

This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.

Bug: #127683

Pre-launch Checklist

  • [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • [X ] I signed the [CLA].
  • [X ] I listed at least one issue that this PR fixes in the description above.
  • [X ] I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@whesse
[testing] Add an option to make FLUTTER_STORAGE_BASE_URL warning non-…
2f3d23e 
…fatal.

Presubmit testing and CI testing of Flutter using a custom
storage location for engine artifacts must be able to use
the --fatal-warnings flag without failing due to the custom
artifact location.

This change adds an option that makes this warning non-fatal.
The new --no-fatal-storage-url-warning flag makes the --fatal-warnings
flag ignore the warning that a custom artifact download URL is
being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.

Bug: flutter#127683
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 6, 2023
@whesse whesse mentioned this pull request Jun 6, 2023
Closed
@christopherfujino
Copy link
Member

Could you add a test to https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/runner/flutter_command_test.dart that verifies adding the flag at the top level successfully modifies the Cache.fatalStorageWarning field?

@whesse
Copy link
Contributor Author

whesse commented Jun 7, 2023

Yes, will add the test. Are you saying that we should use this approach, with a flag, and drop the other PR that unconditionally suppresses the failure?

@christopherfujino
Copy link
Member

christopherfujino commented Jun 7, 2023 •
edited

Yes, will add the test. Are you saying that we should use this approach, with a flag, and drop the other PR that unconditionally suppresses the failure?

Yes please :)

Actually, in thinking more about this, can we use this PR but remove the top level flag, and instead use the new parameter bool fatal on Logger.printWarning(). We could then hard-code the storage url warning to be non-fatal.

I feel like this would give us the most flexibility in the future to mark other warnings non-fatal.

@whesse
[testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal.
e38f5ea 
Presubmit testing and CI testing of Flutter using a custom
storage location for engine artifacts must be able to use
the --fatal-warnings flag without failing due to the custom
artifact location.

This change makes this warning always non-fatal.

Bug: flutter#127683
@whesse
Remove changes to flutter_command.dart that added the new flag.
04d5d45
@whesse whesse mentioned this pull request Jun 8, 2023
Closed
8 tasks
@whesse whesse changed the title [testing] Add an option to make FLUTTER_STORAGE_BASE_URL warning non-fatal [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal Jun 8, 2023
@whesse
Copy link
Contributor Author

whesse commented Jun 8, 2023

Removed the top-level option, as suggested. There is no longer a top-level option to test.

christopherfujino
christopherfujino approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whesse whesse added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 9, 2023

auto label is removed for flutter/flutter, pr: 128335, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@whesse whesse added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2023
@auto-submit auto-submit bot merged commit 0d39f64 into flutter:master Jun 9, 2023
125 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
0d39f6466 [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fat…
7139f76 
…al (flutter/flutter#128335)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
Roll Flutter from 6e254a3f9fb7 to da127f15ad54 (28 revisions) (#4170)
914d120 
flutter/flutter@6e254a3...da127f1

2023-06-09 hans.muller@gmail.com Updated material button theme tests for Material3 (flutter/flutter#128543)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from cb93477008d6 to 93afba901b3b (2 revisions) (flutter/flutter#128573)
2023-06-09 6655696+guidezpl@users.noreply.github.com Improve defaults generation with logging, stats, and token validation (flutter/flutter#128244)
2023-06-09 whesse@google.com [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (flutter/flutter#128335)
2023-06-09 danny@tuppeny.com [flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet (flutter/flutter#128267)
2023-06-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8f9e608d39ab to cb93477008d6 (3 revisions) (flutter/flutter#128568)
2023-06-09 tessertaha@gmail.com Replace `MaterialButton` from test classes (flutter/flutter#128466)
2023-06-09 tessertaha@gmail.com Fix `showBottomSheet` doesn't remove scrim when draggable sheet is dismissed (flutter/flutter#128455)
2023-06-09 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) (flutter/flutter#128554)
2023-06-09 ychris@google.com Revert "test owners: cyanglaz -> vashworth" (flutter/flutter#128462)
2023-06-09 43054281+camsim99@users.noreply.github.com [Android] Bump integration tests using `compileSdkVersion` 31 to 33 (flutter/flutter#128072)
2023-06-09 dkwingsmt@users.noreply.github.com Remove single view assumption from MouseTracker, and unify its hit testing code flow (flutter/flutter#127060)
2023-06-09 christopherfujino@gmail.com [flutter_tools] Precache after channel switch (flutter/flutter#118129)
2023-06-08 leigha.jarett@gmail.com Adding migration guide for Material 3 colors (flutter/flutter#128429)
2023-06-08 gspencergoog@users.noreply.github.com Add `AppLifecycleListener`, with support for application exit handling (flutter/flutter#123274)
2023-06-08 thkim1011@users.noreply.github.com Sliver Main Axis Group (flutter/flutter#126596)
2023-06-08 31859944+LongCatIsLooong@users.noreply.github.com Reduce `_DoubleClampVisitor` false positives (flutter/flutter#128539)
2023-06-08 leigha.jarett@gmail.com Advise developers to use OverflowBar instead of ButtonBar (flutter/flutter#128437)
2023-06-08 jacksongardner@google.com Reland "Migrate benchmarks to package:web" (flutter/flutter#128266)
2023-06-08 53684884+mhbdev@users.noreply.github.com Navigator.pop before PopupMenuItem onTap call (flutter/flutter#127446)
2023-06-08 leroux_bruno@yahoo.fr Fix navigation rail with long labels misplaced highlights (flutter/flutter#128324)
2023-06-08 tessertaha@gmail.com Update `chip.dart` to use set of `MaterialState` (flutter/flutter#128507)
2023-06-08 jcollins@google.com Update flutter to dartdoc 6.3.0 and hide Icons implementation from doc pages (flutter/flutter#128442)
2023-06-08 31859944+LongCatIsLooong@users.noreply.github.com Disable blinking cursor when `EditableText.showCursor` is false (flutter/flutter#127562)
2023-06-08 41930132+hellohuanlin@users.noreply.github.com [floating_cursor_selection]add more comments on the tricky part (flutter/flutter#127227)
2023-06-08 goderbauer@google.com Move RenderObjectElement.updateChildren to Element (flutter/flutter#128458)
2023-06-08 goderbauer@google.com Fix PointerEventConverter doc (flutter/flutter#128452)
2023-06-08 engine-flutter-autoroll@skia.org Roll Packages from a84b2c2 to e13b8c4 (9 revisions) (flutter/flutter#128508)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
0d39f6466 [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fat…
b785bac 
…al (flutter/flutter#128335)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0d39f6466 [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fat…
60ce6f0 
…al (flutter/flutter#128335)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0d39f6466 [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fat…
96b173d 
…al (flutter/flutter#128335)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
0d39f6466 [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fat…
234a1f6 
…al (flutter/flutter#128335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@godofredoc godofredoc Awaiting requested review from godofredoc

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whesse @christopherfujino