Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal #128335

Merged
merged 4 commits into from
Jun 9, 2023
Merged

[testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal #128335

merged 4 commits into from
Jun 9, 2023

Commits on Jun 6, 2023

  1. [testing] Add an option to make FLUTTER_STORAGE_BASE_URL warning non-… 

    …fatal.

Presubmit testing and CI testing of Flutter using a custom
storage location for engine artifacts must be able to use
the --fatal-warnings flag without failing due to the custom
artifact location.

This change adds an option that makes this warning non-fatal.
The new --no-fatal-storage-url-warning flag makes the --fatal-warnings
flag ignore the warning that a custom artifact download URL is
being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.

Bug: flutter#127683
    @whesse
    whesse committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    2f3d23e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal. 

    Presubmit testing and CI testing of Flutter using a custom
storage location for engine artifacts must be able to use
the --fatal-warnings flag without failing due to the custom
artifact location.

This change makes this warning always non-fatal.

Bug: flutter#127683
    @whesse
    whesse committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    e38f5ea View commit details
    Browse the repository at this point in the history

  2. Remove changes to flutter_command.dart that added the new flag.

    @whesse
    whesse committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    04d5d45 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Merge branch 'flutter:master' into conditional-warning

    @whesse
    whesse committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    62262eb View commit details
    Browse the repository at this point in the history