make integration_test_driver_extended.dart support writeResponseData--(done) #128382

linchen2chris · 2023-06-07T06:08:44Z

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

integration_test_driver and integration_test_driver_extended #128381

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-06-07T06:08:48Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

google-cla · 2023-06-07T06:08:49Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

goderbauer · 2023-06-13T22:13:45Z

(fly-by comment from triage) @linchen2chris It looks like some checks are failing. Can you look at those and make them green? Also, it looks like this PR is missing tests. Please add some!

flutter-dashboard · 2023-07-03T22:18:15Z

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

goderbauer · 2023-07-11T22:11:59Z

@linchen2chris Do you have plans to update this PR soon-ish (see previous comment) to bring it into a state where it can be reviewed?

linchen2chris · 2023-07-12T02:22:57Z

@linchen2chris Do you have plans to update this PR soon-ish (see previous comment) to bring it into a state where it can be reviewed?

oh yes, I will find the time to update it this or next week soon

linchen2chris · 2023-07-18T10:53:41Z

@linchen2chris Do you have plans to update this PR soon-ish (see previous comment) to bring it into a state where it can be reviewed?

hi @goderbauer , I have update the PR and all chechers are green now, would you please give it a review by any chance? thanks in advance.

pdblasi-google

LGTM.

I didn't realize at first that this was basically just adding existing functionality from integration_test_driver.dart into integration_test_driver_extended.dart. This seems to mirror the existing behavior well, so all good here.

goderbauer

This PR is also still missing tests. See the message the bot posted. Please add some.

packages/integration_test/lib/integration_test_driver_extended.dart

packages/integration_test/lib/integration_test_driver.dart

packages/integration_test/lib/integration_test_driver_extended.dart

packages/integration_test/test/integration_test_driver_extended_test.dart

goderbauer

LGTM

packages/integration_test/lib/integration_test_driver.dart

packages/integration_test/lib/integration_test_driver_extended.dart

goderbauer

LGTM

dev/bots/test.dart

Co-authored-by: Michael Goderbauer <goderbauer@google.com>

cbracken

lgtm!

Piinks · 2023-10-17T22:16:03Z

Hey @linchen2chris thanks for contributing! This should get merged now. :)

…ponseData--(done) (flutter/flutter#128382)

…5178) Manual roll Flutter from 6eea6e277e56 to 189196d104e2 (44 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@6eea6e2...189196d 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from ab86c53c19cd to 6caee3236d37 (2 revisions) (flutter/flutter#136834) 2023-10-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" (flutter/flutter#136839) 2023-10-18 gspencergoog@users.noreply.github.com Convert menus to use OverlayPortal (flutter/flutter#130534) 2023-10-18 15619084+vashworth@users.noreply.github.com [Reland] Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136751) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0eff5d191856 to ab86c53c19cd (1 revision) (flutter/flutter#136832) 2023-10-18 47866232+chunhtai@users.noreply.github.com Fixes ability to call nextFocus() on a node to focus its descendant (flutter/flutter#136773) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b778a07f8ae9 to 0eff5d191856 (6 revisions) (flutter/flutter#136829) 2023-10-18 robert.ancell@canonical.com Implement GApplication:shutdown so a Flutter developer knows where to put code that should occur on application shutdown. (flutter/flutter#136780) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f37c9b181af to b778a07f8ae9 (1 revision) (flutter/flutter#136818) 2023-10-18 tessertaha@gmail.com Fix `Slider` `onChanged` callback order & never calls `onChangeStart` on `SliderInteraction.slideOnly` allowed interaction (flutter/flutter#136720) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78026b4003fe to 7f37c9b181af (1 revision) (flutter/flutter#136817) 2023-10-18 838@mail.com [Feat] Stroke color for Slider value indicator (flutter/flutter#135986) 2023-10-18 76067278+aakash-pamnani@users.noreply.github.com Fixed : Empty Rows shown at last page in Paginated data table (flutter/flutter#132646) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46923fd39032 to 78026b4003fe (1 revision) (flutter/flutter#136814) 2023-10-18 engine-flutter-autoroll@skia.org Roll Packages from d439062 to 14aa69e (1 revision) (flutter/flutter#136813) 2023-10-18 dacoharkes@google.com Don't build native assets in `flutter build bundle` (flutter/flutter#136641) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9c9684e03a3 to 46923fd39032 (1 revision) (flutter/flutter#136795) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c1c29271e8b to c9c9684e03a3 (1 revision) (flutter/flutter#136792) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1de09d13e708 to 0c1c29271e8b (3 revisions) (flutter/flutter#136789) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6fc36e61a99a to 1de09d13e708 (1 revision) (flutter/flutter#136785) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f818efff3c5 to 6fc36e61a99a (1 revision) (flutter/flutter#136781) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2eef9b43cfb4 to 3f818efff3c5 (3 revisions) (flutter/flutter#136777) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5df7af34a718 to 2eef9b43cfb4 (4 revisions) (flutter/flutter#136774) 2023-10-18 christopherfujino@gmail.com Flutter preview device (flutter/flutter#135639) 2023-10-18 gildasiogx@gmail.com Add findChildIndexCallback examples (flutter/flutter#133469) 2023-10-18 109253501+pdblasi-google@users.noreply.github.com Adds API for performing semantics actions in tests (flutter/flutter#132598) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from e57b5bac4244 to 5df7af34a718 (2 revisions) (flutter/flutter#136772) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9f937e51080 to e57b5bac4244 (3 revisions) (flutter/flutter#136768) 2023-10-17 andrewrkolos@gmail.com clean up `--dart-define-from-file` option tests (flutter/flutter#135980) 2023-10-17 sokolovskyi.konstantin@gmail.com GoldenFileComparators should dispose created Image objects. (flutter/flutter#136716) 2023-10-17 lc1990linux@gmail.com make integration_test_driver_extended.dart support writeResponseData--(done) (flutter/flutter#128382) 2023-10-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.1.1 (flutter/flutter#136762) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 289f29b1ad00 to f9f937e51080 (1 revision) (flutter/flutter#136755) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 659e68a097b5 to 289f29b1ad00 (1 revision) (flutter/flutter#136752) 2023-10-17 aran@arandonohue.com Support --web-header option for flutter run (flutter/flutter#136297) 2023-10-17 34871572+gmackall@users.noreply.github.com Add Android 14 physical devices to firebase tests (flutter/flutter#136736) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62a90a91cee3 to 659e68a097b5 (3 revisions) (flutter/flutter#136746) 2023-10-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Skip injecting Bonjour settings when port publication is disabled" (flutter/flutter#136750) 2023-10-17 katelovett@google.com Revert "[SingleChildScrollView] Correct the offset pixels if it is out of range during layout" (flutter/flutter#136744) 2023-10-17 15619084+vashworth@users.noreply.github.com Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136562) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3ecbe924a598 to 62a90a91cee3 (2 revisions) (flutter/flutter#136739) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a4d8b99a95b to 3ecbe924a598 (3 revisions) (flutter/flutter#136732) 2023-10-17 32242716+ricardoamador@users.noreply.github.com Reenable NexusLowRes API 29 (flutter/flutter#136686) 2023-10-17 32242716+ricardoamador@users.noreply.github.com Reenable the nexus 6p tests (flutter/flutter#136689) ...

…lutter#5178) Manual roll Flutter from 6eea6e277e56 to 189196d104e2 (44 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@6eea6e2...189196d 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from ab86c53c19cd to 6caee3236d37 (2 revisions) (flutter/flutter#136834) 2023-10-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Reland] Skip injecting Bonjour settings when port publication is disabled" (flutter/flutter#136839) 2023-10-18 gspencergoog@users.noreply.github.com Convert menus to use OverlayPortal (flutter/flutter#130534) 2023-10-18 15619084+vashworth@users.noreply.github.com [Reland] Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136751) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0eff5d191856 to ab86c53c19cd (1 revision) (flutter/flutter#136832) 2023-10-18 47866232+chunhtai@users.noreply.github.com Fixes ability to call nextFocus() on a node to focus its descendant (flutter/flutter#136773) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from b778a07f8ae9 to 0eff5d191856 (6 revisions) (flutter/flutter#136829) 2023-10-18 robert.ancell@canonical.com Implement GApplication:shutdown so a Flutter developer knows where to put code that should occur on application shutdown. (flutter/flutter#136780) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7f37c9b181af to b778a07f8ae9 (1 revision) (flutter/flutter#136818) 2023-10-18 tessertaha@gmail.com Fix `Slider` `onChanged` callback order & never calls `onChangeStart` on `SliderInteraction.slideOnly` allowed interaction (flutter/flutter#136720) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 78026b4003fe to 7f37c9b181af (1 revision) (flutter/flutter#136817) 2023-10-18 838@mail.com [Feat] Stroke color for Slider value indicator (flutter/flutter#135986) 2023-10-18 76067278+aakash-pamnani@users.noreply.github.com Fixed : Empty Rows shown at last page in Paginated data table (flutter/flutter#132646) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 46923fd39032 to 78026b4003fe (1 revision) (flutter/flutter#136814) 2023-10-18 engine-flutter-autoroll@skia.org Roll Packages from d439062 to 14aa69e (1 revision) (flutter/flutter#136813) 2023-10-18 dacoharkes@google.com Don't build native assets in `flutter build bundle` (flutter/flutter#136641) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9c9684e03a3 to 46923fd39032 (1 revision) (flutter/flutter#136795) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0c1c29271e8b to c9c9684e03a3 (1 revision) (flutter/flutter#136792) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1de09d13e708 to 0c1c29271e8b (3 revisions) (flutter/flutter#136789) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6fc36e61a99a to 1de09d13e708 (1 revision) (flutter/flutter#136785) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f818efff3c5 to 6fc36e61a99a (1 revision) (flutter/flutter#136781) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2eef9b43cfb4 to 3f818efff3c5 (3 revisions) (flutter/flutter#136777) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5df7af34a718 to 2eef9b43cfb4 (4 revisions) (flutter/flutter#136774) 2023-10-18 christopherfujino@gmail.com Flutter preview device (flutter/flutter#135639) 2023-10-18 gildasiogx@gmail.com Add findChildIndexCallback examples (flutter/flutter#133469) 2023-10-18 109253501+pdblasi-google@users.noreply.github.com Adds API for performing semantics actions in tests (flutter/flutter#132598) 2023-10-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from e57b5bac4244 to 5df7af34a718 (2 revisions) (flutter/flutter#136772) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9f937e51080 to e57b5bac4244 (3 revisions) (flutter/flutter#136768) 2023-10-17 andrewrkolos@gmail.com clean up `--dart-define-from-file` option tests (flutter/flutter#135980) 2023-10-17 sokolovskyi.konstantin@gmail.com GoldenFileComparators should dispose created Image objects. (flutter/flutter#136716) 2023-10-17 lc1990linux@gmail.com make integration_test_driver_extended.dart support writeResponseData--(done) (flutter/flutter#128382) 2023-10-17 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.6.0 to 4.1.1 (flutter/flutter#136762) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 289f29b1ad00 to f9f937e51080 (1 revision) (flutter/flutter#136755) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 659e68a097b5 to 289f29b1ad00 (1 revision) (flutter/flutter#136752) 2023-10-17 aran@arandonohue.com Support --web-header option for flutter run (flutter/flutter#136297) 2023-10-17 34871572+gmackall@users.noreply.github.com Add Android 14 physical devices to firebase tests (flutter/flutter#136736) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 62a90a91cee3 to 659e68a097b5 (3 revisions) (flutter/flutter#136746) 2023-10-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Skip injecting Bonjour settings when port publication is disabled" (flutter/flutter#136750) 2023-10-17 katelovett@google.com Revert "[SingleChildScrollView] Correct the offset pixels if it is out of range during layout" (flutter/flutter#136744) 2023-10-17 15619084+vashworth@users.noreply.github.com Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136562) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3ecbe924a598 to 62a90a91cee3 (2 revisions) (flutter/flutter#136739) 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0a4d8b99a95b to 3ecbe924a598 (3 revisions) (flutter/flutter#136732) 2023-10-17 32242716+ricardoamador@users.noreply.github.com Reenable NexusLowRes API 29 (flutter/flutter#136686) 2023-10-17 32242716+ricardoamador@users.noreply.github.com Reenable the nexus 6p tests (flutter/flutter#136689) ...

flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin labels Jun 7, 2023

linchen2chris force-pushed the master branch from 5513f54 to e6d8ab7 Compare June 7, 2023 07:11

HansMuller requested a review from pdblasi-google June 9, 2023 21:49

linchen2chris force-pushed the master branch 2 times, most recently from b66d05a to 6bf235d Compare July 18, 2023 10:17

linchen2chris changed the title ~~make integration_test_driver_extended.dart support writeResponseData~~ make integration_test_driver_extended.dart support writeResponseData [updated] Jul 18, 2023

linchen2chris force-pushed the master branch 2 times, most recently from 4b83708 to 4512a37 Compare July 19, 2023 06:40

pdblasi-google approved these changes Jul 19, 2023

View reviewed changes

pdblasi-google requested a review from goderbauer July 19, 2023 20:35

goderbauer reviewed Jul 19, 2023

View reviewed changes

packages/integration_test/lib/integration_test_driver_extended.dart Outdated Show resolved Hide resolved

linchen2chris force-pushed the master branch from b815fea to b528e8f Compare July 21, 2023 01:58

linchen2chris changed the title ~~make integration_test_driver_extended.dart support writeResponseData [updated]~~ make integration_test_driver_extended.dart support writeResponseData--updated Jul 22, 2023

linchen2chris requested review from pdblasi-google and goderbauer July 22, 2023 10:38

goderbauer reviewed Jul 24, 2023

View reviewed changes

packages/integration_test/lib/integration_test_driver.dart Show resolved Hide resolved

packages/integration_test/lib/integration_test_driver_extended.dart Show resolved Hide resolved

packages/integration_test/test/integration_test_driver_extended_test.dart Outdated Show resolved Hide resolved

linchen2chris requested a review from goderbauer July 26, 2023 00:01

goderbauer approved these changes Jul 26, 2023

View reviewed changes

packages/integration_test/lib/integration_test_driver.dart Outdated Show resolved Hide resolved

packages/integration_test/lib/integration_test_driver_extended.dart Outdated Show resolved Hide resolved

linchen2chris changed the title ~~make integration_test_driver_extended.dart support writeResponseData--updated~~ make integration_test_driver_extended.dart support writeResponseData--updated Jul 26, 2023

linchen2chris changed the title ~~make integration_test_driver_extended.dart support writeResponseData--updated~~ make integration_test_driver_extended.dart support writeResponseData--[updated] Jul 26, 2023

linchen2chris added 2 commits July 26, 2023 23:08

make integration_test_driver_extended.dart support writeResponseData

eac002f

remove trail space

eb13f79

linchen2chris changed the title ~~make integration_test_driver_extended.dart support writeResponseData--（done)~~ make integration_test_driver_extended.dart support writeResponseData--(done) Sep 27, 2023

linchen2chris added 2 commits September 27, 2023 13:48

Merge branch 'master' into master

be5ca24

Merge branch 'master' into master

ed356e8

goderbauer approved these changes Oct 6, 2023

View reviewed changes

dev/bots/test.dart Outdated Show resolved Hide resolved

linchen2chris and others added 4 commits October 7, 2023 13:36

Update dev/bots/test.dart

b1cee87

Co-authored-by: Michael Goderbauer <goderbauer@google.com>

Merge branch 'master' into master

3e2b956

Merge branch 'master' into master

2f1a5a9

Merge branch 'master' into master

46dbd03

cbracken approved these changes Oct 9, 2023

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2023

auto-submit bot merged commit 3d1d453 into flutter:master Oct 17, 2023
133 checks passed

engine-flutter-autoroll mentioned this pull request Oct 18, 2023

Roll Flutter from 6eea6e277e56 to 402a5455d987 (29 revisions) flutter/packages#5168

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 18, 2023

3d1d4532b make integration_test_driver_extended.dart support writeRes…

f7ab8b6

…ponseData--(done) (flutter/flutter#128382)

engine-flutter-autoroll mentioned this pull request Oct 18, 2023

Roll Flutter from 6eea6e277e56 to 8e4292b14407 (31 revisions) flutter/packages#5169

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 18, 2023

3d1d4532b make integration_test_driver_extended.dart support writeRes…

35b77c5

…ponseData--(done) (flutter/flutter#128382)

engine-flutter-autoroll mentioned this pull request Oct 18, 2023

Roll Flutter from 6eea6e277e56 to d195d90dc6ff (34 revisions) flutter/packages#5170

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 18, 2023

3d1d4532b make integration_test_driver_extended.dart support writeRes…

d1922a9

…ponseData--(done) (flutter/flutter#128382)

engine-flutter-autoroll mentioned this pull request Oct 18, 2023

Roll Flutter from 6eea6e277e56 to 4f959b97a795 (35 revisions) flutter/packages#5171

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 18, 2023

3d1d4532b make integration_test_driver_extended.dart support writeRes…

1ed6b4b

…ponseData--(done) (flutter/flutter#128382)

engine-flutter-autoroll mentioned this pull request Oct 18, 2023

Roll Flutter from 6eea6e277e56 to fe9d9a9db3dd (37 revisions) flutter/packages#5172

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 18, 2023

3d1d4532b make integration_test_driver_extended.dart support writeRes…

5f6ae84

…ponseData--(done) (flutter/flutter#128382)

engine-flutter-autoroll mentioned this pull request Oct 18, 2023

Roll Flutter from 6eea6e277e56 to f847346d9c8e (38 revisions) flutter/packages#5175

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 18, 2023

3d1d4532b make integration_test_driver_extended.dart support writeRes…

f47f63b

…ponseData--(done) (flutter/flutter#128382)

engine-flutter-autoroll mentioned this pull request Oct 18, 2023

Manual roll Flutter from 6eea6e277e56 to 189196d104e2 (44 revisions) flutter/packages#5178

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 18, 2023

3d1d4532b make integration_test_driver_extended.dart support writeRes…

e8057df

…ponseData--(done) (flutter/flutter#128382)

yjbanov mentioned this pull request Apr 3, 2024

Linux web_long_running_tests_5_5 is 2.02% flaky #146189

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

make integration_test_driver_extended.dart support writeResponseData--(done) #128382

make integration_test_driver_extended.dart support writeResponseData--(done) #128382

linchen2chris commented Jun 7, 2023 •

edited

Loading

flutter-dashboard bot commented Jun 7, 2023

google-cla bot commented Jun 7, 2023

goderbauer commented Jun 13, 2023

flutter-dashboard bot commented Jul 3, 2023

goderbauer commented Jul 11, 2023

linchen2chris commented Jul 12, 2023

linchen2chris commented Jul 18, 2023 •

edited

Loading

pdblasi-google left a comment

goderbauer left a comment

goderbauer left a comment

goderbauer left a comment

cbracken left a comment

Piinks commented Oct 17, 2023

make integration_test_driver_extended.dart support writeResponseData--(done) #128382

make integration_test_driver_extended.dart support writeResponseData--(done) #128382

Conversation

linchen2chris commented Jun 7, 2023 • edited Loading

Pre-launch Checklist

flutter-dashboard bot commented Jun 7, 2023

google-cla bot commented Jun 7, 2023

goderbauer commented Jun 13, 2023

flutter-dashboard bot commented Jul 3, 2023

goderbauer commented Jul 11, 2023

linchen2chris commented Jul 12, 2023

linchen2chris commented Jul 18, 2023 • edited Loading

pdblasi-google left a comment

Choose a reason for hiding this comment

goderbauer left a comment

Choose a reason for hiding this comment

goderbauer left a comment

Choose a reason for hiding this comment

goderbauer left a comment

Choose a reason for hiding this comment

cbracken left a comment

Choose a reason for hiding this comment

Piinks commented Oct 17, 2023

linchen2chris commented Jun 7, 2023 •

edited

Loading

linchen2chris commented Jul 18, 2023 •

edited

Loading