-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linux web_long_running_tests_5_5 is 2.02% flaky #146189
Comments
Not sure what's going on yet, and whether this is related to #143834. |
Actually, most of the failures are related to #128382 (see this log file). The tests complete OK, but they complain about "Command did not write the response file but expected response file written". Reassigning to @linchen2chris for initial investigation. |
Looks like I cannot assign to @linchen2chris. So assigning to the first reviewer listed in the PR. @cbracken you drew the short straw :) |
Unassigning since this is one of the web-tests and the issue seems to be related to flutter driver, which which I'm not familiar. Looking at the PR I suspect I was the second required approver. Do we just need someone to revert that patch? |
Looking quickly at the output and code, it looks like:
That logic seems correct to me. @yjbanov what makes you think the file is definitely being written (and written on time)? |
[prod pool] flaky ratio for the past (up to) 100 commits between 2024-04-03 and 2024-04-09 is 3.19%. Flaky number: 3; total number: 94. Recent test runs: |
I actually don't know if it's being written. I also don't know what this file is and why it needs to be written. For now, I'm inclined to revert the change that expects it. |
[prod pool] flaky ratio for the past (up to) 100 commits between 2024-04-08 and 2024-04-16 is 2.04%. Flaky number: 2; total number: 98. Recent test runs: |
Just came across the dashboard and noticed the flaky percentage (11 out recent 50 runs are flaky) continues high: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16274/infra |
@keyonghan Yes, all the "web_long_running_tests" failures seem to have the same cause. |
[prod pool] flaky ratio for the past (up to) 100 commits between 2024-04-23 and 2024-04-30 is 3.03%. Flaky number: 3; total number: 99. Recent test runs: |
This functionality is already fully covered by https://github.com/flutter/engine/blob/main/lib/web_ui/test/engine/platform_views/message_handler_test.dart This might help with #146189 a little.
This may be the culprit, which I think is what @eyebrowsoffire already suspected:
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
The post-submit test builder
Linux web_long_running_tests_5_5
had a flaky ratio 2.02% for the past (up to) 100 commits, which is above our 2.00% threshold.One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/15903,%2015902
Commit: 0ee2592
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/15903
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/15902
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/15852
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/15851
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/15850
Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Linux%20web_long_running_tests_5_5
Please follow https://github.com/flutter/flutter/wiki/Reducing-Test-Flakiness#fixing-flaky-tests to fix the flakiness and enable the test back after validating the fix (internal dashboard to validate: go/flutter_test_flakiness).
The text was updated successfully, but these errors were encountered: