Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux web_long_running_tests_5_5 is 2.02% flaky #146189

Closed
fluttergithubbot opened this issue Apr 3, 2024 · 14 comments · Fixed by #147736
Closed

Linux web_long_running_tests_5_5 is 2.02% flaky #146189

fluttergithubbot opened this issue Apr 3, 2024 · 14 comments · Fixed by #147736
Assignees
Labels
c: flake Tests that sometimes, but not always, incorrectly pass P0 Critical issues such as a build break or regression platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@fluttergithubbot
Copy link
Contributor

@fluttergithubbot fluttergithubbot added c: flake Tests that sometimes, but not always, incorrectly pass P0 Critical issues such as a build break or regression team-web Owned by Web platform team labels Apr 3, 2024
@yjbanov yjbanov added platform-web Web applications specifically triaged-web Triaged by Web platform team labels Apr 3, 2024
@yjbanov
Copy link
Contributor

yjbanov commented Apr 3, 2024

Not sure what's going on yet, and whether this is related to #143834.

@yjbanov
Copy link
Contributor

yjbanov commented Apr 3, 2024

Actually, most of the failures are related to #128382 (see this log file). The tests complete OK, but they complain about "Command did not write the response file but expected response file written". Reassigning to @linchen2chris for initial investigation.

@yjbanov yjbanov removed their assignment Apr 3, 2024
@yjbanov
Copy link
Contributor

yjbanov commented Apr 3, 2024

Looks like I cannot assign to @linchen2chris. So assigning to the first reviewer listed in the PR. @cbracken you drew the short straw :)

@cbracken cbracken removed their assignment Apr 9, 2024
@cbracken
Copy link
Member

cbracken commented Apr 9, 2024

Unassigning since this is one of the web-tests and the issue seems to be related to flutter driver, which which I'm not familiar. Looking at the PR I suspect I was the second required approver. Do we just need someone to revert that patch?

@cbracken
Copy link
Member

cbracken commented Apr 9, 2024

Looking quickly at the output and code, it looks like:

  1. We synchronously delete build/integration_response_data.json
  2. We run whatever web test this is
  3. We synchronously check for the presence of build/integration_response_data.json and fail to find it causing a failure.

That logic seems correct to me. @yjbanov what makes you think the file is definitely being written (and written on time)?

@yjbanov
Copy link
Contributor

yjbanov commented Apr 17, 2024

I actually don't know if it's being written. I also don't know what this file is and why it needs to be written. For now, I'm inclined to revert the change that expects it.

@fluttergithubbot
Copy link
Contributor Author

@keyonghan
Copy link
Contributor

Just came across the dashboard and noticed the flaky percentage (11 out recent 50 runs are flaky) continues high: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16274/infra

@yjbanov
Copy link
Contributor

yjbanov commented Apr 24, 2024

@keyonghan Yes, all the "web_long_running_tests" failures seem to have the same cause.

@fluttergithubbot
Copy link
Contributor Author

[prod pool] flaky ratio for the past (up to) 100 commits between 2024-04-18 and 2024-04-23 is 8.25%. Flaky number: 8; total number: 97.
One recent flaky example for a same commit: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16281,%2016282
Commit: 89a4ffa
Flaky builds:
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16282
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16281
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16274
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16273
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16272
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16263
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16262
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16257
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16237
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16223
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16206
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20web_long_running_tests_5_5/16204

Recent test runs:
https://flutter-dashboard.appspot.com/#/build?taskFilter=Linux%20web_long_running_tests_5_5

@yjbanov
Copy link
Contributor

yjbanov commented May 2, 2024

This may be the culprit, which I think is what @eyebrowsoffire already suspected:

[0501/183306.597435:INFO:CONSOLE(5)] "Injecting <script> tag. Using callback.", source: http://localhost:35733/flutter_bootstrap.js (5)
[0501/183306.726152:INFO:CONSOLE(168)] "Uncaught Error: Mismatched anonymous define() module: () => CanvasKitInit
http://requirejs.org/docs/errors.html#mismatch", source: http://localhost:35733/require.js (168)

auto-submit bot pushed a commit that referenced this issue May 2, 2024
…l other modes (#147736)

- Skip debug mode CanvasKit e2e tests due to flakiness.
- Unskip all other modes (`text_editing_integration` was over-skipped).

Fixes #146189
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
c: flake Tests that sometimes, but not always, incorrectly pass P0 Critical issues such as a build break or regression platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants