Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address leak tracker breaking changes. #128623

Merged
merged 3 commits into from Jun 12, 2023
Merged

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Jun 9, 2023

No description provided.

@polina-c polina-c marked this pull request as ready for review June 9, 2023 21:48
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 9, 2023
@polina-c polina-c mentioned this pull request Jun 9, 2023
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 9, 2023
@polina-c
Copy link
Contributor Author

polina-c commented Jun 9, 2023

@christopherfujino , feel free to merge the PR as soon as tree gets fixed.

@christopherfujino
Copy link
Member

@christopherfujino , feel free to merge the PR as soon as tree gets fixed.

Sounds good, I added autosubmit so the bot should handle that. Thanks again for the fix!

@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 10, 2023

auto label is removed for flutter/flutter, pr: 128623, Mergeability of pull request flutter/flutter/128623 could not be determined at time of merge..

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2023
@CoderDake CoderDake merged commit 05d1cde into flutter:master Jun 12, 2023
139 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 12, 2023
flutter/flutter@3df163f...353b8bc

2023-06-12 engine-flutter-autoroll@skia.org Roll Packages from afe2f05 to c9865e8 (6 revisions) (flutter/flutter#128701)
2023-06-12 nt4f04uNd@gmail.com Fix RangeSlider notifies start and end twice when participates in gesture arena (flutter/flutter#128674)
2023-06-12 polinach@google.com Address leak tracker breaking changes. (flutter/flutter#128623)
2023-06-12 tessertaha@gmail.com Update `ListTile` text defaults to use `ColorScheme` (flutter/flutter#128581)
2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from effea50196ca to 4b022f4e871f (2 revisions) (flutter/flutter#128683)
2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9bb0a5907403 to effea50196ca (1 revision) (flutter/flutter#128678)
2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 788437e41ee0 to 9bb0a5907403 (1 revision) (flutter/flutter#128673)
2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5da44b9aafdd to 788437e41ee0 (2 revisions) (flutter/flutter#128672)
2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e2c71adccad to 5da44b9aafdd (1 revision) (flutter/flutter#128669)
2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1cca9cc6dbd1 to 6e2c71adccad (1 revision) (flutter/flutter#128662)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@polina-c polina-c deleted the upgrade branch July 11, 2023 18:15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants