New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RangeSlider notifies start and end twice when participates in gesture arena #128674
Merged
auto-submit
merged 2 commits into
flutter:master
from
nt4f04uNd:fix/128433/range-slider-twice-bug
Jun 12, 2023
Merged
Fix RangeSlider notifies start and end twice when participates in gesture arena #128674
auto-submit
merged 2 commits into
flutter:master
from
nt4f04uNd:fix/128433/range-slider-twice-bug
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt4f04uNd
added
framework
flutter/packages/flutter repository. See also f: labels.
f: material design
flutter/packages/flutter/material repository.
f: gestures
flutter/packages/flutter/gestures repository.
labels
Jun 11, 2023
github-actions
bot
removed
the
f: gestures
flutter/packages/flutter/gestures repository.
label
Jun 11, 2023
TahaTesser
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nt4f04uNd
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Jun 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 12, 2023
…tes in gesture arena (flutter/flutter#128674)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 12, 2023
flutter/flutter@3df163f...353b8bc 2023-06-12 engine-flutter-autoroll@skia.org Roll Packages from afe2f05 to c9865e8 (6 revisions) (flutter/flutter#128701) 2023-06-12 nt4f04uNd@gmail.com Fix RangeSlider notifies start and end twice when participates in gesture arena (flutter/flutter#128674) 2023-06-12 polinach@google.com Address leak tracker breaking changes. (flutter/flutter#128623) 2023-06-12 tessertaha@gmail.com Update `ListTile` text defaults to use `ColorScheme` (flutter/flutter#128581) 2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from effea50196ca to 4b022f4e871f (2 revisions) (flutter/flutter#128683) 2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9bb0a5907403 to effea50196ca (1 revision) (flutter/flutter#128678) 2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 788437e41ee0 to 9bb0a5907403 (1 revision) (flutter/flutter#128673) 2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5da44b9aafdd to 788437e41ee0 (2 revisions) (flutter/flutter#128672) 2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6e2c71adccad to 5da44b9aafdd (1 revision) (flutter/flutter#128669) 2023-06-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1cca9cc6dbd1 to 6e2c71adccad (1 revision) (flutter/flutter#128662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
…tes in gesture arena (flutter/flutter#128674)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…tes in gesture arena (flutter/flutter#128674)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…tes in gesture arena (flutter/flutter#128674)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…tes in gesture arena (flutter/flutter#128674)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
f: material design
flutter/packages/flutter/material repository.
f: scrolling
Viewports, list views, slivers, etc.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128433
This PR applies the same fix as we did for Slider #82152
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.