New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] pass through enable impeller flag to macOS. #128720
[flutter_tools] pass through enable impeller flag to macOS. #128720
Conversation
@@ -300,6 +300,82 @@ void main() { | |||
), | |||
); | |||
}); | |||
|
|||
testWithoutContext('Device devices that support impeller pass through the enable-impeller flag', () async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean "Desktop devices"?
testWithoutContext('Device devices that support impeller pass through the enable-impeller flag', () async { | |
testWithoutContext('Desktop devices that support impeller pass through the enable-impeller flag', () async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol yes, thanks
processManager: processManager, | ||
supportsImpeller: true, | ||
); | ||
unawaited(Future<void>(() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this unawaited?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy paste, removed
); | ||
}); | ||
|
||
testWithoutContext('Device devices that do not support impeller ignore the enable-impeller flag', () async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testWithoutContext('Device devices that do not support impeller ignore the enable-impeller flag', () async { | |
testWithoutContext('Desktop devices that do not support impeller ignore the enable-impeller flag', () async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Technically this doesn't work until flutter/engine#42639 rolls in, but its not harmful to land before that as it doesn't change behavior. |
flutter/flutter@353b8bc...09b7e56 2023-06-13 engine-flutter-autoroll@skia.org Roll Packages from c9865e8 to 0507297 (6 revisions) (flutter/flutter#128796) 2023-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 346f051ac062 to f9a0a0dafeea (1 revision) (flutter/flutter#128786) 2023-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5951f90cbac3 to 346f051ac062 (1 revision) (flutter/flutter#128783) 2023-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3b70103f53bc to 5951f90cbac3 (1 revision) (flutter/flutter#128781) 2023-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 04ffeb4ab103 to 3b70103f53bc (1 revision) (flutter/flutter#128778) 2023-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42ccd12a14c2 to 04ffeb4ab103 (4 revisions) (flutter/flutter#128772) 2023-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from aa1693f6aaeb to 42ccd12a14c2 (1 revision) (flutter/flutter#128761) 2023-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from d02b15ef34ef to aa1693f6aaeb (3 revisions) (flutter/flutter#128759) 2023-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from f67ed35b142e to d02b15ef34ef (2 revisions) (flutter/flutter#128754) 2023-06-13 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1714d73e681b to f67ed35b142e (3 revisions) (flutter/flutter#128751) 2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 12def739b1f6 to 1714d73e681b (2 revisions) (flutter/flutter#128738) 2023-06-12 katelovett@google.com Fix paint offset in reverse for 2D (flutter/flutter#128724) 2023-06-12 jonahwilliams@google.com [flutter_tools] pass through enable impeller flag to macOS. (flutter/flutter#128720) 2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from de68fba09338 to 12def739b1f6 (2 revisions) (flutter/flutter#128726) 2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 33e06934daed to de68fba09338 (10 revisions) (flutter/flutter#128721) 2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4b022f4e871f to 33e06934daed (6 revisions) (flutter/flutter#128706) 2023-06-12 hans.muller@gmail.com Update button tests for Material 3 by default (flutter/flutter#128628) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Allow passing through the --enable-impeller flag to macOS.