Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_tools] delete flutter format command #129360

Merged
merged 1 commit into from Jun 22, 2023
Merged

[flutter_tools] delete flutter format command #129360

merged 1 commit into from Jun 22, 2023

Conversation

christopherfujino
Copy link
Member

@christopherfujino christopherfujino commented Jun 22, 2023 •
edited

On the current stable branch (3.10.x), flutter format no longer works, and gives an error. This change just deletes the code.

Fixes #115809

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 22, 2023
eliasyishak
eliasyishak approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@eliasyishak eliasyishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

jonahwilliams
jonahwilliams approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 22, 2023

auto label is removed for flutter/flutter, pr: 129360, Mergeability of pull request flutter/flutter/129360 could not be determined at time of merge..

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit auto-submit bot merged commit 6f3b078 into flutter:master Jun 22, 2023
123 checks passed
@christopherfujino christopherfujino deleted the delete-format-command branch June 22, 2023 21:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
e3e9713 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
e51d6cf 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
663401d 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
81fe31a 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
4afd7d3 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
441d6bc 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
d26a6d2 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
d874d81 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
1ca36e9 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
685e350 
…ter#129360)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
18a1e81 
…ter#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
c1e6244 
…ter#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
47799b2 
…ter#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
04cdd41 
…ter#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
04dc8df 
…ter#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
2de6c4d 
…ter#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
a987f92 
…ter#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
270678e 
…ter#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
421a57d 
…ter#129360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
6f3b07811 [flutter_tools] delete flutter format command (flutter/flut…
7ea16e4 
…ter#129360)
@parlough parlough mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@eliasyishak eliasyishak eliasyishak approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flutter_tools] Deprecate flutter format sub-command in favor of dart format
3 participants
@christopherfujino @jonahwilliams @eliasyishak