New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL InputDecoration fix #129661
Merged
Merged
RTL InputDecoration fix #129661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
approved these changes
Jun 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 29, 2023
camsim99
added a commit
to flutter/packages
that referenced
this pull request
Jun 30, 2023
flutter/flutter@51bef1b...ff838bc 2023-06-29 thkim1011@users.noreply.github.com Add locale-specific DateTime formatting syntax (flutter/flutter#129573) 2023-06-29 tessertaha@gmail.com Update `RadioListTile` tests to M3 (flutter/flutter#129718) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7fd0e9522ea1 to eabb22900b44 (1 revision) (flutter/flutter#129754) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5c25ead07e9 to 7fd0e9522ea1 (2 revisions) (flutter/flutter#129752) 2023-06-29 tjtanjia.tan@gmail.com Fix typos in ListTile examples. (flutter/flutter#129606) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4e49b9deb72d to d5c25ead07e9 (7 revisions) (flutter/flutter#129750) 2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from 241ca5c1d6be to 4e49b9deb72d (1 revision) (flutter/flutter#129730) 2023-06-29 jacksongardner@google.com Skwasm benchmarks. (flutter/flutter#129681) 2023-06-28 jmccandless@google.com RTL InputDecoration fix (flutter/flutter#129661) 2023-06-28 christopherfujino@gmail.com mark autoroller flaky (flutter/flutter#129745) 2023-06-28 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#129380) 2023-06-28 109253501+pdblasi-google@users.noreply.github.com Removes deprecated APIs from AnimationBuilder (flutter/flutter#129657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md --------- Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the wrong padding was being used in the layout logic in RTL mode when using a prefixIcon. This fixes it.
This bug seems to have been in the codebase for 5 years. However, it doesn't manifest itself unless 1. RTL 2. prefixIcon and 3. asymmetric left/right contentPadding, so that's probably why it wasn't reported until now.
Fixes #129591
Code to reproduce