Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in ListTile examples. #129606

Merged
merged 2 commits into from Jun 29, 2023
Merged

Fix typos in ListTile examples. #129606

merged 2 commits into from Jun 29, 2023

Conversation

crazytan
Copy link
Contributor

@crazytan crazytan commented Jun 27, 2023

Fix typos.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Jun 27, 2023
@TahaTesser TahaTesser self-requested a review June 27, 2023 12:48
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser
Copy link
Member

This will need a test-exemption from @Hixie

@github-actions github-actions bot removed the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Jun 28, 2023
@Hixie
Copy link
Contributor

Hixie commented Jun 28, 2023

test-exempt: code refactor with no semantic change

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 28, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 28, 2023

auto label is removed for flutter/flutter, pr: 129606, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 28, 2023
@crazytan
Copy link
Contributor Author

Can someone else approve this PR? Thanks!

@danagbemava-nc
Copy link
Member

LGTM

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2023
@auto-submit auto-submit bot merged commit 87194a2 into flutter:master Jun 29, 2023
39 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 29, 2023
@crazytan crazytan deleted the patch-1 branch June 30, 2023 04:58
camsim99 added a commit to flutter/packages that referenced this pull request Jun 30, 2023
flutter/flutter@51bef1b...ff838bc

2023-06-29 thkim1011@users.noreply.github.com Add locale-specific
DateTime formatting syntax (flutter/flutter#129573)
2023-06-29 tessertaha@gmail.com Update `RadioListTile` tests to M3
(flutter/flutter#129718)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from
7fd0e9522ea1 to eabb22900b44 (1 revision) (flutter/flutter#129754)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from
d5c25ead07e9 to 7fd0e9522ea1 (2 revisions) (flutter/flutter#129752)
2023-06-29 tjtanjia.tan@gmail.com Fix typos in ListTile examples.
(flutter/flutter#129606)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from
4e49b9deb72d to d5c25ead07e9 (7 revisions) (flutter/flutter#129750)
2023-06-29 engine-flutter-autoroll@skia.org Roll Flutter Engine from
241ca5c1d6be to 4e49b9deb72d (1 revision) (flutter/flutter#129730)
2023-06-29 jacksongardner@google.com Skwasm benchmarks.
(flutter/flutter#129681)
2023-06-28 jmccandless@google.com RTL InputDecoration fix
(flutter/flutter#129661)
2023-06-28 christopherfujino@gmail.com mark autoroller flaky
(flutter/flutter#129745)
2023-06-28 fluttergithubbot@gmail.com Roll pub packages
(flutter/flutter#129380)
2023-06-28 109253501+pdblasi-google@users.noreply.github.com Removes
deprecated APIs from AnimationBuilder (flutter/flutter#129657)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

---------

Co-authored-by: Camille Simon <43054281+camsim99@users.noreply.github.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants