Next attempt to make inspector weakly referencing the inspected objects. #129962

polina-c · 2023-07-04T17:57:14Z

Bugger issue: flutter/devtools#3951
Reverts #128506

Previous failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_widgets/11385/overview

Failed line:

final DiagnosticsNode diagnosticsNode = service.toObject(childJson['objectId']! as String)! as DiagnosticsNode;

Changes since previous attempts:

Replaced ...)! as DiagnosticsNode; with ...) as DiagnosticsNode?;
Removed _forceGC
Cleaned up inspector API:

Reproduced issue and tested locally with commands:

flutter test test/widgets/widget_inspector_test.dart --update-goldens --fatal-warnings

flutter test --test-randomize-ordering-seed=20230608 --fatal-warnings --track-widget-creation test/widgets/widget_inspector_test.dart --update-goldens

flutter test --test-randomize-ordering-seed=20230609 --fatal-warnings --track-widget-creation test/widgets/widget_inspector_test.dart --update-goldens

flutter test test/widgets/widget_inspector_test.dart --update-goldens --track-widget-creation --fatal-warnings --plain-name ext.flutter.inspector.getRootWidgetSummaryTree

…objects." (flutter#128506)" This reverts commit c8bcff4.

zanderso

lgtm w/ nit

zanderso · 2023-07-06T16:37:12Z

packages/flutter/lib/src/widgets/widget_inspector.dart

    if (id == null) {
+      // TODO(polina-c): comment here why we increase memory footprint by the prefix 'inspector-'.


nit: TODOs require an issue link: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-checking-in-comments-that-ask-questions.

But if this is a TODO just to add a comment, could it just be added in this PR?

Added issue. I do not know the answer and it will require research to get it.

…cted objects. (flutter/flutter#129962)

flutter/flutter@bc49cd1...d55a7d8 2023-07-07 hans.muller@gmail.com Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." (flutter/flutter#130144) 2023-07-07 engine-flutter-autoroll@skia.org Roll Packages from 771ec9b to 9bcf4bf (12 revisions) (flutter/flutter#130143) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 650ff096488a to 8aa2e6516af1 (1 revision) (flutter/flutter#130116) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1fa222fae283 to 650ff096488a (3 revisions) (flutter/flutter#130114) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 491f317978f4 to 1fa222fae283 (1 revision) (flutter/flutter#130110) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48bf7ac59254 to 491f317978f4 (2 revisions) (flutter/flutter#130107) 2023-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42df55a9e63e to 48bf7ac59254 (1 revision) (flutter/flutter#130106) 2023-07-06 5236035+fzyzcjy@users.noreply.github.com Super tiny code optimization: No need to redundantly check whether value has changed (flutter/flutter#130050) 2023-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 06c936205d96 to 42df55a9e63e (3 revisions) (flutter/flutter#130100) 2023-07-06 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from bd2e42b203e1 to 06c936205d96 (27 revisions) (flutter/flutter#130097) 2023-07-06 fluttergithubbot@gmail.com Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky (flutter/flutter#128398) 2023-07-06 polinach@google.com Next attempt to make inspector weakly referencing the inspected objects. (flutter/flutter#129962) 2023-07-06 82336674+gilnobrega@users.noreply.github.com [a11y] CupertinoSwitch On/Off labels (flutter/flutter#127776) 2023-07-06 henriquenas.dev@gmail.com Add option for flexible space on material SearchDelegate (flutter/flutter#128132) 2023-07-06 engine-flutter-autoroll@skia.org Roll Packages from 7042079 to 771ec9b (12 revisions) (flutter/flutter#130077) 2023-07-06 2539699336@qq.com [framework] Add textField OCR support for framework side (flutter/flutter#96637) 2023-07-06 37002358+fabiancrx@users.noreply.github.com [flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder (flutter/flutter#128810) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…cted objects. (flutter/flutter#129962)

polina-c added 16 commits June 8, 2023 19:05

Revert "Revert "Redo make inspector weakly referencing the inspected …

da1fa67

…objects." (flutter#128506)" This reverts commit c8bcff4.

Update widget_inspector_test.dart

71bcce4

Update widget_inspector_test.dart

efed645

Update widget_inspector_test.dart

f9b963c

Update widget_inspector_test.dart

0d4563a

Update widget_inspector_test.dart

d8b0b3d

Update widget_inspector_test.dart

d2ea052

Update widget_inspector_test.dart

fa001d7

Update widget_inspector_test.dart

bd56061

Merge branch 'master' of https://github.com/flutter/flutter into redo

7012b4f

Update widget_inspector_test.dart

1eba4b4

Merge branch 'master' of https://github.com/flutter/flutter into redo

55cea22

Update widget_inspector_test.dart

99e05a0

Update widget_inspector.dart

b01641e

Update widget_inspector.dart

9652b7b

Merge branch 'master' of https://github.com/flutter/flutter into redo4

03e0686

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 4, 2023

Update widget_inspector.dart

2c8819b

polina-c changed the title ~~Redo4~~ Next attempt to make inspector weakly referencing the inspected objects. Jul 4, 2023

polina-c added 8 commits July 4, 2023 11:11

Update widget_inspector_test.dart

3211f55

Update widget_inspector_test.dart

62e63d8

Update widget_inspector_test.dart

e12c446

Update widget_inspector_test.dart

04439ac

-

ac8257b

Update framework.dart

47f6d65

Merge branch 'master' of https://github.com/flutter/flutter into redo4

56230f1

Update widget_inspector_test.dart

cd55064

polina-c marked this pull request as ready for review July 5, 2023 21:18

zanderso self-requested a review July 5, 2023 21:27

Update framework_test.dart

2e383d3

zanderso approved these changes Jul 6, 2023

View reviewed changes

polina-c added 2 commits July 6, 2023 10:24

Update widget_inspector.dart

ff9112c

Merge branch 'master' of https://github.com/flutter/flutter into redo4

19809a0

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2023

polina-c merged commit bff6b93 into flutter:master Jul 6, 2023
71 of 72 checks passed

polina-c deleted the redo4 branch July 6, 2023 19:19

polina-c mentioned this pull request Jul 6, 2023

leak-tracker: Detect memory leaks by identifying not disposed or not GCed objects. flutter/devtools#3951

Open

engine-flutter-autoroll mentioned this pull request Jul 7, 2023

Roll Flutter from bc49cd1bcab5 to ce9a604a3bad (15 revisions) flutter/packages#4398

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2023

bff6b9368 Next attempt to make inspector weakly referencing the inspe…

3706e7b

…cted objects. (flutter/flutter#129962)

engine-flutter-autoroll mentioned this pull request Jul 7, 2023

Roll Flutter from bc49cd1bcab5 to d5b8db303f6d (16 revisions) flutter/packages#4401

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2023

bff6b9368 Next attempt to make inspector weakly referencing the inspe…

291098c

…cted objects. (flutter/flutter#129962)

engine-flutter-autoroll mentioned this pull request Jul 7, 2023

Roll Flutter from bc49cd1bcab5 to d55a7d89e05e (17 revisions) flutter/packages#4403

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2023

bff6b9368 Next attempt to make inspector weakly referencing the inspe…

67d7e9f

…cted objects. (flutter/flutter#129962)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

bff6b9368 Next attempt to make inspector weakly referencing the inspe…

e2620e5

…cted objects. (flutter/flutter#129962)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

bff6b9368 Next attempt to make inspector weakly referencing the inspe…

cbfd330

…cted objects. (flutter/flutter#129962)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

bff6b9368 Next attempt to make inspector weakly referencing the inspe…

bf6872f

…cted objects. (flutter/flutter#129962)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

bff6b9368 Next attempt to make inspector weakly referencing the inspe…

8e4868c

…cted objects. (flutter/flutter#129962)

polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Next attempt to make inspector weakly referencing the inspected objects. #129962

Next attempt to make inspector weakly referencing the inspected objects. #129962

polina-c commented Jul 4, 2023 •

edited

zanderso left a comment

zanderso Jul 6, 2023

polina-c Jul 6, 2023

		if (id == null) {
		// TODO(polina-c): comment here why we increase memory footprint by the prefix 'inspector-'.

Next attempt to make inspector weakly referencing the inspected objects. #129962

Next attempt to make inspector weakly referencing the inspected objects. #129962

Conversation

polina-c commented Jul 4, 2023 • edited

zanderso left a comment

Choose a reason for hiding this comment

zanderso Jul 6, 2023

Choose a reason for hiding this comment

polina-c Jul 6, 2023

Choose a reason for hiding this comment

polina-c commented Jul 4, 2023 •

edited