[framework] Add textField OCR support for framework side #96637

luckysmg · 2022-01-14T01:43:30Z

Preview

12.26.mp4

Related PR in flutter engine (merged):

[iOS] Add iOS live text input engine side support engine#34751

List which issues are fixed by this PR. You must list at least one issue.
#91896

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

Hixie · 2022-05-24T23:26:37Z

@luckysmg Is this still something you are working on? I'm just asking because I'm trying to clean out our review queue.

luckysmg · 2022-05-25T00:50:09Z

Yes，this is still working on, but maybe will not update the progress recently…..I will continue this later😄 发自我的iPhone

…

------------------ Original ------------------ From: Ian Hickson ***@***.***> Date: Wed,May 25,2022 7:26 AM To: flutter/flutter ***@***.***> Cc: WenJingRui ***@***.***>, Mention ***@***.***> Subject: Re: [flutter/flutter] [WIP] Support ios text ocr (PR #96637) @luckysmg Is this still something you are working on? I'm just asking because I'm trying to clean out our review queue. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

luckysmg · 2022-06-01T01:02:28Z

The engine side is working around and ready for review.
flutter/engine#34751

After engine side PR merged, work in framework side(here) will start.

packages/flutter/lib/src/cupertino/text_selection_toolbar_button.dart

packages/flutter/lib/src/services/live_text_support.dart

packages/flutter/lib/src/services/text_input.dart

packages/flutter/lib/src/widgets/editable_text.dart

packages/flutter/lib/src/widgets/text_selection.dart

Hixie · 2022-12-14T00:17:49Z

@luckysmg Are you still working on this? Looks like you did good progress since the last time I asked. :-)

luckysmg · 2022-12-14T02:04:22Z

Hi @Hixie Very apologize on this.Before I was thinking to work after #107193 merged, because with that code will be more clear and easier. Now, it has been merged and I will continue this work. (^▽^)

luckysmg · 2022-12-15T12:02:27Z

HI @Hixie.

I come across two things.

I need a iOS style scan text icon, but I can't find it in CupertinoIcons, would you mind telling me how to get that or how to add it to framework? ^_^
Is there a way to regenerate the arb file? I want add a new localiztion text string scanTextButtonLabel. Or I should manually add it for all different languages ?
O(∩_∩)O

luckysmg · 2022-12-15T12:07:06Z

Hi @justinmc. Would you mind sharing your thoughts on current implementation? O(∩_∩)O

luckysmg · 2023-07-05T02:00:28Z

@tgucio All Done. plz re-review ^_^

tgucio · 2023-07-05T09:56:00Z

packages/flutter_localizations/lib/src/l10n/material_ur.arb

@@ -25,6 +25,7 @@
  "continueButtonLabel": "جاری رکھیں",
  "copyButtonLabel": "کاپی کریں",
  "cutButtonLabel": "کٹ کریں",
+  "scanTextButtonLabel": "متن کو اسکین کریں۔",


Looks like this has been updated as follows:

- "scanTextButtonLabel": "متن اسکین کریں۔", + "scanTextButtonLabel": "متن کو اسکین کریں۔",

There's an extra word but the Arabic full stop character ('۔') is still there.

tgucio · 2023-07-05T09:59:24Z

packages/flutter/lib/src/cupertino/text_selection_toolbar_button.dart

+      canvas.transform(rotationMatrix.storage);
+    }
+
+    // Draw three lines.


Looks like there are still some doubles without decimal point in this method and possibly elsewhere e.g.:
..lineTo(origin.dx, origin.dy + 1)
canvas.drawLine(const Offset(-3, 0), const Offset(3, 0), _painter);

tgucio · 2023-07-05T10:13:10Z

@luckysmg I've LGTM'd with nits: remaining full stop in Urdu l10n and some doubles without decimal point in text_selection_toolbar_button.dart - could you look into those before merging?

luckysmg · 2023-07-05T10:16:03Z

Yes. I ll take a look before merging... Will change. ^_^

Before I didn't understand your meaning very well haha ^_^

luckysmg · 2023-07-05T11:14:07Z

@tgucio I think all nits done. You can take a look

luckysmg · 2023-07-05T11:34:39Z

Also @justinmc would you mind help to take a look that why google testing still not completed? ^_^

justinmc · 2023-07-06T15:50:19Z

Google tests look fine despite the stuck "pending" status. I tried to change the status but it is giving an HTTP error. Merging.

justinmc · 2023-07-06T15:51:30Z

@luckysmg Thanks for all your work here!

Void48 · 2023-07-06T21:11:33Z

@luckysmg gj :)

…lutter/flutter#96637)

flutter/flutter@bc49cd1...d55a7d8 2023-07-07 hans.muller@gmail.com Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." (flutter/flutter#130144) 2023-07-07 engine-flutter-autoroll@skia.org Roll Packages from 771ec9b to 9bcf4bf (12 revisions) (flutter/flutter#130143) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 650ff096488a to 8aa2e6516af1 (1 revision) (flutter/flutter#130116) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1fa222fae283 to 650ff096488a (3 revisions) (flutter/flutter#130114) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 491f317978f4 to 1fa222fae283 (1 revision) (flutter/flutter#130110) 2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 48bf7ac59254 to 491f317978f4 (2 revisions) (flutter/flutter#130107) 2023-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 42df55a9e63e to 48bf7ac59254 (1 revision) (flutter/flutter#130106) 2023-07-06 5236035+fzyzcjy@users.noreply.github.com Super tiny code optimization: No need to redundantly check whether value has changed (flutter/flutter#130050) 2023-07-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 06c936205d96 to 42df55a9e63e (3 revisions) (flutter/flutter#130100) 2023-07-06 engine-flutter-autoroll@skia.org Manual roll Flutter Engine from bd2e42b203e1 to 06c936205d96 (27 revisions) (flutter/flutter#130097) 2023-07-06 fluttergithubbot@gmail.com Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky (flutter/flutter#128398) 2023-07-06 polinach@google.com Next attempt to make inspector weakly referencing the inspected objects. (flutter/flutter#129962) 2023-07-06 82336674+gilnobrega@users.noreply.github.com [a11y] CupertinoSwitch On/Off labels (flutter/flutter#127776) 2023-07-06 henriquenas.dev@gmail.com Add option for flexible space on material SearchDelegate (flutter/flutter#128132) 2023-07-06 engine-flutter-autoroll@skia.org Roll Packages from 7042079 to 771ec9b (12 revisions) (flutter/flutter#130077) 2023-07-06 2539699336@qq.com [framework] Add textField OCR support for framework side (flutter/flutter#96637) 2023-07-06 37002358+fabiancrx@users.noreply.github.com [flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder (flutter/flutter#128810) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter/flutter#96637)

justinmc · 2023-08-30T17:58:58Z

Congrats to @luckysmg and @tgucio for the shout out in the 3.13 blog post! https://medium.com/flutter/whats-new-in-flutter-3-13-479d9b11df4d

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Jan 14, 2022

luckysmg marked this pull request as draft January 14, 2022 01:43

luckysmg mentioned this pull request Jan 14, 2022

[WIP][iOS]Add TextField OCR engine side support flutter/engine#29229

Closed

8 tasks

luckysmg changed the title ~~Ios text ocr~~ [WIP] Support ios text ocr Feb 4, 2022

luckysmg changed the title ~~[WIP] Support ios text ocr~~ [WIP] Add textField OCR support for framework side May 28, 2022

luckysmg mentioned this pull request Jul 19, 2022

[iOS] Add iOS live text input engine side support flutter/engine#34751

Merged

8 tasks

flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Jul 19, 2022

tgucio reviewed Jul 20, 2022

View reviewed changes

luckysmg force-pushed the ios_text_ocr branch from 0168cec to 6f5f808 Compare July 20, 2022 14:19

Add new text OCR impl

ed104a9

luckysmg closed this Dec 15, 2022

luckysmg force-pushed the ios_text_ocr branch from 3446bce to dbc9306 Compare December 15, 2022 04:19

Merge branch 'flutter:master' into ios_ocr

b5cf438

luckysmg reopened this Dec 15, 2022

luckysmg added 3 commits December 15, 2022 12:27

Fix test error

374efed

++

8691dce

Add support for tool bar

8b46a64

luckysmg added 4 commits December 16, 2022 10:24

Merge branch 'flutter:master' into ios_text_ocr

995bdab

Delete localization for the moment

5a90f00

++

7acbb16

++

5bc7bff

luckysmg added 3 commits July 5, 2023 00:25

++

779680b

Merge branch 'master' into ios_text_ocr

8e0874a

++

aef841d

luckysmg requested a review from tgucio July 5, 2023 02:00

tgucio approved these changes Jul 5, 2023

View reviewed changes

++

857c799

justinmc merged commit e0ad129 into flutter:master Jul 6, 2023
71 of 72 checks passed

engine-flutter-autoroll mentioned this pull request Jul 7, 2023

Roll Flutter from bc49cd1bcab5 to ce9a604a3bad (15 revisions) flutter/packages#4398

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2023

e0ad12969 [framework] Add textField OCR support for framework side (f…

8a7b1c8

…lutter/flutter#96637)

engine-flutter-autoroll mentioned this pull request Jul 7, 2023

Roll Flutter from bc49cd1bcab5 to d5b8db303f6d (16 revisions) flutter/packages#4401

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2023

e0ad12969 [framework] Add textField OCR support for framework side (f…

73d8bbe

…lutter/flutter#96637)

engine-flutter-autoroll mentioned this pull request Jul 7, 2023

Roll Flutter from bc49cd1bcab5 to d55a7d89e05e (17 revisions) flutter/packages#4403

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2023

e0ad12969 [framework] Add textField OCR support for framework side (f…

29f6ee9

…lutter/flutter#96637)

HansMuller mentioned this pull request Jul 7, 2023

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

e0ad12969 [framework] Add textField OCR support for framework side (f…

63c9cab

…lutter/flutter#96637)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

e0ad12969 [framework] Add textField OCR support for framework side (f…

99dd84c

…lutter/flutter#96637)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

e0ad12969 [framework] Add textField OCR support for framework side (f…

532f3d4

…lutter/flutter#96637)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

e0ad12969 [framework] Add textField OCR support for framework side (f…

df2a85d

…lutter/flutter#96637)

JSUYA mentioned this pull request Aug 28, 2023

[engine] Sync Flutter 3.13.1 source code flutter-tizen/embedder#44

Merged

JSUYA mentioned this pull request Sep 8, 2023

Update to SystemChannel flutter-tizen/embedder#47

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[framework] Add textField OCR support for framework side #96637

[framework] Add textField OCR support for framework side #96637

luckysmg commented Jan 14, 2022 •

edited

Hixie commented May 24, 2022

luckysmg commented May 25, 2022 via email

luckysmg commented Jun 1, 2022 •

edited

Hixie commented Dec 14, 2022

luckysmg commented Dec 14, 2022 •

edited

luckysmg commented Dec 15, 2022 •

edited

luckysmg commented Dec 15, 2022

luckysmg commented Jul 5, 2023

tgucio Jul 5, 2023

tgucio Jul 5, 2023

tgucio commented Jul 5, 2023

luckysmg commented Jul 5, 2023 •

edited

luckysmg commented Jul 5, 2023

luckysmg commented Jul 5, 2023

justinmc commented Jul 6, 2023

justinmc commented Jul 6, 2023

Void48 commented Jul 6, 2023

justinmc commented Aug 30, 2023

[framework] Add textField OCR support for framework side #96637

[framework] Add textField OCR support for framework side #96637

Conversation

luckysmg commented Jan 14, 2022 • edited

Preview

Related PR in flutter engine (merged):

Pre-launch Checklist

Hixie commented May 24, 2022

luckysmg commented May 25, 2022 via email

luckysmg commented Jun 1, 2022 • edited

Hixie commented Dec 14, 2022

luckysmg commented Dec 14, 2022 • edited

luckysmg commented Dec 15, 2022 • edited

luckysmg commented Dec 15, 2022

luckysmg commented Jul 5, 2023

tgucio Jul 5, 2023

Choose a reason for hiding this comment

tgucio Jul 5, 2023

Choose a reason for hiding this comment

tgucio commented Jul 5, 2023

luckysmg commented Jul 5, 2023 • edited

luckysmg commented Jul 5, 2023

luckysmg commented Jul 5, 2023

justinmc commented Jul 6, 2023

justinmc commented Jul 6, 2023

Void48 commented Jul 6, 2023

justinmc commented Aug 30, 2023

luckysmg commented Jan 14, 2022 •

edited

luckysmg commented Jun 1, 2022 •

edited

luckysmg commented Dec 14, 2022 •

edited

luckysmg commented Dec 15, 2022 •

edited

luckysmg commented Jul 5, 2023 •

edited